From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AC2E4404EA for ; Tue, 21 Dec 2021 01:42:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F109068AF86; Tue, 21 Dec 2021 03:42:47 +0200 (EET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3B907680157 for ; Tue, 21 Dec 2021 03:42:41 +0200 (EET) Received: by mail-pj1-f49.google.com with SMTP id y16-20020a17090a6c9000b001b13ffaa625so963163pjj.2 for ; Mon, 20 Dec 2021 17:42:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=4HfyLRurj3lAi4wmruNbXilIEEM6PrTiGhpKPg+vUBg=; b=VNWL/0dW/GqcMzF6RvopkBRkGUHVOW0gsyBm+f1NDICHP5wCjalqWexadwXudu8/3r spudaMrb7cP/VqdCdTCYOqRck2+ySsCMcyhPte+Ce1lkFg0JrNXqvbI5azzXyCY80Hkj LRbDqoHREBAzJC16IHtGpz0puVRDcdJQNnZ5Ygy03K+IC4k2yuQEqUpYQJCWxImLnK8z eFJWVJUgpgYNN/RzpTZk7UyQpiNbm+QVoT9tTPOlHQhcE9Lt5JkxhXeVyuXzDNs9oBUb +rzfj91VzQqFHYjCz/dAg1T69UujtzFTddZVVnN88UqU2dYOu8Ry4g13MqbHkW2EsndQ eFlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=4HfyLRurj3lAi4wmruNbXilIEEM6PrTiGhpKPg+vUBg=; b=JITWwkMmNdbCLTTM2wAEvAKQiQmBuG2WgzeQ+84B+EEbGKQJ2f7nsUYGjSGlMi5wg6 naJZLkNnyB46RD2BYJkp/tDZBKYspYZlfwogxFU3Mwd3Pibh1n4tuCQ3jTsVR+k8ps3E HNN0AW0p5aTqfz2zoAP0WBTPrFldwH2tJ9xSLZY1sVCS29C5CbpsdEPgLPPMSfrhYC// ozoz1Q6YH8uYbBFL0peaov7v9lOtnc32OMT+OKJKcHYEQZL3KxtISw0DPhcBzJvfRL7Q b5sQMUGARhc104rSO5UTsYjH8VgHHpg0WHIh6TNRL3QypSF+eOsK+jwF38+wEMmXKDEW jAUQ== X-Gm-Message-State: AOAM531utCM4nGxWKyK8T8ZBY565BAvxyvFvUXKBN8fOc9VW1CwRQ+tk naVG19Mzu24nMZiqm5SCTqDRpxok0W8= X-Google-Smtp-Source: ABdhPJwU3E0z6GibxXrP+R8L+s8Lfp8LJzY5JsK0ZLoOGAD0IWVIDvajBX3kDRr3P3n1aKqTVTh0UA== X-Received: by 2002:a17:902:7489:b0:149:2088:8e80 with SMTP id h9-20020a170902748900b0014920888e80mr681541pll.124.1640050958817; Mon, 20 Dec 2021 17:42:38 -0800 (PST) Received: from gmail.com ([161.117.202.209]) by smtp.gmail.com with ESMTPSA id z4sm21033182pfh.15.2021.12.20.17.42.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Dec 2021 17:42:38 -0800 (PST) Date: Tue, 21 Dec 2021 09:42:35 +0800 From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Message-ID: <20211221014235.GA18955@gmail.com> Mail-Followup-To: ffmpeg-devel@ffmpeg.org References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libx264: Don't unnecessarily add in-band extradata X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Dec 20, 2021 at 07:22:56PM +0100, Andreas Rheinhardt wrote: > The check here is meant to check for whether avcintra-class option > (default value -1) has been set; yet it checks for the x264_param_t > value where 0 is the default value (treated as "no avcintra-mode" > by x264). This meant that in-band extradata has been added unnecessarily > when using global headers; furthermore, the first output packet > had two x264 SEIs. > > Signed-off-by: Andreas Rheinhardt > --- > This would have been found ages ago if we could test external > components. > > libavcodec/libx264.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c > index 5f62c7b1d8..2b680abf21 100644 > --- a/libavcodec/libx264.c > +++ b/libavcodec/libx264.c > @@ -944,7 +944,7 @@ static av_cold int X264_init(AVCodecContext *avctx) > > #if X264_BUILD >= 142 > /* Separate headers not supported in AVC-Intra mode */ > - if (x4->params.i_avcintra_class >= 0) > + if (x4->avcintra_class >= 0) > x4->params.b_repeat_headers = 1; > #endif > > -- > 2.32.0 good catch, LGTM, thanks. > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".