From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 4793940356
	for <ffmpegdev@gitmailbox.com>; Mon, 20 Dec 2021 14:47:52 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9732168AF05;
	Mon, 20 Dec 2021 16:47:51 +0200 (EET)
Received: from haasn.dev (haasn.dev [78.46.187.166])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3E1B868A830
 for <ffmpeg-devel@ffmpeg.org>; Mon, 20 Dec 2021 16:47:46 +0200 (EET)
Received: from haasn.dev (unknown [10.30.0.2])
 by haasn.dev (Postfix) with ESMTP id F33F04934A;
 Mon, 20 Dec 2021 15:47:45 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail;
 t=1640011666; bh=sLoez2USZ+1/CNxwWBhTlWq9KMpSmeOTb7Xp5aZnyqM=;
 h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
 b=ocfFJnH3KDix2WgB2/rLl+pnH94bRKJuHhkATKfgxdqPfRG030Uc2pzE9rDGpmSl4
 1DeyA0vlsT++tM4LavoCKOh+WmNOM8Bw/pVUufbxecFVaNBQXHG8Rw43tR+TqwfTH3
 UK4EgN7JmLNBgM3bMaHFSCaWFvWUN+PXPnJkJkkw=
Date: Mon, 20 Dec 2021 15:47:45 +0100
Message-ID: <20211220154745.GB7072@xor.haasn.dev>
From: Niklas Haas <ffmpeg@haasn.xyz>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <163999519548.13029.13385878156195650068@lain.red.khirnov.net>
References: <20211212115546.119662-1-ffmpeg@haasn.xyz>
 <20211212115546.119662-4-ffmpeg@haasn.xyz>
 <163999519548.13029.13385878156195650068@lain.red.khirnov.net>
MIME-Version: 1.0
Content-Disposition: inline
Subject: Re: [FFmpeg-devel] [PATCH v5 4/6] lavc: Implement Dolby Vision RPU
 parsing
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Niklas Haas <git@haasn.dev>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20211220154745.GB7072@xor.haasn.dev/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Mon, 20 Dec 2021 11:13:15 +0100 Anton Khirnov <anton@khirnov.net> wrote:
> nit: FF_ARRAY_ELEMS(s->vdr_ref) is considered better

Done.

> Would not calling ff_dovi_ctx_unref() be safer here?

Good point, changed.

> This is only used for logging (as it should be), so you can make this
> void *logctx and drop the avcodec.h #include.

So, the reason I made this an avctx is because I'm anticipating the need
to check `avctx->err_recognition` if the CRC32 check ever gets
implemented. In theory we could also do some profile-based verification
in AV_EF_BITSTREAM / AV_EF_EXPLODE, to check if the coded RPU values
actually match the legal combinations restricted by the profile
specification.

Of course, given that this is just an internal API, I'm also fine making
it a logctx now and upgrading it to an avctx when the need arises.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".