From: Niklas Haas <ffmpeg@haasn.xyz>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Niklas Haas <git@haasn.dev>
Subject: Re: [FFmpeg-devel] [PATCH v5 4/6] lavc: Implement Dolby Vision RPU parsing
Date: Mon, 20 Dec 2021 15:47:45 +0100
Message-ID: <20211220154745.GB7072@xor.haasn.dev> (raw)
In-Reply-To: <163999519548.13029.13385878156195650068@lain.red.khirnov.net>
On Mon, 20 Dec 2021 11:13:15 +0100 Anton Khirnov <anton@khirnov.net> wrote:
> nit: FF_ARRAY_ELEMS(s->vdr_ref) is considered better
Done.
> Would not calling ff_dovi_ctx_unref() be safer here?
Good point, changed.
> This is only used for logging (as it should be), so you can make this
> void *logctx and drop the avcodec.h #include.
So, the reason I made this an avctx is because I'm anticipating the need
to check `avctx->err_recognition` if the CRC32 check ever gets
implemented. In theory we could also do some profile-based verification
in AV_EF_BITSTREAM / AV_EF_EXPLODE, to check if the coded RPU values
actually match the legal combinations restricted by the profile
specification.
Of course, given that this is just an internal API, I'm also fine making
it a logctx now and upgrading it to an avctx when the need arises.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2021-12-20 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211212115546.119662-1-ffmpeg@haasn.xyz>
[not found] ` <CA+anqdwT+O2B2859vqyT3Or92bYHGXEQp9NgaC0C4b3Pb6m1bw@mail.gmail.com>
2021-12-15 14:19 ` [FFmpeg-devel] [PATCH v5 1/6] lavu/frame: Add Dolby Vision metadata side data type Derek Buitenhuis
2021-12-18 18:34 ` Hendrik Leppkes
2021-12-20 9:53 ` Anton Khirnov
2021-12-20 10:02 ` Anton Khirnov
[not found] ` <20211212115546.119662-4-ffmpeg@haasn.xyz>
2021-12-20 10:13 ` [FFmpeg-devel] [PATCH v5 4/6] lavc: Implement Dolby Vision RPU parsing Anton Khirnov
2021-12-20 14:47 ` Niklas Haas [this message]
2021-12-20 14:55 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211220154745.GB7072@xor.haasn.dev \
--to=ffmpeg@haasn.xyz \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=git@haasn.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git