From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 31A01402FA for ; Mon, 20 Dec 2021 10:50:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1BD2868AE57; Mon, 20 Dec 2021 12:50:30 +0200 (EET) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ACD5768A82A for ; Mon, 20 Dec 2021 12:50:23 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id CC592E0011 for ; Mon, 20 Dec 2021 10:50:22 +0000 (UTC) Date: Mon, 20 Dec 2021 11:50:21 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20211220105021.GQ2829255@pb2> References: <20211217215155.19805-1-michael@niedermayer.cc> <20211217215155.19805-4-michael@niedermayer.cc> <163999391652.13029.15771139919327877252@lain.red.khirnov.net> MIME-Version: 1.0 In-Reply-To: <163999391652.13029.15771139919327877252@lain.red.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 4/4] avcodec/tiff: Use ff_set_dimensions() for setting up mjpeg context dimensions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6508800368515168605==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6508800368515168605== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nF6lW2s03UusWpFy" Content-Disposition: inline --nF6lW2s03UusWpFy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 20, 2021 at 10:51:56AM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-12-17 22:51:55) > > Fixes: OOM >=20 > This is very non-obvious and could use more explanation. I guess its obvious to me as ive seen this bug more than once the problem is that directly setting width/height leaves coded_w/h unset, then something sets coded_w/h and next time width/height is set again it is unrelated to the still set coded_w/h and theres a FFMAX() between coded_w and width so the image allocated is much bigger ff_set_dimension() breaks this chain by setting both width and coded_width=20 should i add this long explanation above to the commit message or something shorter like "sets coded_width / coded_height too to keep them consistent with width / height" =20 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "You are 36 times more likely to die in a bathtub than at the hands of a terrorist. Also, you are 2.5 times more likely to become a president and 2 times more likely to become an astronaut, than to die in a terrorist attack." -- Thoughty2 --nF6lW2s03UusWpFy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYcBf6QAKCRBhHseHBAsP q4DTAKCIC89tPuCXGvi36p62uwfmkaafngCgiiufuJ2vAn9FpaK7VJifY9SJdzo= =JhBh -----END PGP SIGNATURE----- --nF6lW2s03UusWpFy-- --===============6508800368515168605== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6508800368515168605==--