Re: [FFmpeg-devel] [PATCH 2/2] avformat/mvdec: Use 64 bit in timestamp computation

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/mvdec: Use 64 bit in timestamp computation
Date: Thu, 16 Dec 2021 21:03:36 +0100
Message-ID: <20211216200336.GA2829255@pb2> (raw)
In-Reply-To: <YbqHr2nr0RZp8EjR@301de4447f55623bb5f04e9d71fc65fe>

[-- Attachment #1.1: Type: text/plain, Size: 1579 bytes --]

On Thu, Dec 16, 2021 at 11:26:23AM +1100, Peter Ross wrote:
> On Wed, Dec 15, 2021 at 06:37:13PM +0100, Michael Niedermayer wrote:
> > Fixes: division by zero
> > Fixes: 42198/clusterfuzz-testcase-minimized-ffmpeg_dem_MV_fuzzer-5054366405492736.fuzz
> > Fixes: 42222/clusterfuzz-testcase-minimized-ffmpeg_dem_MV_fuzzer-4561249331970048
> > 
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavformat/mvdec.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavformat/mvdec.c b/libavformat/mvdec.c
> > index 8b54a9ab045..5d184f20a49 100644
> > --- a/libavformat/mvdec.c
> > +++ b/libavformat/mvdec.c
> > @@ -381,7 +381,7 @@ static int mv_read_header(AVFormatContext *avctx)
> >              avio_skip(pb, 8);
> >              av_add_index_entry(ast, pos, timestamp, asize, 0, AVINDEX_KEYFRAME);
> >              av_add_index_entry(vst, pos + asize, i, vsize, 0, AVINDEX_KEYFRAME);
> > -            timestamp += asize / (ast->codecpar->channels * bytes_per_sample);
> > +            timestamp += asize / (ast->codecpar->channels * (uint64_t)bytes_per_sample);
> >          }
> >      } else if (!version && avio_rb16(pb) == 3) {
> >          avio_skip(pb, 4);
> > -- 
> > 2.17.1
> 
> please apply.

will apply

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Never trust a computer, one day, it may think you are the virus. -- Compn

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".