Re: [FFmpeg-devel] [PATCH 17/24] ffmpeg: do not log to the muxer context

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1416 bytes --]

On Mon, Dec 13, 2021 at 04:20:35PM +0100, Anton Khirnov wrote:
> All other logging goes to NULL context.
> ---
>  fftools/ffmpeg.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
> index d69e4119ef..afd442ff4e 100644
> --- a/fftools/ffmpeg.c
> +++ b/fftools/ffmpeg.c
> @@ -2954,7 +2954,6 @@ static void init_encoder_time_base(OutputStream *ost, AVRational default_time_ba
>  {
>      InputStream *ist = get_input_stream(ost);
>      AVCodecContext *enc_ctx = ost->enc_ctx;
> -    AVFormatContext *oc;
>  
>      if (ost->enc_timebase.num > 0) {
>          enc_ctx->time_base = ost->enc_timebase;
> @@ -2967,8 +2966,7 @@ static void init_encoder_time_base(OutputStream *ost, AVRational default_time_ba
>              return;
>          }
>  
> -        oc = output_files[ost->file_index]->ctx;
> -        av_log(oc, AV_LOG_WARNING, "Input stream data not available, using default time base\n");
> +        av_log(NULL, AV_LOG_WARNING, "Input stream data not available, using default time base\n");
>      }

If this no longer shows the muxer then some information should be added so
the user knows to which part the warning belongs on a complex transcode

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".