From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 324B1421A3 for ; Thu, 16 Dec 2021 19:43:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7FB4F68AF50; Thu, 16 Dec 2021 21:43:50 +0200 (EET) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 961B8687F96 for ; Thu, 16 Dec 2021 21:43:43 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id AA693FF807 for ; Thu, 16 Dec 2021 19:43:42 +0000 (UTC) Date: Thu, 16 Dec 2021 20:43:41 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20211216194341.GY2829255@pb2> References: <20211213152042.5900-1-anton@khirnov.net> <20211213152042.5900-23-anton@khirnov.net> <20211214211343.GP2829255@pb2> <163959698589.13029.5805519215876153824@lain.red.khirnov.net> MIME-Version: 1.0 In-Reply-To: <163959698589.13029.5805519215876153824@lain.red.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 23/24] ffmpeg: simplify the use of OutputStream.frame_number X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8217406772002725061==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8217406772002725061== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HDtVcJo1Y4X10oke" Content-Disposition: inline --HDtVcJo1Y4X10oke Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 15, 2021 at 08:36:25PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-12-14 22:13:43) > > On Mon, Dec 13, 2021 at 04:20:41PM +0100, Anton Khirnov wrote: > > > It features in limiting the number of output frames (-frames option) = and > > > currently can be incremented from two places: > > > - for video encoding (not streamcopy), in do_video_out() after each > > > successful avcodec_send_frame() call > > > - for all other cases, in of_submit_packet() > > >=20 > > > Not only is this inconsistent and confusing, but also the special > > > treatment for video encoding is redundant, since > > > AVCodecContext.frame_count stores the exact same value (number of > > > successful avcodec_send_frame()) calls. > > >=20 > > > Replace the use of OutputStream.frame_count in do_video_out() with > > > AVCodecContext.frame_count. Modify OutputStream.frame_count in the sa= me > > > way for all streams. > > > --- > > > fftools/ffmpeg.c | 9 ++++----- > > > fftools/ffmpeg_mux.c | 19 +++++++------------ > > > 2 files changed, 11 insertions(+), 17 deletions(-) > >=20 > > This results in differences > > one is: > > ./ffmpeg -i ~/tickets/4072/CoP\ 1\ 1\ 3\ -M.avi -vframes 2 -bitexact -v= codec huffyuv /tmp/4072-fic-old.avi > >=20 > > -rw-r----- 1 michael michael 3572792 Dez 14 22:09 /tmp/4072-fic-new.avi > > -rw-r----- 1 michael michael 1908172 Dez 14 22:10 /tmp/4072-fic-old.avi > >=20 > > I see other differences caused by patches today i still need to investi= gate > > what causes what >=20 > Fixing this will require larger restructuring first, so I am dropping > this patch for now. >=20 > Please let me know if the rest of the set breaks anything else. all failures from this patch set where from this patch i think thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe me, but the highest form of Human Excellence is to question oneself and others. -- Socrates --HDtVcJo1Y4X10oke Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYbuW6gAKCRBhHseHBAsP qynpAJ9pDiPK71IKQVr/KqPwbDQR9y/WXwCeKVuq3h0QjaC2rwUZlsfV8vXZdxQ= =NnTW -----END PGP SIGNATURE----- --HDtVcJo1Y4X10oke-- --===============8217406772002725061== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8217406772002725061==--