From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 77E80422A7 for ; Fri, 17 Dec 2021 03:39:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 372FA68AE6B; Fri, 17 Dec 2021 05:39:55 +0200 (EET) Received: from mail.overt.org (mail.overt.org [157.230.92.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3B6E968018F for ; Fri, 17 Dec 2021 05:39:49 +0200 (EET) Received: from authenticated-user (mail.overt.org [157.230.92.47]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.overt.org (Postfix) with ESMTPSA id F1ACD401B9 for ; Thu, 16 Dec 2021 21:39:47 -0600 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=overt.org; s=mail; t=1639712388; bh=FuMXslB8QDJ6Wmr5ME9ra2CNYezDVNulj2a4D2bnsPY=; h=Date:From:To:Subject:In-Reply-To:References:From; b=p0m08anXpL0SrV8XLR1mS40Hc2rryIQ8DXac5VKB273luofrFOuM4Abj4H+LMQdlL ZEiZlENONE6IF/Dlg4/j6gYMs3AlrcyqL915SULzzS8oRGGO4LV3C/g5cdojYLRuUd ZS2TKWKK6rBOP2ZshW7+OE9C4oDC2CpC1uA4QlqmiqxMbs80ftsSsmY1O7x6xLZsqJ OrkhqZc6qo/SeDCSwcY5sdJA0+GGqgEHAE3X68t0RQIADpE7GmbBkzD34eAC7rCFhD 9R9dt4gvasXwFGcHwmAguDD5LVZE29pLUpVMA3L0iqH8pwxzfY6L0PqI7QaDQSUyaS 9/eAsJIJpeLeg== Date: Thu, 16 Dec 2021 19:39:45 -0800 From: Philip Langdale To: ffmpeg-devel@ffmpeg.org Message-ID: <20211216193945.5cd53551@fido6> In-Reply-To: <20211216202858.77643-5-ffmpeg@tmm1.net> References: <20211216202858.77643-1-ffmpeg@tmm1.net> <20211216202858.77643-5-ffmpeg@tmm1.net> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v3 5/5] avfilter: add vf_deinterlace_videotoolbox X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 16 Dec 2021 12:28:58 -0800 Aman Karmani wrote: > From: Aman Karmani > > deinterlaces CVPixelBuffers, i.e. AV_PIX_FMT_VIDEOTOOLBOX frames > > currently implements YADIF, but other algorithms could easily > be added to the same filter. > > for example, an interlaced mpeg2 file can be decoded by avcodec, > uploaded into a CVPixelBuffer, deinterlaced by metal, and then > encoded to h264 by VideoToolbox as follows: > > ffmpeg \ > -init_hw_device videotoolbox \ > -i interlaced.ts \ > -vf > hwupload,deinterlace_videotoolbox=mode=send_field:deint=interlaced \ > -c:v h264_videotoolbox \ -b:v 2000k \ > -c:a copy \ > -y progressive.ts > > (note that uploading AVFrame into CVPixelBuffer via hwupload > requires 504c60660d3194758823ddd45ceddb86e35d806f) > > Signed-off-by: Aman Karmani Ignoring my lack of familiarity with the Apple specific parts, this looks reasonable, although I have the same question that Paul had about naming. I know that you're thinking that future metal accelerated algorithms could go in this filter, but the precedent in the codebase is that each algorithm is a separate filter, and so if you ever wanted to add a second one down the line, we'd be expecting it to be separate anyway. --phil _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".