From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4411F41A20 for ; Wed, 15 Dec 2021 15:15:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BF61C68B073; Wed, 15 Dec 2021 17:15:45 +0200 (EET) Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [217.70.178.232]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A360868B02F for ; Wed, 15 Dec 2021 17:15:38 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by relay12.mail.gandi.net (Postfix) with ESMTPSA id E4E6D200002 for ; Wed, 15 Dec 2021 15:15:37 +0000 (UTC) Date: Wed, 15 Dec 2021 16:15:35 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20211215151535.GV2829255@pb2> References: <20211125171932.GC2829255@pb2> <20211213152557.GL2829255@pb2> <20211214161924.GM2829255@pb2> <20211215145235.GU2829255@pb2> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] 5.0 release X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4087055526014721157==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4087055526014721157== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XlaMG/CiWVt3LUks" Content-Disposition: inline --XlaMG/CiWVt3LUks Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 15, 2021 at 04:08:43PM +0100, Diederick C. Niehorster wrote: > Hi Michael, >=20 > On Wed, Dec 15, 2021 at 3:52 PM Michael Niedermayer > wrote: > > > > On Tue, Dec 14, 2021 at 05:42:01PM +0100, Diederick C. Niehorster wrote: > > > Hi Michael, > > > > > > On Tue, Dec 14, 2021 at 5:19 PM Michael Niedermayer > > > wrote: > > > > > > > > > > > > The patches do not say in their commit messages that they have been= reviewed > > > > maybe you want to repost them with that changed. > > > > > > Thanks for having a look! > > > I have mentioned this here: > > > https://ffmpeg.org/pipermail/ffmpeg-devel/2021-December/289461.html > > > > > > Or do you mean that for each specific patch, if there were previous > > > review comments, i should mention that it was updated in response to > > > the review? For some that may be hard (e.g. i was asked to change the > > > order of some commits). > > > > Patches which where approved already and not changed since then could > > contain that information in the commit message. We tend to use some > > Reviewed-by: ... > > for that > > that may speed up future review and commit > > > > I dont know dshow and dont have a proper setup to test it so i wont be > > applying or reviewing these patches >=20 > Ah, i see. I have made changes here in response to other review > comment since i got that LGTM for the series. I'll contact the dshow > maintainer again for that (I assume he would be the only one who > should be committing my patchset?). anyone with commit rights could apply after a review by someone who knows the code. Of course could !=3D will thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Avoid a single point of failure, be that a person or equipment. --XlaMG/CiWVt3LUks Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYboGkgAKCRBhHseHBAsP q4nUAJ4usyNHjKcevFuN24wOxuQK3Nd/pACfe60dxPI8XtcoHa67OM0Yx8HCITo= =pxAz -----END PGP SIGNATURE----- --XlaMG/CiWVt3LUks-- --===============4087055526014721157== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4087055526014721157==--