From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 758F141D28 for ; Wed, 15 Dec 2021 14:52:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B4D9968B090; Wed, 15 Dec 2021 16:52:44 +0200 (EET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A098C68B15B for ; Wed, 15 Dec 2021 16:52:37 +0200 (EET) Received: from localhost (213-47-68-29.cable.dynamic.surfer.at [213.47.68.29]) (Authenticated sender: michael@niedermayer.cc) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id E89566000C for ; Wed, 15 Dec 2021 14:52:36 +0000 (UTC) Date: Wed, 15 Dec 2021 15:52:35 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20211215145235.GU2829255@pb2> References: <20211125171932.GC2829255@pb2> <20211213152557.GL2829255@pb2> <20211214161924.GM2829255@pb2> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] 5.0 release X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0056406498952037718==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0056406498952037718== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DzKDwAC8m/33A2me" Content-Disposition: inline --DzKDwAC8m/33A2me Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 14, 2021 at 05:42:01PM +0100, Diederick C. Niehorster wrote: > Hi Michael, >=20 > On Tue, Dec 14, 2021 at 5:19 PM Michael Niedermayer > wrote: > > > > On Mon, Dec 13, 2021 at 10:27:33PM +0100, Diederick C. Niehorster wrote: > > > Hi Michael, > > > > > > On Mon, Dec 13, 2021 at 4:26 PM Michael Niedermayer > > > wrote: > > > > > > > > If you know of any major issues which need to be done before the re= lease do them > > > > now. If you know of any issues which are release-blocking list them= in a reply > > > > here please. > > > > > > Not major, but https://ffmpeg.org/pipermail/ffmpeg-devel/2021-Decembe= r/289462.html > > > fixes a crashing bug. I'd of course love for the whole series to be > > > pushed in time for release (its been reviewed multiple times and > > > LGTMed offlist by the dshow maintainer), but we'll see :). > > > > The patches do not say in their commit messages that they have been rev= iewed > > maybe you want to repost them with that changed. >=20 > Thanks for having a look! > I have mentioned this here: > https://ffmpeg.org/pipermail/ffmpeg-devel/2021-December/289461.html >=20 > Or do you mean that for each specific patch, if there were previous > review comments, i should mention that it was updated in response to > the review? For some that may be hard (e.g. i was asked to change the > order of some commits). Patches which where approved already and not changed since then could contain that information in the commit message. We tend to use some Reviewed-by: ... for that that may speed up future review and commit I dont know dshow and dont have a proper setup to test it so i wont be applying or reviewing these patches thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB While the State exists there can be no freedom; when there is freedom there will be no State. -- Vladimir Lenin --DzKDwAC8m/33A2me Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYboBMAAKCRBhHseHBAsP q5cAAJ4mJzQsQhRCwiBKAkV+IeH95N3s1ACfU07rpxPSa8CeS9reFfMb5ggRPf4= =wFKC -----END PGP SIGNATURE----- --DzKDwAC8m/33A2me-- --===============0056406498952037718== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0056406498952037718==--