From: Thilo Borgmann via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Thilo Borgmann <thilo.borgmann@mail.de>
Subject: Re: [FFmpeg-devel] [PATCH v11 4/8] libavcodec/webp: add support for animated WebP
Date: Wed, 17 Apr 2024 12:27:30 -0700
Message-ID: <2003e643-b412-4587-ab83-588fd11a83da@mail.de> (raw)
In-Reply-To: <CABWgkXKWi9nGXHNtwss1A41x2toQv8giQOrkbsPqNoK1x_6j3g@mail.gmail.com>
On 17.04.24 19:30, James Zern via ffmpeg-devel wrote:
> On Thu, Mar 28, 2024 at 7:10 AM Thilo Borgmann via ffmpeg-devel
> <ffmpeg-devel@ffmpeg.org> wrote:
>>
>> From: Josef Zlomek <josef@pex.com>
>>
>> Fixes: 4907
>>
>> Adds support for decoding of animated WebP.
>>
>> The WebP decoder adds the animation related features according to the specs:
>> https://developers.google.com/speed/webp/docs/riff_container#animation
>> The frames of the animation may be smaller than the image canvas.
>> Therefore, the frame is decoded to a temporary frame,
>> then it is blended into the canvas, the canvas is copied to the output frame,
>> and finally the frame is disposed from the canvas.
>>
>> The output to AV_PIX_FMT_YUVA420P/AV_PIX_FMT_YUV420P is still supported.
>> The background color is specified only as BGRA in the WebP file
>> so it is converted to YUVA if YUV formats are output.
>>
>> Signed-off-by: Josef Zlomek <josef@pex.com>
>> ---
>> Changelog | 1 +
>> libavcodec/codec_desc.c | 3 +-
>> libavcodec/version.h | 2 +-
>> libavcodec/webp.c | 710 ++++++++++++++++++++++++++++++++++++----
>> 4 files changed, 653 insertions(+), 63 deletions(-)
>>
>
> I'm late trying to test these. I think these need to be rebased.
> version.h is easy enough to skip. I didn't look at the conflict in
> webp.c.
>
> error: patch failed: libavcodec/version.h:30
> error: libavcodec/version.h: patch does not apply
> error: patch failed: libavcodec/webp.c:35
> error: libavcodec/webp.c: patch does not apply
> Patch failed at 0004 libavcodec/webp: add support for animated WebP
just posted v12 which applies to master again, also tagged it WIP.
Thanks for having a look,
Thilo
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-04-17 19:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 14:08 [FFmpeg-devel] [PATCH v11 0/8] webp: add support for animated WebP decoding Thilo Borgmann via ffmpeg-devel
2024-03-28 14:08 ` [FFmpeg-devel] [PATCH v11 1/8] avcodec/webp: remove unused definitions Thilo Borgmann via ffmpeg-devel
2024-03-28 14:08 ` [FFmpeg-devel] [PATCH v11 2/8] avcodec/webp: separate VP8 decoding Thilo Borgmann via ffmpeg-devel
2024-03-28 14:08 ` [FFmpeg-devel] [PATCH v11 3/8] avcodec/bsf: Add awebp2webp bitstream filter Thilo Borgmann via ffmpeg-devel
2024-03-28 18:11 ` Stefano Sabatini
2024-03-29 10:41 ` Thilo Borgmann via ffmpeg-devel
2024-03-29 13:39 ` Andreas Rheinhardt
2024-03-28 14:08 ` [FFmpeg-devel] [PATCH v11 4/8] libavcodec/webp: add support for animated WebP Thilo Borgmann via ffmpeg-devel
2024-04-17 17:30 ` James Zern via ffmpeg-devel
2024-04-17 19:27 ` Thilo Borgmann via ffmpeg-devel [this message]
2024-03-28 14:08 ` [FFmpeg-devel] [PATCH v11 5/8] avcodec/webp: make init_canvas_frame static Thilo Borgmann via ffmpeg-devel
2024-03-28 14:08 ` [FFmpeg-devel] [PATCH v11 6/8] libavformat/webp: add WebP demuxer Thilo Borgmann via ffmpeg-devel
2024-03-28 14:08 ` [FFmpeg-devel] [PATCH v11 7/8] fate: add test for animated WebP Thilo Borgmann via ffmpeg-devel
2024-03-28 14:08 ` [FFmpeg-devel] [PATCH v11 8/8] avcodec/webp: export XMP metadata Thilo Borgmann via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2003e643-b412-4587-ab83-588fd11a83da@mail.de \
--to=ffmpeg-devel@ffmpeg.org \
--cc=thilo.borgmann@mail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git