From: "Rémi Denis-Courmont" <remi@remlab.net>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] lavc/h264chroma: RISC-V V add motion compensation for 4xH and 2xH chroma blocks
Date: Thu, 15 Jun 2023 21:48:02 +0300
Message-ID: <2002273.tVNk98kh28@basile.remlab.net> (raw)
In-Reply-To: <CAPUBFYFh_C9k429akSpXiwCmhc096wFA0qKf3Ct2zSp6HBLERA@mail.gmail.com>
Le torstaina 15. kesäkuuta 2023, 17.58.37 EEST Arnie Chang a écrit :
> Since these functions are frequently called, I prefer instantiating similar
> code many times
> rather than calling another internal function, as it may introduce
> additional function call overhead.
This works both ways. Smaller code reduces IC overhead and the risk of its own
eviction or that of some other frequently used code.
Here, we would just add one `li` to the 8x cases, and a pair of `li` and `j`
to the 2x and 4x cases (like we already do for Opus postfilter). Indeed, since
this is assembler, we can enforce tail-call optimisation.
Since this is assembler, you can count on tail-call optimisation. This is
really just one `li` and `j` added on the 2 and 4.
Not that I could measure the actual impact of either approaches.
--
Rémi Denis-Courmont
http://www.remlab.net/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-06-15 18:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 7:17 Arnie Chang
2023-06-10 14:55 ` Lynne
2023-06-10 16:43 ` Arnie Chang
2023-06-12 14:59 ` Rémi Denis-Courmont
2023-06-12 15:28 ` Arnie Chang
2023-06-12 15:29 ` Rémi Denis-Courmont
2023-06-14 15:57 ` Rémi Denis-Courmont
2023-06-15 14:58 ` Arnie Chang
2023-06-15 18:48 ` Rémi Denis-Courmont [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2002273.tVNk98kh28@basile.remlab.net \
--to=remi@remlab.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git