From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DE1004342A for ; Fri, 10 Jun 2022 03:36:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5F54168B898; Fri, 10 Jun 2022 06:36:17 +0300 (EEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 90AAD68B5E1 for ; Fri, 10 Jun 2022 06:36:08 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654832175; x=1686368175; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=PnDm7SHBk8KP2Gkz0tm55z3JwI6VbX5c2cKglfVnSws=; b=LFg0RqjAVfHClzR3s0ey6HNgIwXvTgEBz6bPRxDQ7xINLET3tO/n6dEV zgEPIBlc4elCHQ/qP0NJt588YuOhVJBdyG2DED8Ymvh4oElYv0ioaYJX9 Vw/dol7xvyLUal2nIDajRnhuwkG2BQ6+Jgkkrr88nNj/B9e0FiE6XYGOm VujS8mtZLDwqbNNU0eWKofy5x6pIMh6LDYyNUCHO+9p5mTSnd+DD4yZBy N6J4kP7nvnX2CUQk85PoSJG3r2Bgx+E3z1ZE35TvMq6yHwNdHBM5m3RnM IwUwE1i/YCW0DkO5H3HIJbhI13k8KEege+idFjIQsqxPJlKdmDkvAoOYj w==; X-IronPort-AV: E=McAfee;i="6400,9594,10373"; a="339253810" X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="339253810" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2022 20:36:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="585972200" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga007.fm.intel.com with ESMTP; 09 Jun 2022 20:36:04 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 9 Jun 2022 20:36:04 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 9 Jun 2022 20:36:03 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 9 Jun 2022 20:36:03 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 9 Jun 2022 20:36:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D7T+4X4AkCapyLCIMX3IW7l8oj686efaBUObocIIW22QZsgdlRp7z1qJS3AA1/xC5XSNqFwPq3Y8JIUSItn3UYc+JYr4ziG+x8Brt4RV4DpDb3q9k55eo5mWNAQg8FMhAO92nRrXlALfzhhvzSCPyjJNUC7BGH3gK6QS3vlkjd2GZWrsCGuKnWKmXiEjYc4nEQAIRzNkE8/n8xUjEv+j5Xyzo6Cbbdn+D6JPkh3IrBJ+JgGlIINkNKSCQk+TxgSFRAUb3DIOwO4XPyKvO0YWnInjeE3VAG2JaDRsQL4aXPI+EoMPGhLvo/xW+9QxsyZU1S2gWGkzYLl9ttPE1xiBQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PnDm7SHBk8KP2Gkz0tm55z3JwI6VbX5c2cKglfVnSws=; b=ZYDXF1FBBkHh4NlBR7zsJet9QOUyN08v2eD9DVPQ0P/+aJC1tPTfYTZUtwDTd1haohq9Yy3O7R2xKQXjya4i7i2Z0ubKGH3wxTFAKatfhvUOSmegArN39QOwfS+cmmtBHV8yoGC1Q15hfQoDodL+yG6hS3B+5OUw13DtujdpM8Ke1uIZ3xY4VJxSY1WjjypM+hlcdQD9qbwGlNH+jHyayu74MXMCPfh4NFdaHDpMpJR8wYzM4AX2IVGL9ZNd/a7D7fehCEsdZSRxcUpWZntdFPzoyQhTFtQlWSv7fYQMGT+QIljVZ9UMaar2BLGHhEJmbvV3NlHIhSLiODZj0RunDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by DM6PR11MB3468.namprd11.prod.outlook.com (2603:10b6:5:5c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.17; Fri, 10 Jun 2022 03:36:02 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::65d2:4e26:5290:7b5f]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::65d2:4e26:5290:7b5f%5]) with mapi id 15.20.5332.014; Fri, 10 Jun 2022 03:36:01 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v4] libavcodec/qsvenc: add ROI support to qsv encoder Thread-Index: AQHYevUgoQIXllI1lkyP527GJvVjw61IAH0A Date: Fri, 10 Jun 2022 03:36:01 +0000 Message-ID: <1fc0138907a07fa6acbf675574a32146235d2496.camel@intel.com> References: <20220608050248.3669348-1-wenbin.chen@intel.com> In-Reply-To: <20220608050248.3669348-1-wenbin.chen@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 86fe80b9-bab7-478e-4bf2-08da4a925765 x-ms-traffictypediagnostic: DM6PR11MB3468:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KHLwWAbcj68bucTbYoXxrS+XZ5qhK1irb3v8NhCvnkORjeugwfbGZQrkzb+OwKi+EVAJgkqZcI0Lyzdm4E4hOWHpRW8OYTWMM4QKbN38D/0lbc9tr3sDUKUwVWO5xpGVpqzzyEB0xYOun4T5rITSlK0HIZlmvyeiDix2wcgoxrWahjPiimjWHvYlhg5V2Rsw6uOMoWLaUGAY8bggKAcWbV8xqiesUjGOl/v+1Q0ky058kxt4FC10CLWprgSXtCxNGcNKk2OOWc2xAwkd8YOnpCgewub/jRKrag0vtBe8Uihz/jRDbW+oDZvpLoJFHiBGSmIRqbQrbUkQgeF9d4Mmp2ZKR9/VlVL2UEmQy7Q7S/g/uUskSa23TAoAO4Ak7ZKIHa02pcJHiM12w4ArJRn4Eu3jpXwmojlDISn+QLOy4ke7V23AyZEM/CpNTg47/Csr66wBVLqf8Z7IcoJEi522hXcnVvKw2kyNFB0XUXSLB3Ctt4V5cstX72ZtS0hbAFXJ346rw/jGBsAn/TLnWPneNVGsRUuYh/hXV7oM7mVjAen5VFxWScc5b/h4ahf/Y/6RCXbyfWNJhyHVAaiOcsAB6yQ3fdefSvyDXzPaFZrET+5T1nHXPvhGR13K187RBZP5b4TiZIe4u+1Q6pSDLScbZH5FBHCdyaQ4BRpHIgv4HEUSpcZDsgqWwkcwlBQs071aEDUZt2kSvYuoggEpVzu9MgcXnYCYxzVPODvDoRjIR70= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38100700002)(186003)(91956017)(8936002)(5660300002)(6916009)(38070700005)(64756008)(66946007)(83380400001)(66476007)(66446008)(8676002)(66556008)(76116006)(508600001)(71200400001)(6486002)(6512007)(6506007)(86362001)(36756003)(2616005)(82960400001)(122000001)(26005)(2906002)(316002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eUV2N0FiT3lEYW9MWEo4b3BIOXMzdFpkVlVRbjNkWEZSdU8vWFQ4ZW1RRnJL?= =?utf-8?B?a040bmNEVGxCMSt5cmdBNjk1Wlp6K201VjRLb0ZpeW04Z1dnRENyTTVEZWg4?= =?utf-8?B?VWhUNlZJaG1ZVXpNZWkxVlhOQlNEMCtXTEVKaTNnbEQ4Q2U1eFZ0WXBTT210?= =?utf-8?B?TzlVdGpWbGc4YUhBRUdXbTRKK2luOWtMekRZWGxCdEZ6SDdqaDZqVUszR0Zw?= =?utf-8?B?UUlTTmNJS3dYeTIrT0thTmMvYSthMDl1cFRmb3VpU2JYVERGOUFNdDgzRkE3?= =?utf-8?B?VGNXeUZSeUdYeFZGc255Vk5SeWM5WHY2eElHMi9Va0F0Rmg2MDhmMi9XNGlq?= =?utf-8?B?dFJXcFc2VjdXTG1CWmE3b29sbTluNEtvTDVHa01hNFYzeVo2LzMxUW5FNkRp?= =?utf-8?B?aFpJUWhma2RmY1M5YlFkd3ZnVGs3V1lydmRCTG4wbGh0ZFF4MDE5RGRBK25z?= =?utf-8?B?TWdhUGwxaGZ0Y00xOVJROFhvU3VneUpsY1ZzVG5sd3NlNWoxRW95QWJUYmtt?= =?utf-8?B?TzBhYnBTYjhwT0RPK2JSa2pCSngyc0pjQUlaemQ3aWFSK1R1a1NRUXRvY0hV?= =?utf-8?B?bUFvenRBbDIyOEJ0U2pwREVXV0ZteXFvcXp0WjlDNVpyNjh5WU5TL1ZVOHl4?= =?utf-8?B?djMxWlpDTUFTbTZxalA4VkpDOVFkUnZVK25GNHZNZy9LWXV0SUc0VjFBQll2?= =?utf-8?B?SFBBNXlEVzhmTHZSQzdlWHdJMHZwWjRUMXc1TUZPRzF4M2NCemNmVjlweDBq?= =?utf-8?B?bm0wS2h4S0hhQzViTVJYdFI3Z2tVY2xrcmZhOGJHSGtLRFpWWks2VVl2OXFu?= =?utf-8?B?MGIybks3S0VaeTVMMXRnb3BQQXQxMUNab05ORGtRZm5OQWxJalN4WFVMOTZC?= =?utf-8?B?WlhLc0JZWXdWRC9tQjY4Wm1YTUxwQXRVNWl0UkZwQkVyc3RwQXNzWnNjMloy?= =?utf-8?B?TVlocElGTDdvaWdnOGZWcGpqTTlyMktkMlErT0N5clBMWlFjOHJIa3VOamJx?= =?utf-8?B?SGdRNWM4eWNiSWtMeVovcnR5TE83OFhsaHVzSjNUdExEVklWQzY4dXZJV2tY?= =?utf-8?B?akd0aU9yaW9YSEdoc05QUVBvczc5UHhzY1lxcVVkV3FsL3oxdEszU21RS0I5?= =?utf-8?B?blVRdHl1YzdGUkIrMFltT2QyS0p5WUxrc1NSVmtkVGJZYmVtWWxOdmJ2cWg4?= =?utf-8?B?cFJoSE82RkcxNCtpLzVFUGFBWmpOOHFuRHpYKzR2cHlldVFWeUNhci9RcHJ1?= =?utf-8?B?TU5wdDB0WkhhbGhDeDE1RkxyTHlhZnVlbWNUVUFFK04yN0ZHanVIc05NQkpH?= =?utf-8?B?QndvdUdvcDJkU1RIbGM0OVJ4cmI3ZHZlQzBzMDNUL3hTVUNoZFM5OUVEck1r?= =?utf-8?B?bDdObll1S1RnTndwdUMvQndtTGRzYXRkUnYraCt0QnB5ZEVvd2IrcWlaVzAw?= =?utf-8?B?MGpKcVAxV2dxLzlSUGRFWWRXZzgyZTNJbllzU3hvb1lWZVc2NDVNdFJ5MTV6?= =?utf-8?B?Q3JpUDRCQ01iMXFlSC9xZTJKMnJ4ck02bUlKWlp1WUxWa3NSekVnT2U1MVFI?= =?utf-8?B?emZtenBHeEV5aXpRbHl4RmIrZ1luUTVRdnFhbURvdHprUDREd3NZK2NJRCtU?= =?utf-8?B?SThTZSs5VllqUTh2a0ttRkI4NlpQWXVRckJ1c3VKSFRFVkNHMXBBR29UZzlJ?= =?utf-8?B?SEQvSGZ4UVBiL3Q5cUM2dnpzTEo5dSs2OVFWRG14ejFyN1d2S0lFZFl5amd5?= =?utf-8?B?dndQdkhNY2JLSlRqNTBmdWpIekkwRDZhVnF3K05nbElDUDF2RkNBZnlkVnFU?= =?utf-8?B?Y3Z0THBPZ3VmeFZ6VU90dzkrK1R6NmdxRHlrYzJUcnNRWW9EMi9iQjh3K0Rw?= =?utf-8?B?clQxSlk3KzlNS0IxaEVubVBrSkJ6S3owanJQYW9naTVKMm1Ga2ZuRnhxQVNC?= =?utf-8?B?dTV6czNSaUpKL0VEbjF3SHR5RnRsZC9teFlUR3IyejgxeEhHV2ZZRUg1SGU2?= =?utf-8?B?R1hINFhyZ1ozN2JoNy9VdTZYQ0Y2Z3RMSFZmTWZtWW1BdmpHNC9VVTZvbm5j?= =?utf-8?B?K2o2am5WTFFLVCtXeTlBS1ZwY09STzdtRUQ5V2ZLc0YxN1RLeS85T25NNDF1?= =?utf-8?B?VHJYMWJQWWZWbmRYbzU3dndOVWJyK0Zkb0Q3OWNGSnJGVHBIK3dseXdrekRZ?= =?utf-8?B?M2JEdHNMTGpSZDkvOVFqeGxUTHJXVzFmdU5tYXgrZC9nTVJFY3VhTThFSGEz?= =?utf-8?B?cW1XSnBueUVncE9UWmxpL3Jnb1RxVGVwejErWnNMb1NFZ2pKUVU3bSt3a0lL?= =?utf-8?B?YVhKRWRFUnBPSG13RSt4MEo3WHdaWUgvdGMwb2QxWUYxSEVmajdRcHk1WTlY?= =?utf-8?Q?lAss++HVh5Csog+Q=3D?= Content-ID: <5239565AF7D16E4D95C9E8225D708834@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86fe80b9-bab7-478e-4bf2-08da4a925765 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2022 03:36:01.7658 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dDszMa9wgatVmL8tp4awf+5LIGDPTeXkNSq/3jd/+JhgsvZhxi7nv5KBdzF0y73hkp82ai6ne8bUNqMls8FBJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3468 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v4] libavcodec/qsvenc: add ROI support to qsv encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 2022-06-08 at 13:02 +0800, Wenbin Chen wrote: > Use The mfxEncoderCtrl parameter to enable ROI. Get side data > "AVRegionOfInterest" and use it to configure "mfxExtEncoderROI" which is > the MediaSDK's ROI configuration. > > Signed-off-by: Wenbin Chen > --- > libavcodec/qsv_internal.h | 4 ++ > libavcodec/qsvenc.c | 85 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 89 insertions(+) > > diff --git a/libavcodec/qsv_internal.h b/libavcodec/qsv_internal.h > index e2aecdcbd6..8131acdae9 100644 > --- a/libavcodec/qsv_internal.h > +++ b/libavcodec/qsv_internal.h > @@ -51,6 +51,9 @@ > #define ASYNC_DEPTH_DEFAULT 4 // internal parallelism > > #define QSV_MAX_ENC_PAYLOAD 2 // # of mfxEncodeCtrl payloads supported > +#define QSV_MAX_ENC_EXTPARAM 2 > + > +#define QSV_MAX_ROI_NUM 256 > > #define QSV_MAX_FRAME_EXT_PARAMS 4 > > @@ -83,6 +86,7 @@ typedef struct QSVFrame { > int num_ext_params; > > mfxPayload *payloads[QSV_MAX_ENC_PAYLOAD]; ///< used for enc_ctrl.Payload > + mfxExtBuffer *extparam[QSV_MAX_ENC_EXTPARAM]; ///< used for > enc_ctrl.ExtParam > > int queued; > int used; > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > index 03e9e5523d..902bada55b 100644 > --- a/libavcodec/qsvenc.c > +++ b/libavcodec/qsvenc.c > @@ -1390,15 +1390,29 @@ static void free_encoder_ctrl_payloads(mfxEncodeCtrl* > enc_ctrl) > } > } > > +static void free_encoder_ctrl_extparam(mfxEncodeCtrl* enc_ctrl) > +{ > + if (enc_ctrl) { > + int i; > + for (i = 0; i < enc_ctrl->NumExtParam && i < QSV_MAX_ENC_EXTPARAM; > i++) { > + if (enc_ctrl->ExtParam[i]) > + av_freep(&(enc_ctrl->ExtParam[i])); > + } > + enc_ctrl->NumExtParam = 0; > + } > +} > + > static void clear_unused_frames(QSVEncContext *q) > { > QSVFrame *cur = q->work_frames; > while (cur) { > if (cur->used && !cur->surface.Data.Locked) { > free_encoder_ctrl_payloads(&cur->enc_ctrl); > + free_encoder_ctrl_extparam(&cur->enc_ctrl); > //do not reuse enc_ctrl from previous frame > memset(&cur->enc_ctrl, 0, sizeof(cur->enc_ctrl)); > cur->enc_ctrl.Payload = cur->payloads; > + cur->enc_ctrl.ExtParam = cur->extparam; > if (cur->frame->format == AV_PIX_FMT_QSV) { > av_frame_unref(cur->frame); > } > @@ -1436,6 +1450,7 @@ static int get_free_frame(QSVEncContext *q, QSVFrame > **f) > return AVERROR(ENOMEM); > } > frame->enc_ctrl.Payload = frame->payloads; > + frame->enc_ctrl.ExtParam = frame->extparam; > *last = frame; > > *f = frame; > @@ -1537,6 +1552,67 @@ static void print_interlace_msg(AVCodecContext *avctx, > QSVEncContext *q) > } > } > > +static int set_roi_encode_ctrl(AVCodecContext *avctx, const AVFrame *frame, > + mfxEncodeCtrl *enc_ctrl) > +{ > + AVFrameSideData *sd = NULL; > + int mb_size; > + > + if (avctx->codec_id == AV_CODEC_ID_H264) > + mb_size = 16; > + else if (avctx->codec_id == AV_CODEC_ID_H265) > + mb_size = 32; > + else > + return 0; > + > + if (frame) > + sd = av_frame_get_side_data(frame, > AV_FRAME_DATA_REGIONS_OF_INTEREST); > + > + if (sd) { > + mfxExtEncoderROI *enc_roi = NULL; > + AVRegionOfInterest *roi; > + uint32_t roi_size; > + int nb_roi, i; > + > + roi = (AVRegionOfInterest *)sd->data; > + roi_size = roi->self_size; > + if (!roi_size || sd->size % roi_size) { > + av_log(avctx, AV_LOG_ERROR, "Invalid ROI Data.\n"); > + return AVERROR(EINVAL); > + } > + nb_roi = sd->size / roi_size; > + if (nb_roi > QSV_MAX_ROI_NUM) { > + av_log(avctx, AV_LOG_WARNING, "More ROIs set than " > + "supported by driver (%d > %d).\n", > + nb_roi, QSV_MAX_ROI_NUM); > + nb_roi = QSV_MAX_ROI_NUM; > + } > + > + enc_roi = av_mallocz(sizeof(*enc_roi)); > + if (!enc_roi) > + return AVERROR(ENOMEM); > + enc_roi->Header.BufferId = MFX_EXTBUFF_ENCODER_ROI; > + enc_roi->Header.BufferSz = sizeof(*enc_roi); > + enc_roi->NumROI = nb_roi; > + enc_roi->ROIMode = MFX_ROI_MODE_QP_DELTA; > + for (i = 0; i < nb_roi; i++) { > + roi = (AVRegionOfInterest *)(sd->data + roi_size * i); > + enc_roi->ROI[i].Top = FFALIGN(roi->top, mb_size); > + enc_roi->ROI[i].Bottom = FFALIGN(roi->bottom, mb_size); > + enc_roi->ROI[i].Left = FFALIGN(roi->left, mb_size); > + enc_roi->ROI[i].Right = FFALIGN(roi->right, mb_size); > + enc_roi->ROI[i].DeltaQP = > + roi->qoffset.num * 51 / roi->qoffset.den; > + av_log(avctx, AV_LOG_DEBUG, "ROI: (%d,%d)-(%d,%d) -> %+d.\n", > + roi->top, roi->left, roi->bottom, roi->right, > + enc_roi->ROI[i].DeltaQP); > + } > + enc_ctrl->ExtParam[enc_ctrl->NumExtParam] = (mfxExtBuffer *)enc_roi; > + enc_ctrl->NumExtParam++; > + } > + return 0; > +} > + > static int encode_frame(AVCodecContext *avctx, QSVEncContext *q, > const AVFrame *frame) > { > @@ -1599,6 +1675,14 @@ static int encode_frame(AVCodecContext *avctx, > QSVEncContext *q, > q->set_encode_ctrl_cb(avctx, frame, &qsv_frame->enc_ctrl); > } > > + if ((avctx->codec_id == AV_CODEC_ID_H264 || > + avctx->codec_id == AV_CODEC_ID_H265) && > + enc_ctrl && QSV_RUNTIME_VERSION_ATLEAST(q->ver, 1, 8)) { > + ret = set_roi_encode_ctrl(avctx, frame, enc_ctrl); > + if (ret < 0) > + goto free; > + } > + > pkt.sync = av_mallocz(sizeof(*pkt.sync)); > if (!pkt.sync) > goto nomem; > @@ -1721,6 +1805,7 @@ int ff_qsv_enc_close(AVCodecContext *avctx, > QSVEncContext *q) > while (cur) { > q->work_frames = cur->next; > av_frame_free(&cur->frame); > + free_encoder_ctrl_extparam(&cur->enc_ctrl); > free_encoder_ctrl_payloads(&cur->enc_ctrl); > av_freep(&cur); > cur = q->work_frames; LGTM, will aplly -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".