From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2755C44E32 for ; Tue, 27 Dec 2022 12:57:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6042368B9F3; Tue, 27 Dec 2022 14:57:18 +0200 (EET) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0834368B2C8 for ; Tue, 27 Dec 2022 14:57:12 +0200 (EET) Received: by mail-wr1-f48.google.com with SMTP id a17so12299311wrt.11 for ; Tue, 27 Dec 2022 04:57:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:reply-to:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QHEIpO0dxXtHTDobS2FJbnWSGt7Ye5sk9U+qkhC4Fko=; b=kbpdlYcTcpFPht50tvp4uokYvibeKWdeF1xjbJ8DLlpPOtD1T1BMo1zcWpIhVBkFZ/ qKCuGZy7kdThXT9RjIdLFgqkFXaIOTeFLfvJaMNoudnq3ygcss0bg9DXRFVomRp3n4RI UOh8IOg6klGr2Tl2Amqex0B0DEkvKDZfZnZsTJK0eAGyt9edJA3BKp4u+Qr3GLUaHaex qY51C/P+FfjonhzphfFw56jwzNm5NMl5YTqtKki7Al3736LKfcbGrbnhLAKp5TWRl/BH caveFG36EnxgY3Bb6DcDqFYbe8kmX1/0/6bTJz6/b/AI6LNU02J26Ype18YBP467kbcF 7GDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:reply-to:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QHEIpO0dxXtHTDobS2FJbnWSGt7Ye5sk9U+qkhC4Fko=; b=WYJdkSVjZnKdxwv+V5JuOTKEjyw3FMKbkMYohSEN2wTR8wl5PwCJWv8GHnTYr4Rm6X lsv2rRLQBeG315wNiTzSvS5RVfuk1p5UiGds9O8gV+y0DOWC9b8fGSXhLQpsNw/O7HlF tLeQWfWiLEkpCQJRbes83XI6fdJkoa7jtlVfdQpL5RG78RRCUolmEojH3MNZ+8ZpCgIm BknYk2BM595f7McLkMhyh3Zv7FE9pxHatxXShmCSROHHb3OIu1rOfYRoVM/GBwDXOsa8 u9hWVRW9nEGwSNi3rrfyKkdXyErRJnqC7BnDYyyfUfuUqDvS9jEMpNAIBenZeV2NxUzv GDgg== X-Gm-Message-State: AFqh2kqV8Yz3UQYaX+f+709xoUKpHyF/d0IVwn5fk0MJMxMsnApUKnnb OTo7W2SuQokGBHMhLJoXP58IQ2F9ZMc= X-Google-Smtp-Source: AMrXdXvZCLOxVRT9aPnXfkbxgR3VocRS/ou3PSRb3gmHV+FlVxzZDLuZOod4g/W6ZFvzpL84YrrsFQ== X-Received: by 2002:adf:ffc1:0:b0:242:3fa4:8217 with SMTP id x1-20020adfffc1000000b002423fa48217mr13735164wrs.50.1672145831413; Tue, 27 Dec 2022 04:57:11 -0800 (PST) Received: from ?IPV6:2a01:cb1d:88e0:1200:491c:1424:b264:6a95? ([2a01:cb1d:88e0:1200:491c:1424:b264:6a95]) by smtp.gmail.com with ESMTPSA id r13-20020a5d52cd000000b002425be3c9e2sm12735875wrv.60.2022.12.27.04.57.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Dec 2022 04:57:09 -0800 (PST) Message-ID: <1f361f63-69ca-9a97-9ce0-929f3e92ba6b@gmail.com> Date: Tue, 27 Dec 2022 13:57:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <5d535508-ed43-d90a-3673-f3b9e98c40a0@gmail.com> <50bc89c8-7c4f-ab2e-485e-0e4e717aea56@gmail.com> From: Jeffrey CHAPUIS In-Reply-To: <50bc89c8-7c4f-ab2e-485e-0e4e717aea56@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > You could just call ff_filter_process_command() instead of hardcoding > supported commands here. It will ignore any option without the > AV_OPT_FLAG_RUNTIME_PARAM flag. > This is going to generate memleaks, and needlessly reallocate > unrelated buffers. > You should instead av_realloc all four s->bboxes buffers here, and > reset s->limit. I don't have knowledge in c/c++, I based my changes on vf_crop.c, but i will look into your suggestions. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".