From: Jeffrey CHAPUIS <ashyni1987@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime
Date: Tue, 27 Dec 2022 13:57:06 +0100
Message-ID: <1f361f63-69ca-9a97-9ce0-929f3e92ba6b@gmail.com> (raw)
In-Reply-To: <50bc89c8-7c4f-ab2e-485e-0e4e717aea56@gmail.com>
> You could just call ff_filter_process_command() instead of hardcoding
> supported commands here. It will ignore any option without the
> AV_OPT_FLAG_RUNTIME_PARAM flag.
> This is going to generate memleaks, and needlessly reallocate
> unrelated buffers.
> You should instead av_realloc all four s->bboxes buffers here, and
> reset s->limit.
I don't have knowledge in c/c++, I based my changes on vf_crop.c, but i
will look into your suggestions.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-12-27 12:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 11:46 Jeffrey CHAPUIS
2022-12-27 12:34 ` James Almer
2022-12-27 12:57 ` Jeffrey CHAPUIS [this message]
2022-12-27 12:33 Jeffrey CHAPUIS
2022-12-28 11:02 Jeffrey CHAPUIS
2022-12-28 11:21 ` Marton Balint
2022-12-28 11:51 ` James Almer
2022-12-28 15:37 ` Jeffrey CHAPUIS
2023-01-10 13:15 Jeffrey CHAPUIS
2023-01-10 15:45 ` Paul B Mahol
2023-01-11 11:42 ` Jeffrey Chapuis
2023-01-11 17:46 ` Jeffrey Chapuis
2023-01-12 15:53 ` Jeffrey Chapuis
2023-01-17 11:46 ` Jeffrey Chapuis
2023-01-17 11:52 ` Paul B Mahol
2023-01-17 12:27 ` Jeffrey Chapuis
2023-01-17 12:34 ` Paul B Mahol
2023-01-17 13:31 ` Jeffrey Chapuis
2023-01-17 13:45 ` Paul B Mahol
2023-01-17 14:24 ` Jeffrey Chapuis
2023-01-17 14:29 ` Paul B Mahol
2023-01-17 15:19 ` Jeffrey Chapuis
2023-01-17 16:23 ` Paul B Mahol
2023-01-17 18:00 ` Jeffrey Chapuis
2023-01-17 18:11 ` Paul B Mahol
2023-01-17 22:07 ` Jeffrey Chapuis
2023-01-19 12:11 ` Jeffrey Chapuis
2023-01-19 13:50 ` Jeffrey Chapuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f361f63-69ca-9a97-9ce0-929f3e92ba6b@gmail.com \
--to=ashyni1987@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git