From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 93F094E2FE for ; Wed, 30 Apr 2025 22:14:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6252A68B2DD; Thu, 1 May 2025 01:13:58 +0300 (EEST) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AADA1687CDD for ; Thu, 1 May 2025 01:13:51 +0300 (EEST) Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-39ee5a5bb66so165563f8f.3 for ; Wed, 30 Apr 2025 15:13:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20230601.gappssmtp.com; s=20230601; t=1746051231; x=1746656031; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A+qxMGnGQJSNq5FFcRvc11zaRrryWN2GFL670HrFVlM=; b=b5zuUFyqlBuaeis9BN+rRC1P5W72CrW/1CM+g6XVWA380nDAFAMOlbXWFf60OzJ+nM OBnM2v9mRBxBh62T0qYKCOhz+HxGd2SuMJN/mpUCgZpnJX5wobm9CiIDLhEFz8TiBQaP PY9hr2AQE2Zbbs4dCqy+amCIKphCFt89NkNwjmftrBtUzJg2r0P9rBojHojbCWlutV9a fe6rtnPR27H2t0f96QBPCEEVnoIhKNfMhY++vlkL+RUXmgDCfXbMGS8pNB95LpNCV0vb SVFUR1xt4U5ilpVjIUsqoVXcpjcFjbo4V3YZs1cU+g9waUpKeJskMpf4QlYvr9UwrPvn zcKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746051231; x=1746656031; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A+qxMGnGQJSNq5FFcRvc11zaRrryWN2GFL670HrFVlM=; b=uQlAAQfcz+0wPz9XhxDSAMcmTSz14FLxkCRI7rwsorLX4jknwBkVAh5aWc4bLtGaZ4 hW649cbeVTLbuahncHdAFxUmGHzxhQ2isMxCscu9uCKrPS+6rpeEra39KHJT5l8lR0kE AYqAb2T2ZeIbRuLZzTKmc7s0UyxAEBlCs3v0UvhKjHHV1OjhM9SvYdIYHGT6nbTlq+Ui tBrzZhe6gf4YotPNFiFULC1ZKbz78k1gQAtws84BsBytzIWunDI6n1oAE+mElcJD5BBG 01OpLsGSVcnocX87rcFIflIT7Aw4CKEQXsldGPc5Ol6TClgAPrEXxs4r8Fga7DQGtxJZ rOnA== X-Gm-Message-State: AOJu0Yxf2+0TAdQ8gkgeobQifdVw4H8fzoXLbAbZeN6JiwFeGoqOChAY 0zOvhKMeTbYG/Jgk2ZW/4NRhm77rmkg8QkVkbI3akdFfWA6+i63hArx1EkEdw//rtr3nmbCrbbO WvH7nqA== X-Gm-Gg: ASbGnctbU4I+09EpdTyM7RwlKQhk2RZOW4UtAwwR5tTnc3ZPqrarHSUj3pyo5KODEDL zrn1sXZT0OZhyJdJ12AiZWgs1770sVNkVLtyjeZyEBIt/HkIAb/o08nc30dJ2AM4mnPw3NJ+APv RrJ/9GANBZjsaCaqi8pKLImQdjZL5KE2B7+eyTClLOeKZKCGPHVuMYrWUe11Si6bNGivN/NmHXf DNsOI5nPO0IiyKUdhbE0IxC4m9AKb1Eu0db5D6yNs2tB9Bp7faLH785GmQDflYKSXtGTvGb74dS GQVUXrBUDgCV5jiQG0ZQSV/lU7SJdTxkDVoQhHL/U0uBJCCsbeDEO7yYc7519aoFOz2Pydr3d6F +HYe48v0E+2UWFw== X-Google-Smtp-Source: AGHT+IGay8g3kgrfPPkWCrhBkJ5FaKmY7tE67MJ27aaKrpYATBPKtrJx20UjLOK/mPoc46De2JQ0Zw== X-Received: by 2002:a05:6000:4287:b0:39e:e3ef:5cbf with SMTP id ffacd0b85a97d-3a093035b1dmr585662f8f.24.1746051231033; Wed, 30 Apr 2025 15:13:51 -0700 (PDT) Received: from [192.168.0.15] (cpc92320-cmbg19-2-0-cust719.5-4.cable.virginm.net. [82.13.66.208]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b2b28045sm37310065e9.35.2025.04.30.15.13.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Apr 2025 15:13:50 -0700 (PDT) Message-ID: <1f05ddc8-c675-4523-bc45-644cbda64fac@jkqxz.net> Date: Wed, 30 Apr 2025 23:13:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20250430212227.77685-1-jamrial@gmail.com> From: Mark Thompson In-Reply-To: <20250430212227.77685-1-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/cbs_apv: don't return an error when reading empty buffers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 30/04/2025 22:22, James Almer wrote: > The output will be a fragment with zero units, which is a lot more user friendly > than making them think something went wrong, as it already happens with cbs_av1. > > Signed-off-by: James Almer > --- > libavcodec/cbs_apv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/cbs_apv.c b/libavcodec/cbs_apv.c > index 2c4a1daaf0..e7dd04825c 100644 > --- a/libavcodec/cbs_apv.c > +++ b/libavcodec/cbs_apv.c > @@ -168,8 +168,8 @@ static int cbs_apv_split_fragment(CodedBitstreamContext *ctx, > uint32_t signature; > int err, trace; > > - if (header) { > - // Ignore extradata fragments. > + if (header || !frag->data_size) { > + // Ignore empty or extradata fragments. > return 0; > } > LGTM. Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".