From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8F00C4B0D2 for ; Thu, 27 Jun 2024 17:20:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2438568D66F; Thu, 27 Jun 2024 20:19:59 +0300 (EEST) Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E177068B631 for ; Thu, 27 Jun 2024 20:19:52 +0300 (EEST) Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-e02c17219fdso1038098276.0 for ; Thu, 27 Jun 2024 10:19:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719508791; x=1720113591; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=+PxEE8lp2MMhhe31lRvNJjpmN2fjVTWPZLJWAZujp3I=; b=kLoppxpHetUdB9hUCxnY6IDcT6LAXXPm+L/uOeoTPT70wc2rM4sIP8YYoJa3Psr7Y8 iZhci35skttlb0BZT6lWYAZjfI1RNegQu9DRBuUIFZcGxPi7VZ16rSZK8hXFO+xPDDu+ M4bchHpwKGw4VmTBa5Bny/dKk3lCIGiEjfKHbWgLzS6LjgcXIFI3VLqabPlChHmQXCus XPi1w3hGzy0kKgqAXTFKT6IfyIjnjyV4m3eME4Hk5iYwFI+2nzUzVhZCsyBwVfRHvHYd xkAnEgYRuSUiKSmVbgwa3niZ0m7lU4312XaCYWR4tprchOeE0eMio3EY41G6wzZgOCtY XvbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719508791; x=1720113591; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+PxEE8lp2MMhhe31lRvNJjpmN2fjVTWPZLJWAZujp3I=; b=lc0nDRImNSurCLdxZdilI978QQnsHKxwjuGXjq7F5OVa6/j2nZ7grk4jyRYIRkyNMy U9I6mT7/IrB3cA70H9Y7jQ1lkl1etswKub04UgaM5OzbEqwbtZ+2BEWKnWJEfV/I0n6Z TvM+sCbtSbZDXCgkKc4767BYoZ62OV7Z9Pv1anSPFgtJwNXx4wIwpVkT+jpDa+07U3XV lMShyIL4EAVo1owYy00HGAOEStK5d04qD8KCR5DvEOKeSGNQ+EAIFbcDTFDL2im8LAl+ egxWbp9+rqLLqG10sCfo2X1wKvSy12FAm5kpvcMe0oiMIBtfLmnbbfPw7zJreACqZb0h Vs0w== X-Gm-Message-State: AOJu0YwmYefgOY8oeqJ+JRXZJkLFT/2ifgw6z14ikBfrerD3yA1Msmm4 68MqsKjguSIGAWJjwfnWe59nSYxr7gosF2ZChuM6cUeqQS6/CaWCJkeH2w== X-Google-Smtp-Source: AGHT+IE8vhmfkC4vtpQ7LWw6AXcrDJbc0wmOMaXqrvdcnw3OfDjz6lrpen6rRLqn7AxPcavDecRyOQ== X-Received: by 2002:a05:690c:4c0f:b0:630:8881:1508 with SMTP id 00721157ae682-64202b67720mr100429467b3.1.1719508791262; Thu, 27 Jun 2024 10:19:51 -0700 (PDT) Received: from [192.168.1.35] (c-68-56-149-176.hsd1.mi.comcast.net. [68.56.149.176]) by smtp.gmail.com with ESMTPSA id 00721157ae682-64a99e5ca1bsm107157b3.17.2024.06.27.10.19.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jun 2024 10:19:51 -0700 (PDT) Message-ID: <1eed59ec-17a3-495a-89a9-90088b3606bc@gmail.com> Date: Thu, 27 Jun 2024 13:19:50 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: FFmpeg Development References: <20240621212013.188475-1-leo.izen@gmail.com> Content-Language: en-US-large From: Leo Izen Autocrypt: addr=leo.izen@gmail.com; keydata= xjMEZZw8HxYJKwYBBAHaRw8BAQdAgcfI+LbtjWarA7LQu6/WAPlKkn9tn4HalmHgGVhMUdzN KkxlbyBJemVuIChUcmFuZXB0b3JhKSA8bGVvLml6ZW5AZ21haWwuY29tPsKTBBMWCgA7FiEE HYMKC85GcJ4gOyb8dk5I6kgiGDMFAmWcPB8CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcC F4AACgkQdk5I6kgiGDOnGAEA+oJFwblAblnhK+T5a5EuEbXMTZG4FkYTYz0VmjJ0NHIA/Rn9 ZE9+EEsH8fmT0hRJSiM3+zbkwQJA9gVVYAek9kMKzjgEZZw8HxIKKwYBBAGXVQEFAQEHQDes 4thejF9AU2rkGuDuut3CQYwB4SVpI4EzU8uvPJgfAwEIB8J4BBgWCgAgFiEEHYMKC85GcJ4g Oyb8dk5I6kgiGDMFAmWcPB8CGwwACgkQdk5I6kgiGDOv3QD+PLXrL0Ihk675Ip5FG+VJOodN 6e+5n3iYC6wJ75eqG3EA/1nCywoGXlCYuzXgq3el6NOn+8awwaXcTVJFzZCRbe8M In-Reply-To: <20240621212013.188475-1-leo.izen@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/aacdec_lpd: remove unused local variables X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/21/24 5:20 PM, Leo Izen wrote: > int idx, and int first_tcx_flag are set but not used, so this commit > removes their declarations and assignments. > --- > libavcodec/aac/aacdec_lpd.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/aac/aacdec_lpd.c b/libavcodec/aac/aacdec_lpd.c > index 796edd2ab5..91a3268889 100644 > --- a/libavcodec/aac/aacdec_lpd.c > +++ b/libavcodec/aac/aacdec_lpd.c > @@ -99,7 +99,7 @@ static void parse_qn(GetBitContext *gb, int *qn, int nk_mode, int no_qn) > static int parse_codebook_idx(GetBitContext *gb, uint32_t *kv, > int nk_mode, int no_qn) > { > - int idx, n, nk; > + int n, nk; > > int qn[2]; > parse_qn(gb, qn, nk_mode, no_qn); > @@ -114,7 +114,7 @@ static int parse_codebook_idx(GetBitContext *gb, uint32_t *kv, > } > } > > - idx = get_bits(gb, 4*n); > + skip_bits(gb, 4*n); > > if (nk > 0) > for (int i = 0; i < 8; i++) > @@ -145,7 +145,6 @@ int ff_aac_ldp_parse_channel_stream(AACDecContext *ac, AACUSACConfig *usac, > int k; > const uint8_t *mod; > int first_ldp_flag; > - int first_tcx_flag; > > ce->ldp.acelp_core_mode = get_bits(gb, 3); > ce->ldp.lpd_mode = get_bits(gb, 5); > @@ -157,7 +156,6 @@ int ff_aac_ldp_parse_channel_stream(AACDecContext *ac, AACUSACConfig *usac, > mod = ff_aac_lpd_mode_tab[ce->ldp.lpd_mode]; > > first_ldp_flag = !ce->ldp.core_mode_last; > - first_tcx_flag = 1; > if (first_ldp_flag) > ce->ldp.last_lpd_mode = -1; /* last_ldp_mode is a **STATEFUL** value */ > > @@ -179,7 +177,6 @@ int ff_aac_ldp_parse_channel_stream(AACDecContext *ac, AACUSACConfig *usac, > // parse_tcx_coding(); > ce->ldp.last_lpd_mode = mod[k]; > k += (1 << (mod[k] - 1)); > - first_tcx_flag = 0; > } > } > Bumping for review. - Leo Izen (Traneptora) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".