From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] vc1dsp: Change remaining stride parameters to ptrdiff_t
Date: Wed, 30 Mar 2022 15:05:15 +0300 (EEST)
Message-ID: <1ee2a526-325d-adee-493e-a358afd2134e@martin.st> (raw)
In-Reply-To: <e181a8f9-dd9e-c9c0-8c3a-a813e4c6bf64@riscosopen.org>
On Tue, 29 Mar 2022, Ben Avison wrote:
> On 29/03/2022 13:44, Martin Storsjö wrote:
>> The existing x86 assembly for loop filters uses the stride as a
>> full register without clearing/sign extending the upper half
>> of the registers on x86_64.
>>
>> This avoids crashes if the caller would have passed nonzero bits
>> in the previously undefined upper 32 bits of the parameters.
>
> Looks perfectly reasonable to me. I'll hold off making matching changes
> to my upcoming Arm versions until this gets merged. (My 64-bit Arm
> versions followed the old prototype and sign-extended the strides from
> 32 to 64 bits, but that won't be necessary any more.)
Acked by Lynne on irc too - so I pushed it now.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-03-30 12:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 12:44 Martin Storsjö
2022-03-29 19:02 ` Ben Avison
2022-03-29 20:51 ` [FFmpeg-devel] [PATCH v2] " Martin Storsjö
2022-03-30 12:05 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ee2a526-325d-adee-493e-a358afd2134e@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git