From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0DEE24A691 for ; Wed, 3 Apr 2024 19:21:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A832568D0D2; Wed, 3 Apr 2024 22:21:09 +0300 (EEST) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CBD7468CF80 for ; Wed, 3 Apr 2024 22:21:03 +0300 (EEST) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-41624fe4194so1136425e9.3 for ; Wed, 03 Apr 2024 12:21:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20230601.gappssmtp.com; s=20230601; t=1712172063; x=1712776863; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pMTnyON3I55QBha2p7TNN8b8Cf7RuTk7gxXHEWy3sZQ=; b=nRR1UsgTpo9rE+1ARWhJy0avhwPnlRykY/3cYaH7urI+P46SovB8MV0XAymQjGnJ/L VcarnBciyXVhrHwY/vVPnSwdXzIf0PDITswEsmrnI8zzi3eYr2SvrsCIxqRBa9poJRrP IQwWlewucfCAIOLb0PdM3qB0uZHFfeYp2xR9bhuDZ4dQGLANg5v/bgWkgRK3jqvQV28A 8l7u3r2rVznlfcpkUmIGzylwOEloaFk5h+P4krM6P99lUR3yKsr3TJm1RkgSxtMb2o4W NDhR/W/T4RyvYP06umesc/OTiI+hwGQUrVMrtT26kgu/J0Y8VHt5NOM0Usm/ndN8eNT9 h+bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712172063; x=1712776863; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pMTnyON3I55QBha2p7TNN8b8Cf7RuTk7gxXHEWy3sZQ=; b=eBBjJbU9+7s4R7nznC/yLBTTfnpkXH95D6CbT/xGHB5+D022rn49K3EFtYW3+uyejd WN+zpFXMf4YF2Sru9Yu+MqysX72r44cQmohipPOcbZmmFKkYOlBjRHrMEnRekkwLXyS6 +m1CqeB0poi8yPHaKp32YUZa/XJs91BthlAuCvQY8Afci4M/YLXHUsn6smKLl9u4TFoN wXWugWnPvat+O0cIHh/n32knw69zLYhrU3pYU1+JlsAtWAdqUvQplArWBadbJPZvvWDx a8dA1mIE3WA+Wy7DlTT6uAikuwR4xAyprldlvOUhx5u/CA1megKffL35D14JmGv/CGWX ZQUg== X-Gm-Message-State: AOJu0YxIzdOtVhglQ+m2T6RQXeUNp6B9afzbYO5tRbXK3if5f7ZCV3IC bS/qrSPuc1N9So094EYYKkt3Lef7t77qFQN3B57ewBkHcLjln0v3UysOLvj9DU7Lwa6rwiBldfk M X-Google-Smtp-Source: AGHT+IFMd2d7uwQ8JwUSaGtnCZtSmmFmfEiVXWy/yo9idQ5GzvK2xnY3tGZ50ZVLu8+U6Q0tfIRGdA== X-Received: by 2002:a05:600c:1c95:b0:415:6121:5171 with SMTP id k21-20020a05600c1c9500b0041561215171mr332452wms.32.1712172062965; Wed, 03 Apr 2024 12:21:02 -0700 (PDT) Received: from [192.168.0.15] (cpc92302-cmbg19-2-0-cust1183.5-4.cable.virginm.net. [82.1.212.160]) by smtp.gmail.com with ESMTPSA id h15-20020a05600c314f00b004155afe0c11sm119656wmo.15.2024.04.03.12.21.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Apr 2024 12:21:02 -0700 (PDT) Message-ID: <1e0af962-33b5-4226-8344-8cd39d77dc9b@jkqxz.net> Date: Wed, 3 Apr 2024 20:21:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240328021717.4116418-1-haihao.xiang@intel.com> From: Mark Thompson In-Reply-To: <20240328021717.4116418-1-haihao.xiang@intel.com> Subject: Re: [FFmpeg-devel] [PATCH 1/3] lavu/hwcontext_vaapi: Add a new quirk X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 28/03/2024 02:17, Xiang, Haihao wrote: > From: Haihao Xiang > > libva2 doesn't require a fixed surface-array any more, but some > driver/hardware combinations which rely on this are still used. To > reduce the impact to users, add a quirk for the driver/hardware > combination which supports dynamic surface pool. > > Signed-off-by: Haihao Xiang > --- > libavutil/hwcontext_vaapi.c | 7 +++++++ > libavutil/hwcontext_vaapi.h | 6 ++++++ > 2 files changed, 13 insertions(+) > > diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c > index 56d03aa4cd..dae5dd4a11 100644 > --- a/libavutil/hwcontext_vaapi.c > +++ b/libavutil/hwcontext_vaapi.c > @@ -390,6 +390,13 @@ static const struct { > "Splitted-Desktop Systems VDPAU backend for VA-API", > AV_VAAPI_DRIVER_QUIRK_SURFACE_ATTRIBUTES, > }, > +#if CONFIG_VAAPI_1 > + { > + "New Intel iHD", > + "Intel iHD driver for Intel(R) Gen Graphics", > + AV_VAAPI_DRIVER_QUIRK_DYNAMIC_SURFACE_POOL, > + }, > +#endif > }; > > static int vaapi_device_init(AVHWDeviceContext *hwdev) > diff --git a/libavutil/hwcontext_vaapi.h b/libavutil/hwcontext_vaapi.h > index 0b2e071cb3..07014fd526 100644 > --- a/libavutil/hwcontext_vaapi.h > +++ b/libavutil/hwcontext_vaapi.h > @@ -58,6 +58,12 @@ enum { > * and the results of the vaQuerySurfaceAttributes() call will be faked. > */ > AV_VAAPI_DRIVER_QUIRK_SURFACE_ATTRIBUTES = (1 << 3), > + > + /** > + * The driver (and the underlying HW) supports dynamic surface pool. > + * The vaCreateContext() call doesn't require a fixed surface-array. > + */ > + AV_VAAPI_DRIVER_QUIRK_DYNAMIC_SURFACE_POOL = (1 << 4), > }; > > /** I do not think a vendor-specific quirk like this is a reasonable answer, but I can see that your company is invested in making sure that your current driver doesn't hit this problem. Given that, I give up on arguing for trying to preserve compatibility here. Let's just use dynamic pools unconditionally and see if anything breaks. Is there any reason not to drop support for libva < 2.0 at the same time? (Making CONFIG_VAAPI_1 always true.) It is of similar age to C17, which we are intending to require soon as well. Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".