From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AC0854BA3E for ; Wed, 10 Jul 2024 17:26:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 56B2668DB66; Wed, 10 Jul 2024 20:26:14 +0300 (EEST) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C7F8268DAC0 for ; Wed, 10 Jul 2024 20:26:07 +0300 (EEST) Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-70df2135426so3577962a12.2 for ; Wed, 10 Jul 2024 10:26:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720632364; x=1721237164; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=cy7Uz8ovyX3J7zjc1+NkEkHr8Vz4mdbvacwKsuIVQaQ=; b=ZmdGnDwEPOd2RsZctqBc1FwNEqceHgdItZAfhDI5XLp6Ag6pEBuzNB6C4nRGWgyC94 rHu86Nkzlx++TyRszEBXy8JLN+67SVn+tc8pbBqvii2riNMXFVoMuIVWETMZ6P7HjiBj 1t7VvCi9WleYHeOGmEcwarMuEY6jCLW1tp27FnjvTcje+fg/qx8A7XVAtYOuNFUq6MdP u16xn6PpPfrGJrgTuIW4yjVYzgOBLL9YlvQOzoBr2F9p7vePZMjKXFVVhFrXtMJZgodD rvV3faNAiHaGG1yXbY7FU/iMpxxPVTLHtIqGQFkt19mmt3x/YTUDDMCe3n7MZgds9hQj 6prw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720632364; x=1721237164; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cy7Uz8ovyX3J7zjc1+NkEkHr8Vz4mdbvacwKsuIVQaQ=; b=WZgxSBQJ8hFt4vKOfS0nACkTEaFoSBr2jTFf05WBUV9BF6+e2jgjV983xDulZ8n06X pYqdAMlfY2kRkRH0ArLODwf4+ozgL5Lz/OJZ62Qeq0Mou1TGE0QptslSJbMf7gd+k8Hj 842B8ZiNG2x0pDI2Cci2RJO/cyyb4owgM1d11/HnT8eBRdGATwlxOPRQHHYB3EEymval C6Wjl1zVFswIT44mXn7AMCfD4lbTDyQBuoVYj4NpDQMgLnGwskD06yTiad68Hc19Kuri KUibqXMPXnD4q/53d/Q+mVpP1Di32LIycmtMImFHd1sd58M14DFO1vxqiT8Hc3kil5e3 fqmg== X-Gm-Message-State: AOJu0YyRwZF9/mlBULBKIqGuyi+Ywq0T2p2WtFVMZdnpoFB+/CKU2FPg hjI5DBa2lC64pLebQY36SHu2UztIGrT/nhm18eoVYK5S/sab3bbU/VmIuw== X-Google-Smtp-Source: AGHT+IF7dI0+YtOjLmBfJ6iShi8xK93VER86FlyUSUfMJlLF1wuhPVFUavDp4D9Pi+GCRSOU6WX8hQ== X-Received: by 2002:a05:6a20:8425:b0:1c2:a68b:3b9 with SMTP id adf61e73a8af0-1c2a68b0447mr4131207637.58.1720632364181; Wed, 10 Jul 2024 10:26:04 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fbb6ab7d17sm36318375ad.173.2024.07.10.10.26.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jul 2024 10:26:03 -0700 (PDT) Message-ID: <1de99f92-a58d-4707-8113-2ab4fb83ad4f@gmail.com> Date: Wed, 10 Jul 2024 14:26:08 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix version check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/9/2024 5:43 AM, epirat07@gmail.com wrote: > > > On 8 Jul 2024, at 8:30, Zhao Zhili wrote: > >> From: Zhao Zhili >> >> --- >> libavutil/hwcontext_videotoolbox.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c >> index 953155ce32..dd89edfa08 100644 >> --- a/libavutil/hwcontext_videotoolbox.c >> +++ b/libavutil/hwcontext_videotoolbox.c >> @@ -588,7 +588,7 @@ static int vt_pixbuf_set_colorspace(void *log_ctx, >> } else >> CVBufferRemoveAttachment(pixbuf, kCVImageBufferGammaLevelKey); >> >> - if (__builtin_available(macOS 10.8, iOS 10, *)) { >> + if (__builtin_available(macOS 12.0, iOS 15.0, *)) { >> CFDictionaryRef attachments = CVBufferCopyAttachments(pixbuf, kCVAttachmentMode_ShouldPropagate); >> if (attachments) { >> colorspace = CVImageBufferCreateColorSpaceFromAttachments(attachments); >> -- >> 2.42.0 > > LGTM. Sorry for breaking this. http://fate.ffmpeg.org/log.cgi?time=20240710170512&slot=aarch64-osx-clang-1200.0.32.29&log=compile Looks like it's not enough. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".