* [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix version check
@ 2024-07-08 6:30 Zhao Zhili
2024-07-09 8:43 ` epirat07
0 siblings, 1 reply; 4+ messages in thread
From: Zhao Zhili @ 2024-07-08 6:30 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Zhao Zhili
From: Zhao Zhili <zhilizhao@tencent.com>
---
libavutil/hwcontext_videotoolbox.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
index 953155ce32..dd89edfa08 100644
--- a/libavutil/hwcontext_videotoolbox.c
+++ b/libavutil/hwcontext_videotoolbox.c
@@ -588,7 +588,7 @@ static int vt_pixbuf_set_colorspace(void *log_ctx,
} else
CVBufferRemoveAttachment(pixbuf, kCVImageBufferGammaLevelKey);
- if (__builtin_available(macOS 10.8, iOS 10, *)) {
+ if (__builtin_available(macOS 12.0, iOS 15.0, *)) {
CFDictionaryRef attachments = CVBufferCopyAttachments(pixbuf, kCVAttachmentMode_ShouldPropagate);
if (attachments) {
colorspace = CVImageBufferCreateColorSpaceFromAttachments(attachments);
--
2.42.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix version check
2024-07-08 6:30 [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix version check Zhao Zhili
@ 2024-07-09 8:43 ` epirat07
2024-07-10 17:26 ` James Almer
0 siblings, 1 reply; 4+ messages in thread
From: epirat07 @ 2024-07-09 8:43 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On 8 Jul 2024, at 8:30, Zhao Zhili wrote:
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> ---
> libavutil/hwcontext_videotoolbox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
> index 953155ce32..dd89edfa08 100644
> --- a/libavutil/hwcontext_videotoolbox.c
> +++ b/libavutil/hwcontext_videotoolbox.c
> @@ -588,7 +588,7 @@ static int vt_pixbuf_set_colorspace(void *log_ctx,
> } else
> CVBufferRemoveAttachment(pixbuf, kCVImageBufferGammaLevelKey);
>
> - if (__builtin_available(macOS 10.8, iOS 10, *)) {
> + if (__builtin_available(macOS 12.0, iOS 15.0, *)) {
> CFDictionaryRef attachments = CVBufferCopyAttachments(pixbuf, kCVAttachmentMode_ShouldPropagate);
> if (attachments) {
> colorspace = CVImageBufferCreateColorSpaceFromAttachments(attachments);
> --
> 2.42.0
LGTM. Sorry for breaking this.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix version check
2024-07-09 8:43 ` epirat07
@ 2024-07-10 17:26 ` James Almer
2024-07-10 18:08 ` epirat07
0 siblings, 1 reply; 4+ messages in thread
From: James Almer @ 2024-07-10 17:26 UTC (permalink / raw)
To: ffmpeg-devel
On 7/9/2024 5:43 AM, epirat07@gmail.com wrote:
>
>
> On 8 Jul 2024, at 8:30, Zhao Zhili wrote:
>
>> From: Zhao Zhili <zhilizhao@tencent.com>
>>
>> ---
>> libavutil/hwcontext_videotoolbox.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
>> index 953155ce32..dd89edfa08 100644
>> --- a/libavutil/hwcontext_videotoolbox.c
>> +++ b/libavutil/hwcontext_videotoolbox.c
>> @@ -588,7 +588,7 @@ static int vt_pixbuf_set_colorspace(void *log_ctx,
>> } else
>> CVBufferRemoveAttachment(pixbuf, kCVImageBufferGammaLevelKey);
>>
>> - if (__builtin_available(macOS 10.8, iOS 10, *)) {
>> + if (__builtin_available(macOS 12.0, iOS 15.0, *)) {
>> CFDictionaryRef attachments = CVBufferCopyAttachments(pixbuf, kCVAttachmentMode_ShouldPropagate);
>> if (attachments) {
>> colorspace = CVImageBufferCreateColorSpaceFromAttachments(attachments);
>> --
>> 2.42.0
>
> LGTM. Sorry for breaking this.
http://fate.ffmpeg.org/log.cgi?time=20240710170512&slot=aarch64-osx-clang-1200.0.32.29&log=compile
Looks like it's not enough.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix version check
2024-07-10 17:26 ` James Almer
@ 2024-07-10 18:08 ` epirat07
0 siblings, 0 replies; 4+ messages in thread
From: epirat07 @ 2024-07-10 18:08 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On 10 Jul 2024, at 19:26, James Almer wrote:
> On 7/9/2024 5:43 AM, epirat07@gmail.com wrote:
>>
>>
>> On 8 Jul 2024, at 8:30, Zhao Zhili wrote:
>>
>>> From: Zhao Zhili <zhilizhao@tencent.com>
>>>
>>> ---
>>> libavutil/hwcontext_videotoolbox.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
>>> index 953155ce32..dd89edfa08 100644
>>> --- a/libavutil/hwcontext_videotoolbox.c
>>> +++ b/libavutil/hwcontext_videotoolbox.c
>>> @@ -588,7 +588,7 @@ static int vt_pixbuf_set_colorspace(void *log_ctx,
>>> } else
>>> CVBufferRemoveAttachment(pixbuf, kCVImageBufferGammaLevelKey);
>>>
>>> - if (__builtin_available(macOS 10.8, iOS 10, *)) {
>>> + if (__builtin_available(macOS 12.0, iOS 15.0, *)) {
>>> CFDictionaryRef attachments = CVBufferCopyAttachments(pixbuf, kCVAttachmentMode_ShouldPropagate);
>>> if (attachments) {
>>> colorspace = CVImageBufferCreateColorSpaceFromAttachments(attachments);
>>> --
>>> 2.42.0
>>
>> LGTM. Sorry for breaking this.
>
> http://fate.ffmpeg.org/log.cgi?time=20240710170512&slot=aarch64-osx-clang-1200.0.32.29&log=compile
>
> Looks like it's not enough.
See my patch from yesterday, should fix it.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-10 18:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-08 6:30 [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix version check Zhao Zhili
2024-07-09 8:43 ` epirat07
2024-07-10 17:26 ` James Almer
2024-07-10 18:08 ` epirat07
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git