From: Timo Rothenpieler <timo@rothenpieler.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: fix NULL pointer dereference
Date: Tue, 28 Feb 2023 17:05:37 +0100
Message-ID: <1dcc5fed-de31-6a17-34ab-20b0cfc6bbf0@rothenpieler.org> (raw)
In-Reply-To: <tencent_6AAD25575303485BB3ECF365D5CFC90EAE05@qq.com>
On 28.02.2023 16:03, Zhao Zhili wrote:
> I can move the check from here to close(). assert is helpful if it can catch
> bugs during development. It doesn't help much here since this is a rare case
> which doesn't triggered during development.
Crashing with an assertion is still much better than dereferencing a
NULL pointer.
I'll have a look at the calling function in a bit, to see if it can be
refactored to never run into the chance of calling this function when
not needed.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-02-28 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 18:43 Zhao Zhili
2023-02-28 12:08 ` Steven Liu
2023-02-28 14:37 ` Timo Rothenpieler
2023-02-28 15:03 ` Zhao Zhili
2023-02-28 16:05 ` Timo Rothenpieler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dcc5fed-de31-6a17-34ab-20b0cfc6bbf0@rothenpieler.org \
--to=timo@rothenpieler.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git