From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 16867407A2 for ; Sun, 1 May 2022 02:16:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9A9C868B234; Sun, 1 May 2022 05:16:38 +0300 (EEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D687268AF1C for ; Sun, 1 May 2022 05:16:31 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651371397; x=1682907397; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=iGkjybI5VByqbeidd7/qtgmIbbeB6z6x8nQ1O7AZGZQ=; b=LcB4KLZSLLUJmmkxIWj9hqYFmBdTkZA5xXhbERGrPBSNfr8QWAhArpWZ jkyt2pxJkx1Q33si1qc0xDRC+U6DzajLm3qypBLqBsrSBiQ2Tx4+0K2Y+ 0F5PfZfVGNcm44Gn4yO3URS79toH9FheBCWnel1BNHp03ewxUDcZEMC5r 2qO9LBf17oyxI9G2R9A1stBHFohoRBqGdLezvpzHYMvboeCIc01pLKjFy F2RmGGl4XWFTRIXIpCdJpZJfcLUDGxXxFMnuuBHUnBoZzbEitTEEdGaEB /ZrY97+iFzm+SqF5aiiI7Jd2pvuC35Kzx6KTq1zgCAcdvGWwj4HDFx1IB w==; X-IronPort-AV: E=McAfee;i="6400,9594,10333"; a="329920671" X-IronPort-AV: E=Sophos;i="5.91,189,1647327600"; d="scan'208";a="329920671" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2022 19:16:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,189,1647327600"; d="scan'208";a="707101411" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga001.fm.intel.com with ESMTP; 30 Apr 2022 19:16:28 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sat, 30 Apr 2022 19:16:28 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sat, 30 Apr 2022 19:16:27 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sat, 30 Apr 2022 19:16:27 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.42) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sat, 30 Apr 2022 19:16:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MslATtAAncYXPgPkjlnykY5cqwv0Q7VtsPwgQ+JNO/DgMIhUuWo4jL9wqzqkynWsGC+G+Zx7SMgHW8w78N7IuPGABCQiMGG+G+cuKiQfBtECf32F4CC5BGexNlPhqa7Qgu3UqJZg1jR24nmJb0tzi4GM92sm/yOnYCr8NCOs4FpVo+wQaPPHNWSvhr/gtVkMh4KoD9Zhqj8nwsVae3rYpZhY38GylI5d2j2h5FS+ZbKVtJJTbSOkhpsjRfLVuTCIhM/yV64WDKLNfre1qfa8rwu0rtfuGfmHWleZ/nUFtlssRrs43UAZlZ/rnhkVz6vxeVGjds1PTIrMIufV6h4W4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iGkjybI5VByqbeidd7/qtgmIbbeB6z6x8nQ1O7AZGZQ=; b=BW0RyHFjFpqe+6zQZLopaviRLr1gBWiMN28kT8ccC0l1xIOjOk5TPn5lF7yhwyguL1CxrCzSunI59Y2luQYpFX44plrtAwTR3j/NmYb80bLms1reJAFxYZ2uf6St+oo/LQ/5+ky3itdBuV2NhKNtUFJS3D4WGR6ojaWQsREiqzgl7kTOHW8tCg1KKvJMpVOcYxhOivw9bteu4ZiSzlKifE3Ua8XkXXRJlXvbJ8AwGxGu057GNGt0o6Zek8fKNTIJaP4lDbj0TgLzMqeLZ8ovxJ71fXl0WdRPzSWhvBBpfOjucvgg32Hh/LZXwFB/tHi/nv4FA7RI0jvA00JD6g9Bpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by DM6PR11MB3020.namprd11.prod.outlook.com (2603:10b6:5:69::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.19; Sun, 1 May 2022 02:16:21 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::6534:444c:a75d:4bf2]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::6534:444c:a75d:4bf2%9]) with mapi id 15.20.5186.028; Sun, 1 May 2022 02:16:20 +0000 From: "Xiang, Haihao" To: "anton@khirnov.net" , "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related code when MFX_VERSION < 2.0 Thread-Index: AQHYNSBkBvoiSbR4nEyekphDyYl7/6zhXE4AgAEI5wCAJpWKgIAAnd8A Date: Sun, 1 May 2022 02:16:20 +0000 Message-ID: <1d8c77d974f4efc794b02362bc21d557025abad8.camel@intel.com> References: <20220311081630.21927-1-haihao.xiang@intel.com> <20220311081630.21927-6-haihao.xiang@intel.com> <164915940053.21047.6940981970361137655@lain.red.khirnov.net> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ddb6d350-2d8e-4d2a-47eb-08da2b189531 x-ms-traffictypediagnostic: DM6PR11MB3020:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kItvz8hkT36hGZEu3XKhtJEG2aM9u7NlfufrENdT0BVyzXn42egtra8X4wIKxwA3c4B0+ixcR4mp0ekTSHLMLDlJtAsXMEGr0YXJZXX5g/NueRHM/Ha37KTmyJjsfs4O6ftt6eY8PK4FiAbafnq/nZf7Lyc9K9d1quP2GwvL3Tjo6C6qaEDXb9GICcllL+vmZB3fJAkD2LBnOUfwAT9nWXg49+qyy3RIGqXrde6pE7V9qgKoLIVUvbQzVe30OGayGziMoIanrKNUzg57bRadvzjqEaGo9t1j+A/+sUgZIUBBvamLsFBm4iWRNimPd64xgpxAmbCHBHJmSlue4OGSdYFz3+lM03OASRjlbRLdgoRH1dvF9r8tyTTWE4vwIDb13yThFPby1YGO8vBrbnXVeBBJHRXyMy09Ri4IMjyIQIExp5nXSWnwnlmwEiGSaDUsvqnKIXf/P9beaV7zWkujL8a31GHDZVUrlE08jVn7oMBSzgCbrXagT0XzU2bpiexgo+ryTRHLglWXuZI/4/YK68T3A5R5+bCnC9rzPf51GSooG/01iwRGemPZEA2u9BThnHbJWPzEz7RejveS/sXyrJ7YpS+n/Kin4HmSNrIWsel0YG0cN+XTRKB2xdUc/N0RGouyhqss1GcEQTayl/N8A2IY4jjYFAp/f54bJxiL3Va6rUCAwdWV1j6IsfA+v87imBDwZ4KAKTj3gOOe1BwEA45P6A416J9MN7zvMyRqquX/aa2VYn2nwn0JZCfpQ+fpbYdabECQOho69vP78rIWqk6ObbydkRfYShRhEm/nguKkyuQ6SAYBBcBoE1VPqOpsoUMsUsorxxgmupz7FFvlTqgnA04PO5OEfelbQDG7Q0k= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(110136005)(6506007)(53546011)(36756003)(186003)(26005)(316002)(86362001)(91956017)(122000001)(8936002)(966005)(6486002)(508600001)(76116006)(64756008)(66446008)(66946007)(66476007)(2616005)(66556008)(8676002)(38070700005)(2906002)(6512007)(5660300002)(71200400001)(82960400001)(83380400001)(38100700002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RDNjamJGMGVBa0FPeXJWY1hqQmp1ZEFxTzR5VmlORjFzMXBudmpDbnFFdExu?= =?utf-8?B?MGJYRWRwd0Z2eVQxZlk3MmpWZyt3aDY4ZTlTcEtjVEtOUDAwcVJsRW9HV2o5?= =?utf-8?B?Q1hxVGlFVFY5cEMrRk9reGdReU5SeE5SZUc4RHd5Z1dSQ1Erc3U1eFhEZDdZ?= =?utf-8?B?L1FvakdRQkZTV3VzV2h6OTlHR0UwcU0yanFCK1hMNkJ1dkpuVEoxK0oyb1RY?= =?utf-8?B?RGx1d215TlVHenpaS1p0ZlkvY2p3cFJJUE5HRHJUN0RkUHVPL3VzdWxibVZ5?= =?utf-8?B?SzlGTmdxZnlLVGkvTlZaaGpnd0xhQjUxcW5MUU5QWWlJaEpjWEZuOTFwWDJk?= =?utf-8?B?bGk1NmxLUlFKbndlUTJzcEkvOC9qWDZNMlBFMHJSY1REd0ZEVUdhaTU4MkVO?= =?utf-8?B?NnFTRmxhTnVmdzlRQ29scnBndm5PT3BLUTF6TnhKTTdTSGtETXRFZTRiRlMw?= =?utf-8?B?UzZLc08wOXgySmtCMVhXdjlzL0tZZVpsL0Y2Z1E4Tmdicm1KM0x0OTJCQ25h?= =?utf-8?B?RjRLZ0Z6OGN3bWhiaGNRUjJLMkx3akt6WnY1NG9USVBPSnB4eU1CUGRSVklv?= =?utf-8?B?RElPTGVZSlNJOFdCWlIyRzdSS29OMUNrZU1LL2MvcGx4bTZDVlk1dG40Y1Y4?= =?utf-8?B?TEN3dXVrWWFKVDVIbFBPaFk5SS9jK21qbitHLy85eks2bWQ2c1BQaXlLU05l?= =?utf-8?B?ZGluV3lMMWdUQWZOZC9HZW5JZUZpbk8zcmo1VytLM0J3TzlkbFhacG1HVTNM?= =?utf-8?B?VWpYdi9kNG9URjlFdU9MeUJYUXg3M2w1b0tPL0EzMEJCK0tPanhYcUdTSUh4?= =?utf-8?B?eGRNdlNuOUVNYXllYkQveUwxdEdOWmUxTTBRNHhKQ3FDQ1F2T1BTaVBJL1lz?= =?utf-8?B?TkxYT0dOaXFYa1Q3QVVjc0NlMERSRDVaeENqTnB2L2JVRVJFS1VROFNRWUow?= =?utf-8?B?TjJQTlN3eG8wWWpBQld4aGdYTHlnUkNhbVVrSGo4UXBkT0dDVWk2Q3g2Rkp0?= =?utf-8?B?clVocVlSTFR2ZzJoWjBMVUtjZE1Da0ZkdVo2aFUrVm9HaXlRcnd5eTZSazM4?= =?utf-8?B?c3BRVHNCRmsyRUx4c2pBaEpNMWR5WFNGTy9DTlNWMzNJdXpYS3ZyazhjMkg5?= =?utf-8?B?TklxRlZUTnc2K0ZRZFVuQXNBSHBjQzI3UmVlSFo3dmNsUmJNS3lTcTRpNmND?= =?utf-8?B?b0lvNXNRQ0JxN3d3UGZqSzBsQnk0VjdUbWlvNEpodUtmQUQ1K21nNGtvZXRJ?= =?utf-8?B?VjQvc0p6UkpPbFd2SHd5ZnE2b2N6ZHREYVpNanZXbDFnSHkySjliOTJoNzI2?= =?utf-8?B?bVpMOHpjeEE1YmUvV3hGcG1GbElyYldkM29vSVBmSW1KdUlLWVVBdXdTOFZP?= =?utf-8?B?RVBOYjh4QkRSS2o0QUpGdUpLOVBVOUxlZkk1M2xJaHJNM1gvSU1FRUhIaVFs?= =?utf-8?B?cytJUW4rQ2JtaFd3WGRCRmI3VWU2S1NpNnBpNi90dHRLSm9oK3ZwenNCRjhS?= =?utf-8?B?WkdJTkxRTDIyMXFRR050Vi9CUEFNOVI3UXR6V01zamFyWHFLT3lha2ZQQk0y?= =?utf-8?B?QmJyL0FiOUNNb0NaSEwvRTA5L1dpRjhXa05UZy9ETFdtWmRIamdHWWl0ZVEz?= =?utf-8?B?Snd5QWRabFdCd3pHR2o0eFlidGNmTlloLzFCVExXQkh5NmV1ZUIyRFg5Q3lD?= =?utf-8?B?d202aXhBdkdLMFNNRWhEYmxJVmI3RCtWamtCdUMrSXR0b2E3a29GYXZEZTBC?= =?utf-8?B?ZkQ4aUlzeHJzN1Q4azNJRFZ1UUl3OXNHWVdIMFRkRElmcitLd0N4blk5MEE1?= =?utf-8?B?TDRKRTkzODdMU0p3dmRaOGlGNWVQa0paak5iNkxleWlMb1NiVWtvT2RDcTNl?= =?utf-8?B?MGo4eFE2NUxjaENvYjhtNE5rRWlOZXhHWldrc1dMSGZUSVZvdlNkSkE5bFhk?= =?utf-8?B?Y2RzN3dCcnE4c1ZBcWV1eVpweG54emV4NzVpT0g3b0diL3BsOGxocms5aVBL?= =?utf-8?B?VzZGb1YvWklha2hCSVIyT2ZSNm1CM0RKRXZRVjlCUmtoUm1RemxIeHBuVUZS?= =?utf-8?B?Q2xnRjhaNzFnckdDMEVpS2J5S1hQZEFEMkRsYURoaUlYdGt6ZmdyaHdWa1I0?= =?utf-8?B?WWpLbnNNNWlscnFHUWlFRlcrYTliUlNITDRzaGw0WTN4dE1LMVRubkxlVFNG?= =?utf-8?B?RllHSlA2Z3FaZlRPbWlJU2ZERVRZKzhGRzZpWmxlQXlQSS9SdmplTGZXL3J1?= =?utf-8?B?WklMbHhpcnpWc0FlM3pxaHZvcUYxUVZDZkFVN200QmVzVFBwdUNBL2k5cFNL?= =?utf-8?B?eFZHQlhpU2pRSlYrNndHZjkzRjE2Y2prMnQ3L0RhUTM4TEZsNlJhWmdhd1Q2?= =?utf-8?Q?u040yargxDBzV+Zg=3D?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddb6d350-2d8e-4d2a-47eb-08da2b189531 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2022 02:16:20.8434 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VlFmPUMGFu37ZxWy2aqMcLvvXJEp2pxSzDYzdb32ikYOBpDSh3YTvcp6/bKrKqFwMrtMF3nNDCUYqGmYIrDXqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3020 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related code when MFX_VERSION < 2.0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 2022-04-30 at 16:51 +0000, Soft Works wrote: > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of > > Xiang, Haihao > > Sent: Wednesday, April 6, 2022 5:38 AM > > To: anton@khirnov.net; ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related > > code when MFX_VERSION < 2.0 > > > > On Tue, 2022-04-05 at 13:50 +0200, Anton Khirnov wrote: > > > Quoting Xiang, Haihao (2022-03-11 09:16:25) > > > > From: Haihao Xiang > > > > > > > > Audio isn't supported for MFX_VERSION >= 2.0[1][2]. This is in > > > > preparation for oneVPL support > > > > > > > > [1]: > > > > > > > > https://spec.oneapi.io/versions/latest/elements/oneVPL/source/VPL_inte > > l_media_sdk.html#msdk-full-name-feature-removals > > > > [2]: https://github.com/oneapi-src/oneVPL > > > > --- > > > > libavcodec/qsv.c | 5 +++++ > > > > libavfilter/qsvvpp.c | 6 ++++++ > > > > libavfilter/qsvvpp.h | 2 ++ > > > > 3 files changed, 13 insertions(+) > > > > > > Why not just remove this completely? > > > None of our QSV code does anything with audio. > > > > It was removed in an older version, however someone objected the > > removal of > > this. See > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200819061023.44330 > > 4-2-haihao.xiang@intel.com/ > > I think this was a misunderstanding. I see not objection. One was > just asking "why" and the other one had missed the point that audio > has never been functional. Please find the comment below in the original thread "This seems like a generic translation from the library errors to FF error codes. So even if we'll never touch the audio functionality of it, I'd prefer to have that struct complete already" So my understanding was that the reviewer preferred to keep the audio stuff unchanged for libmfx. > > I agree with Anton that the audio stuff should be removed > completely - ideally even beforehand in a separate patch. Actually I prefer to remove the audio stuff too. I may submit a separate patch if no more comments. Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".