From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 29B6946953 for ; Tue, 27 Jun 2023 22:59:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1DEE368C377; Wed, 28 Jun 2023 01:59:05 +0300 (EEST) Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4600F68BF1D for ; Wed, 28 Jun 2023 01:58:58 +0300 (EEST) Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-6b5d7e60015so4490636a34.0 for ; Tue, 27 Jun 2023 15:58:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687906736; x=1690498736; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FS1vRx00Wdp+YG3WcAe7kVEe+CkXfbajAjqAKtJwLZ0=; b=itqxgkU/sg/Hbn3cxyvpJQT07vm+Q/vX4oD4Qz6ZyWC+MldsicLJwHitvYtYYbYwbK H1lmAMAxYHVbCuvQ/t1B4FR7sSb925MKCNxBdgGlk/srjsBJ4ZLwe1MCsTujvPMGxi7n eztA4/uyq2kOVp+39u32xtV6kreOJEtZkhMObBDn3B0vB9KrNL9CCCetySW+/LCdLOnj EdQhMl6ka/K2r0oOQKEZn+P/T8+GZjaS7Dta78Ahi0BFi7ifN2wMihp7c6yqj/T1NSLL viqqLacfWrcAoR+6GLL7fwJcxnmbSUX5d0nGoqkZFezYKbyDnEq6Mly0hsR6I47zTnvl G4ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687906736; x=1690498736; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FS1vRx00Wdp+YG3WcAe7kVEe+CkXfbajAjqAKtJwLZ0=; b=S7iItRq2mIHTJ9W62dkhedjiVxHTt+Te4Ao9wqYJiWOHEo0xTlypWpq5oIqm8/mrkm qy3DBfKE4WFyH1xpuIyT6NpNGBxjSRsnEFciK831vM9wEpOFsKFNqJBDpDP+a8NWpkm6 ZTVFj+Cw9HWA1LIJFsVekAUba0V1xHyMYL/KJyHShGY66sC9LtSNzsegBfTCWgZW4Wic nMPD2CQg7E3aOkg86lqYb0T1bzxSJsGDg/JyvgzujGSrFB450EIPUDCSRn7QvNLG3Y20 hJaMVE5cqkaBeHzysQYhUzEuqwtZFdq+TBrk+F4k7Woik8nuunn2dvVz5Bl8+92+QcwN IeHA== X-Gm-Message-State: AC+VfDx4i7d1uzZ0aQ+zHwnKXUQGjoVRnMb1WCq2b9iqmXha9C/ua2hJ IPGopfare3yjKVqqPt/P5ou40Z9iUZ4= X-Google-Smtp-Source: ACHHUZ7xe5SCx8MayJE9XB64+0Is1GnOJjcWjIpBFdS30WekFl3UTtYPvj082DBJh76VwZofH9fvyw== X-Received: by 2002:a9d:7745:0:b0:6b4:4cff:8fed with SMTP id t5-20020a9d7745000000b006b44cff8fedmr32059155otl.28.1687906736143; Tue, 27 Jun 2023 15:58:56 -0700 (PDT) Received: from [192.168.0.12] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id e26-20020a9d731a000000b006b71fbba3a8sm4125118otk.10.2023.06.27.15.58.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jun 2023 15:58:55 -0700 (PDT) Message-ID: <1d674214-f2cc-7722-7867-0219eb404353@gmail.com> Date: Tue, 27 Jun 2023 19:58:56 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230626154922.66550-1-leo.izen@gmail.com> <20230626154922.66550-3-leo.izen@gmail.com> From: James Almer In-Reply-To: <20230626154922.66550-3-leo.izen@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v4 2/4] avcodec/jpegxl_parser: add JPEG XL parser X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/26/2023 12:49 PM, Leo Izen wrote: > +/* > + * copies as much of the codestream into the buffer as possible > + * pass a shorter buflen to request less > + * returns the number of bytes consumed from input, may be greater than input_len > + * if the input doesn't end on an ISOBMFF-box boundary > + */ > +int ff_jpegxl_collect_codestream_header(const uint8_t *input_buffer, int input_len, > + uint8_t *buffer, int buflen, int *copied) > +{ > + GetByteContext gb; > + int pos = 0; > + bytestream2_init(&gb, input_buffer, input_len); > + > + while (1) { > + uint64_t size; > + uint32_t tag; > + int head_size = 8; > + > + if (bytestream2_get_bytes_left(&gb) < 16) > + break; > + > + size = bytestream2_get_be32(&gb); > + if (size == 1) { > + size = bytestream2_get_be64(&gb); > + head_size = 16; > + } > + /* invalid ISOBMFF size */ > + if (size && size <= head_size) > + return AVERROR_INVALIDDATA; ISOBMFF? Are you propagating container bytes as if they were part of the bitstream from image2? Why is it not being handled by the mov/mp4 demuxer instead? > + if (ctx->meta.csp == JPEGXL_CS_GRAY) { > + if (ctx->meta.bit_depth <= 8) > + avctx->pix_fmt = s->format = ctx->meta.have_alpha ? AV_PIX_FMT_YA8 : AV_PIX_FMT_GRAY8; > + else if (ctx->meta.bit_depth <= 16) > + avctx->pix_fmt = s->format = ctx->meta.have_alpha ? AV_PIX_FMT_YA16 : AV_PIX_FMT_GRAY16; > + else > + avctx->pix_fmt = s->format = ctx->meta.have_alpha ? AV_PIX_FMT_NONE : AV_PIX_FMT_GRAYF32; > + } else { > + if (ctx->meta.bit_depth <= 8) > + avctx->pix_fmt = s->format = ctx->meta.have_alpha ? AV_PIX_FMT_RGBA : AV_PIX_FMT_RGB24; > + else if (ctx->meta.bit_depth <= 16) > + avctx->pix_fmt = s->format = ctx->meta.have_alpha ? AV_PIX_FMT_RGBA64 : AV_PIX_FMT_RGB48; > + else > + avctx->pix_fmt = s->format = ctx->meta.have_alpha ? AV_PIX_FMT_RGBAF32 : AV_PIX_FMT_RGBF32; Again, don't fill avctx->pix_fmt, fill s->format. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".