From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6A55341A68 for ; Sun, 19 Jun 2022 20:04:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6550068B528; Sun, 19 Jun 2022 23:04:01 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 17DD5680B8B for ; Sun, 19 Jun 2022 23:03:55 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 25JK3sfW018133-25JK3sfX018133 for ; Sun, 19 Jun 2022 23:03:54 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 73A30A142E for ; Sun, 19 Jun 2022 23:03:54 +0300 (EEST) Date: Sun, 19 Jun 2022 23:03:54 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20220620025702.7f040239c0de98c7492f6015@yahoo.com> Message-ID: <1d1a230-552a-926a-a78d-26a750ff282@martin.st> References: <997463531.2155665.1655649409798@yahoo.com> <20220620025702.7f040239c0de98c7492f6015@yahoo.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH] SDL2 verison for pkg_config fallback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 20 Jun 2022, dvhh wrote: > On Sun, 19 Jun 2022 17:46:58 +0200 > Timo Rothenpieler wrote: > >> On 17.06.2022 18:46, dvhh wrote: >>> pkg_config fallback for SDL2 use 2.1.0 as max (excluded) version >>> where the pkg_config specify 3.0.0 >>> Correcting fallback version to be in line with the pkg_config version >> >> Why? Any version the new versioning scheme will have a pkg-config file. > > I am cross-compiling for Windows aarch64 and noticed the discrepancy, pkg_config does not appear to be an option in that case. > > this is what I got from the log: > ------------------- > test_pkg_config sdl2 sdl2 >= 2.0.1 sdl2 < 3.0.0 SDL_events.h SDL_PollEvent > false --exists --print-errors sdl2 >= 2.0.1 sdl2 < 3.0.0 > ------------------- Instead of an aarch64-w64-mingw32-pkg-config, you can configure with --pkg-config=pkg-config, and set PKG_CONFIG_LIBDIR=. That said, this patch seems like a consistent followup to e5163b1d34381a3319214a902ef1df923dd2eeba - so either we apply this, or decide to scrap the non-pkgconfig fallback for this library. (Applying this patch in the meantime probably doesn't hurt, while deciding on whether pkg-config can be required here.) // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".