From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] SDL2 verison for pkg_config fallback
Date: Sun, 19 Jun 2022 23:03:54 +0300 (EEST)
Message-ID: <1d1a230-552a-926a-a78d-26a750ff282@martin.st> (raw)
In-Reply-To: <20220620025702.7f040239c0de98c7492f6015@yahoo.com>
On Mon, 20 Jun 2022, dvhh wrote:
> On Sun, 19 Jun 2022 17:46:58 +0200
> Timo Rothenpieler <timo@rothenpieler.org> wrote:
>
>> On 17.06.2022 18:46, dvhh wrote:
>>> pkg_config fallback for SDL2 use 2.1.0 as max (excluded) version
>>> where the pkg_config specify 3.0.0
>>> Correcting fallback version to be in line with the pkg_config version
>>
>> Why? Any version the new versioning scheme will have a pkg-config file.
>
> I am cross-compiling for Windows aarch64 and noticed the discrepancy, pkg_config does not appear to be an option in that case.
>
> this is what I got from the log:
> -------------------
> test_pkg_config sdl2 sdl2 >= 2.0.1 sdl2 < 3.0.0 SDL_events.h SDL_PollEvent
> false --exists --print-errors sdl2 >= 2.0.1 sdl2 < 3.0.0
> -------------------
Instead of an aarch64-w64-mingw32-pkg-config, you can configure with
--pkg-config=pkg-config, and set PKG_CONFIG_LIBDIR=<your/lib/pkgconfig>.
That said, this patch seems like a consistent followup to
e5163b1d34381a3319214a902ef1df923dd2eeba - so either we apply this, or
decide to scrap the non-pkgconfig fallback for this library. (Applying
this patch in the meantime probably doesn't hurt, while deciding on
whether pkg-config can be required here.)
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-06-19 20:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 16:46 dvhh
2022-06-19 15:46 ` Timo Rothenpieler
2022-06-19 17:57 ` dvhh
2022-06-19 20:03 ` Martin Storsjö [this message]
2022-07-09 19:35 ` Marton Balint
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d1a230-552a-926a-a78d-26a750ff282@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git