From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 78EBA48A8E
	for <ffmpegdev@gitmailbox.com>; Fri, 29 Dec 2023 12:16:37 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 884BC68CCCF;
	Fri, 29 Dec 2023 14:16:34 +0200 (EET)
Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BD72968C48A
 for <ffmpeg-devel@ffmpeg.org>; Fri, 29 Dec 2023 14:16:27 +0200 (EET)
Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21])
 by mail8.parnet.fi  with ESMTP id 3BTCGQwc027545-3BTCGQwd027545
 for <ffmpeg-devel@ffmpeg.org>; Fri, 29 Dec 2023 14:16:26 +0200
Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144])
 by mail9.parnet.fi (Postfix) with ESMTPS id 0BB95A146B
 for <ffmpeg-devel@ffmpeg.org>; Fri, 29 Dec 2023 14:16:25 +0200 (EET)
Date: Fri, 29 Dec 2023 14:16:24 +0200 (EET)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <CAEa-L+ujt036A2BVsgzTOMQcbLGpHw9HWnPSgfC8+GLV9rVjzg@mail.gmail.com>
Message-ID: <1ceb4dd3-542d-cc4d-5617-d94685324d9@martin.st>
References: <CAEa-L+ujt036A2BVsgzTOMQcbLGpHw9HWnPSgfC8+GLV9rVjzg@mail.gmail.com>
MIME-Version: 1.0
X-FE-Policy-ID: 3:14:2:SYSTEM
Subject: Re: [FFmpeg-devel] [PATCH 2/3] checkasm/svqenc: add
 ssd_int8_vs_int16 test
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/1ceb4dd3-542d-cc4d-5617-d94685324d9@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Fri, 29 Dec 2023, flow gg wrote:

> Tests on x86 might fail, possibly due to a 16-bit sub overflow

If this only happens in checkasm but not in real life use, it means that 
the checkasm test input is out of range, and we should try to mimic the 
real input data.

If the issue is off-by-one due to rounding, we could allow it by making a 
comparison per element, and tolerate a certain diff (maybe only on x86).

But if it is an actual overflow on valid input data, the x86 asm 
definitely needs to be fixed, by someone... Worst case, we might want to 
disable that checkasm test on x86 temporarily.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".