From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test
Date: Fri, 29 Dec 2023 14:16:24 +0200 (EET)
Message-ID: <1ceb4dd3-542d-cc4d-5617-d94685324d9@martin.st> (raw)
In-Reply-To: <CAEa-L+ujt036A2BVsgzTOMQcbLGpHw9HWnPSgfC8+GLV9rVjzg@mail.gmail.com>
On Fri, 29 Dec 2023, flow gg wrote:
> Tests on x86 might fail, possibly due to a 16-bit sub overflow
If this only happens in checkasm but not in real life use, it means that
the checkasm test input is out of range, and we should try to mimic the
real input data.
If the issue is off-by-one due to rounding, we could allow it by making a
comparison per element, and tolerate a certain diff (maybe only on x86).
But if it is an actual overflow on valid input data, the x86 asm
definitely needs to be fixed, by someone... Worst case, we might want to
disable that checkasm test on x86 temporarily.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-29 12:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 11:57 flow gg
2023-12-29 12:16 ` Martin Storsjö [this message]
2023-12-29 13:17 ` James Almer
2023-12-29 14:34 ` Martin Storsjö
2023-12-30 13:59 ` flow gg
2023-12-30 14:47 ` James Almer
2023-12-30 14:59 ` flow gg
2023-12-30 11:17 ` Rémi Denis-Courmont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ceb4dd3-542d-cc4d-5617-d94685324d9@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git