From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EDDB2488FA for ; Thu, 21 Dec 2023 09:48:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1B05468D05C; Thu, 21 Dec 2023 11:48:01 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A5FA168CDF6 for ; Thu, 21 Dec 2023 11:47:54 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 3BL9lrio017361-3BL9lrip017361; Thu, 21 Dec 2023 11:47:53 +0200 Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144]) by mail9.parnet.fi (Postfix) with ESMTPS id 6411AA146B; Thu, 21 Dec 2023 11:47:52 +0200 (EET) Date: Thu, 21 Dec 2023 11:47:51 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: ffmpeg-devel@ffmpeg.org In-Reply-To: <20231221094438.77841-1-martin@martin.st> Message-ID: <1cd9141a-8028-9c46-85c9-5fc249a1f441@martin.st> References: <20231221094438.77841-1-martin@martin.st> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] d3d12va: Add a missing include for the declaration of ff_d3d12va_get_surface_index X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Haihao Xiang Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-15"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 21 Dec 2023, Martin Storsj=F6 wrote: > This fixes the following build error: > > src/libavcodec/d3d12va_decode.c:49:10: error: no previous prototype for f= unction > 'ff_d3d12va_get_surface_index' [-Werror,-Wmissing-prototypes] > 49 | unsigned ff_d3d12va_get_surface_index(const AVCodecContext *avctx, > | ^ > --- > libavcodec/d3d12va_decode.c | 1 + > 1 file changed, 1 insertion(+) Even after this change, the build still fails on a later file: src/libavutil/hwcontext_d3d12va.c:74:13: error: no previous prototype for = function 'av_d3d12va_map_sw_to_hw_format' [-Werror,-Wmissing-prototypes] 74 | DXGI_FORMAT av_d3d12va_map_sw_to_hw_format(enum AVPixelFormat pix_= fmt) | ^ There's no declaration of this in any header - so please either make it = static or ff_ prefixed, or add it to a header with the declaration visible = at the function definition. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".