From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E1D4C490C8 for ; Fri, 2 Feb 2024 10:04:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F28F768D0F2; Fri, 2 Feb 2024 12:04:38 +0200 (EET) Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6B8CA68C7E6 for ; Fri, 2 Feb 2024 12:04:32 +0200 (EET) Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4TRBFn6kfBz9stD for ; Fri, 2 Feb 2024 11:04:29 +0100 (CET) Message-ID: <1c6d9c32-2deb-4c4b-872d-f9f4092a1400@gyani.pro> Date: Fri, 2 Feb 2024 15:34:27 +0530 MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org References: <20240129050007.1674-1-ffmpeg@gyani.pro> Content-Language: en-US From: Gyan Doshi In-Reply-To: <20240129050007.1674-1-ffmpeg@gyani.pro> Subject: Re: [FFmpeg-devel] [PATCH] avformat/wavenc: use strtoull for UMID conversion X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2024-01-29 10:30 am, Gyan Doshi wrote: > Existing use of strtoll can lead to ERANGE errors leading to incorrect > storage of UMID. Plan to push tomorrow. Regards, Gyan > --- > libavformat/wavenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/wavenc.c b/libavformat/wavenc.c > index 82acb9ef0f..a41f40b449 100644 > --- a/libavformat/wavenc.c > +++ b/libavformat/wavenc.c > @@ -129,7 +129,7 @@ static void bwf_write_bext_chunk(AVFormatContext *s) > > for (i = 0; i < len/16; i++) { > memcpy(umidpart_str, tmp_tag->value + 2 + (i*16), 16); > - umidpart = strtoll(umidpart_str, NULL, 16); > + umidpart = strtoull(umidpart_str, NULL, 16); > avio_wb64(s->pb, umidpart); > } > ffio_fill(s->pb, 0, 64 - i*8); _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".