From: Gyan Doshi <ffmpeg@gyani.pro>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avformat/wavenc: use strtoull for UMID conversion
Date: Fri, 2 Feb 2024 15:34:27 +0530
Message-ID: <1c6d9c32-2deb-4c4b-872d-f9f4092a1400@gyani.pro> (raw)
In-Reply-To: <20240129050007.1674-1-ffmpeg@gyani.pro>
On 2024-01-29 10:30 am, Gyan Doshi wrote:
> Existing use of strtoll can lead to ERANGE errors leading to incorrect
> storage of UMID.
Plan to push tomorrow.
Regards,
Gyan
> ---
> libavformat/wavenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/wavenc.c b/libavformat/wavenc.c
> index 82acb9ef0f..a41f40b449 100644
> --- a/libavformat/wavenc.c
> +++ b/libavformat/wavenc.c
> @@ -129,7 +129,7 @@ static void bwf_write_bext_chunk(AVFormatContext *s)
>
> for (i = 0; i < len/16; i++) {
> memcpy(umidpart_str, tmp_tag->value + 2 + (i*16), 16);
> - umidpart = strtoll(umidpart_str, NULL, 16);
> + umidpart = strtoull(umidpart_str, NULL, 16);
> avio_wb64(s->pb, umidpart);
> }
> ffio_fill(s->pb, 0, 64 - i*8);
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-02 10:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 5:00 Gyan Doshi
2024-02-02 10:04 ` Gyan Doshi [this message]
2024-02-04 9:17 ` Gyan Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c6d9c32-2deb-4c4b-872d-f9f4092a1400@gyani.pro \
--to=ffmpeg@gyani.pro \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git