From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 0F0A64D2CC for ; Sun, 16 Nov 2025 06:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1763276110; h=message-id : date : mime-version : to : references : in-reply-to : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=P7A80hRdEL9Bxkzr6zLMLEltb6s15l38/MbQsJd8tkA=; b=zk7GxlJreseSHQOmk2IoNkPcyJZ+/MJLXMfDPkXiPnWJ4MeZegKHDCl/fmf1sNLv2F+/r EimKlxJdAxep1P7fyedo51zKyDGLHiECUJZHPTZQfDnGr4o+KN6mg1WxDhMb4qvylCYTnnO qGiL+57zqiR2KUpRfnTEWWtuZADEuxaQDnewpO/rj05YSZZydXB9XfpI6yqy2ZgVInqfvlc RRDf+DG9P8VKYvD6GXS3RuEf0CAH9FOuJ/3/HsDLLpAbEayUK4F12MGDVo5+zK5PW/lH2Fq Pyz/Z48tXvc75hBqygQcz8rDW+oxbDQEj90fXh8MEk2TqEg7eDRB5FYAKIAw== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 5837868FE3C; Sun, 16 Nov 2025 08:55:10 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1763276082; b=ds79TcCRBdC+RG5judzPIQY9dwUXaTyIe/rWHJY/s6O5umZh8lKwdiRtnyOwLGD2pWMlE yQQEsjvk8pWpW3bSHckXw51ZRPl7azZq7hwl/i5C+ptes/CnkDcgDKocfSeKTGLtMVj2tRp ofihhA1PFVyUdCe/YdUonFLIk12DDoioX43G0abIqB9n97YG2b+6CDUm3mc6PeS9zBBhu/F qJmN0Nkhlv/cTd0yCblql1MvX3apblU+3yUxQP+BhVHg76hpiNQC45HbzRGAWNU8SQAOQjG QmqZxnzetNhX7n8mkVWj00NR4BhOoUzqCVRd9VzNjQYlnNnAOjZgRFQysfIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1763276082; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=xA0IyyyBuLuc5yG890owXduw4jGXjmhRw7xiTtZ3Ry4=; b=Hgmoqe8yc2+rJP0DJR5rRkJRgRFQvl/M47D1mkwTeJTRPCD3Rp/RdhKuaKRGz0EAdP64E 43qwNSb/sXxqtV24T+gvAZruTDu80WHegxu+UFiTFEoAGGd+jhCUIdxNgfG7sTPT71ikdHO Qlg65TjOjNfWDvPSiyRWYzdwKGBF+MHAv9NsbHp4d9eX47Zt8WmsiOIsPva5Dcg2GKZOUIv FxxviZQl0Ljby3t6Gumzdy+d+TbzVYrw8oMw0CSxaSFSLNRfMqLVkEuycdmmP/IQ9zkINeH Ahw1NQdFKCNffqe/R9cCn67kKMpUdImQKJEes+kbR94qKFleAVsQQqRSAxvQ== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=fail; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=fail; arc=none (Message is not ARC signed); dmarc=none Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 9BFD568E6B5 for ; Sun, 16 Nov 2025 08:54:27 +0200 (EET) Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4d8M7453C5z9swH for ; Sun, 16 Nov 2025 07:54:24 +0100 (CET) Message-ID: <1c3c051b-7ced-48c6-ae91-d35c8226ec91@gyani.pro> Date: Sun, 16 Nov 2025 12:24:22 +0530 MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org References: <20251115223242.90376-1-celebitolgakaan@gmail.com> Content-Language: en-US In-Reply-To: <20251115223242.90376-1-celebitolgakaan@gmail.com> Message-ID-Hash: 7LN6CN6N7QSYGHZWEOTEJDMLGJ6O6PWV X-Message-ID-Hash: 7LN6CN6N7QSYGHZWEOTEJDMLGJ6O6PWV X-MailFrom: SRS0=yYRt=5Y=gyani.pro=ffmpeg@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH] fftools/ffmpeg_mux_init: do not write encoder metadata for ogg files with bitexact List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Gyan Doshi via ffmpeg-devel Cc: Gyan Doshi Content-Type: text/plain; charset="us-ascii"; format="flowed" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: On 2025-11-16 04:02 am, Tolga Celebi via ffmpeg-devel wrote: > From: tolgakaan12 <70590077+tolgakaan12@users.noreply.github.com> > > The set_encoder_id function in fftools/ffmpeg_mux_init was writing a shortened encoder tag even when -bitexact flag was set, instead of omitting it entirely like other formats (flac, mp3, wav) do. This patch makes the function return early if bitexact flag is set, ensuring no encoder metadata is written. > > Fixes ticket #11656. NAK. Bitexact does not mean lack of encoder metadata - it means metadata that is invariant across versions. Most formats will still write some encoder metadata. This patch fails close to 200 of our automated tests - see https://patchwork.ffmpeg.org/project/ffmpeg/patch/20251115223242.90376-1-celebitolgakaan@gmail.com/ To omit this for a particular muxer, modify that muxer by checking for the flag AVFMT_FLAG_BITEXACT. Look at libavformat/wavenc.c for reference. Regards, Gyan > --- > fftools/ffmpeg_mux_init.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c > index bcbbee9126..3d13c9c257 100644 > --- a/fftools/ffmpeg_mux_init.c > +++ b/fftools/ffmpeg_mux_init.c > @@ -1167,15 +1167,15 @@ static int set_encoder_id(OutputStream *ost, const AVCodec *codec) > uint8_t *encoder_string; > int encoder_string_len; > > + if (ost->file->bitexact || ost->bitexact) > + return 0; > + > encoder_string_len = sizeof(LIBAVCODEC_IDENT) + strlen(cname) + 2; > encoder_string = av_mallocz(encoder_string_len); > if (!encoder_string) > return AVERROR(ENOMEM); > > - if (!ost->file->bitexact && !ost->bitexact) > - av_strlcpy(encoder_string, LIBAVCODEC_IDENT " ", encoder_string_len); > - else > - av_strlcpy(encoder_string, "Lavc ", encoder_string_len); > + av_strlcpy(encoder_string, LIBAVCODEC_IDENT " ", encoder_string_len); > av_strlcat(encoder_string, cname, encoder_string_len); > av_dict_set(&ost->st->metadata, "encoder", encoder_string, > AV_DICT_DONT_STRDUP_VAL | AV_DICT_DONT_OVERWRITE); _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org