From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3EBE047FD3 for ; Tue, 7 Nov 2023 20:52:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5B3DE68CBFA; Tue, 7 Nov 2023 22:52:06 +0200 (EET) Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2CA7B68C9DB for ; Tue, 7 Nov 2023 22:52:00 +0200 (EET) Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-6ce532451c7so3244156a34.2 for ; Tue, 07 Nov 2023 12:52:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699390317; x=1699995117; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=tocAMyr9GBUXKKsnrxsFv4rkuVcRcuveduOf1F5EvZ8=; b=mVvuGmJ7JjmEarPa9iSguHdjxdqcwEOw9SbHaojiV2xF7mkP/6fPLSrRhN9cRrnI02 fLL1RcgM2NFzx7ybXt+WkgRi1eCfZyS9ypaGITycEGw4z2Y9sgOke+Af6O4EBJ9eU/db T+nUvpqlEQpg9vfXhMfyhcJ1hVZ/KmyKLphgE8o2kJJNKKUMtHWYT3SmPRN8vMIXny/5 7ayVsJLk051xLwUdZglej+dKwYHwWUWXD52+x60zTvXaWvm292nbnJ5BU2EZVQieBe4+ 5pK3Ny5q+EG+aseTRapbWiAOgMqvaAaKaxb4oP9ns2fBtN+WL9ifPYk5rwHk9/xpC2Y9 Cpcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699390317; x=1699995117; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tocAMyr9GBUXKKsnrxsFv4rkuVcRcuveduOf1F5EvZ8=; b=E2bhA9doTkPkAHiiuvXIrlqbgD6mlMknGJ2KCSyNMDe76kysxx0XPfIMyaMkWbYISD n9LzcfitfccnZVel1yswv8AGp+WcsTqbe0a4gaQEx3wdT9uszD2jWnS6Y4Eb56MBLKVC 1nLOfCIFx7eUr1O7irholuFrJVUBiw2VMU9tHv3l5ElISkJlt+K4g72iOOWppcX8PmPt +WUjbsJye2sEhiP5Oyp6cqhuXJnje1PLo4SqO1qJMGL3nWIkcQlmCHsvhGJxuO0A+v1S VSeRs/Jk5xHqN6oMFDc+DoPWMwMCkpLcOkTWJH5aZqWeo6dAo89vX1hZiDKyKfXrt52A 1pig== X-Gm-Message-State: AOJu0Yy7RWbkaPjFvQWAEaTSwD/IFGuy/3aFe6BSgXM9fIhIucOA+JWf otzKogUR5St5NCvlgk2iKKputDqtRiI= X-Google-Smtp-Source: AGHT+IHyFYReTQj7YjH/mPqMzpSjbli39G9nYZwURwNyL7EHdfEsLNiXN4GpkmpiTOaG+YQwiGL4zA== X-Received: by 2002:aca:240c:0:b0:3b2:ec6d:e16d with SMTP id n12-20020aca240c000000b003b2ec6de16dmr130273oic.34.1699390317468; Tue, 07 Nov 2023 12:51:57 -0800 (PST) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id bl1-20020a05620a1a8100b007776c520488sm281786qkb.9.2023.11.07.12.51.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Nov 2023 12:51:57 -0800 (PST) Message-ID: <1bde9816-c3e1-411e-8916-c582581f0414@gmail.com> Date: Tue, 7 Nov 2023 17:52:11 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20231107125835.25827-1-anton@khirnov.net> <20231107125835.25827-4-anton@khirnov.net> Content-Language: en-US From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: <20231107125835.25827-4-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 4/4] lavu/log: do not assume AVClass.item_name is always set X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/7/2023 9:58 AM, Anton Khirnov wrote: > --- > libavutil/log.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/libavutil/log.c b/libavutil/log.c > index 2d358b7ab9..46662f3db0 100644 > --- a/libavutil/log.c > +++ b/libavutil/log.c > @@ -291,6 +291,11 @@ static const char *get_level_str(int level) > } > } > > +static const char *item_name(void *obj, const AVClass *cls) > +{ > + return (cls->item_name ? cls->item_name : av_default_item_name)(obj); > +} > + > static void format_line(void *avcl, int level, const char *fmt, va_list vl, > AVBPrint part[4], int *print_prefix, int type[2]) > { > @@ -307,12 +312,12 @@ static void format_line(void *avcl, int level, const char *fmt, va_list vl, > avc->parent_log_context_offset); > if (parent && *parent) { > av_bprintf(part+0, "[%s @ %p] ", > - (*parent)->item_name(parent), parent); > + item_name(parent, *parent), parent); > if(type) type[0] = get_category(parent); > } > } > av_bprintf(part+1, "[%s @ %p] ", > - avc->item_name(avcl), avcl); > + item_name(avcl, avc), avcl); > if(type) type[1] = get_category(avcl); > } If this lets us define an AVClass without having to add the item_name = av_default_item_name line, then +1. Btw, there's also .version that's always set to LIBAVUTIL_VERSION_INT, but that can't be changed as they are compile time constants. What can probably be dropped however are the checks in log.c for runtime major version 50 and 51. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".