Re: [FFmpeg-devel] [PATCH 6/7] avcodec/internal.h: Move avpriv_find_start_code() to startcode.h

[Scott Theisen <scott.the.elm@gmail.com>]

On 2/4/22 10:16, Andreas Rheinhardt wrote:
> This is by definition the appropriate place for it.
> Remove all the now unnecessary libavcodec/internal.h inclusions;
> also remove other unnecessary headers from the affected files.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---

>
> diff --git a/libavcodec/utils.c b/libavcodec/utils.c
> index b19befef21..c7c7323351 100644
> --- a/libavcodec/utils.c
> +++ b/libavcodec/utils.c
> @@ -27,7 +27,6 @@
>   
>   #include "config.h"
>   #include "libavutil/avassert.h"
> -#include "libavutil/avstring.h"
>   #include "libavutil/channel_layout.h"
>   #include "libavutil/intreadwrite.h"
>   #include "libavutil/mem.h"
> @@ -40,12 +39,9 @@
>   #include "thread.h"
>   #include "internal.h"
>   #include "put_bits.h"
> -#include "raw.h"
> +#include "startcode.h"
>   #include <stdlib.h>
> -#include <stdarg.h>
> -#include <stdatomic.h>
>   #include <limits.h>
> -#include <float.h>
>   
>   void av_fast_padded_malloc(void *ptr, unsigned int *size, size_t min_size)
>   {

Shouldn't you also move the definition to startcode.c as well? Then 
utils.c doesn't need startcode.h.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".