From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BBAC1408A3 for ; Thu, 3 Mar 2022 13:59:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7A22068B00F; Thu, 3 Mar 2022 15:59:02 +0200 (EET) Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A27A868A22C for ; Thu, 3 Mar 2022 15:58:56 +0200 (EET) Received: by mail-oo1-f54.google.com with SMTP id i6-20020a4ac506000000b0031c5ac6c078so5834045ooq.6 for ; Thu, 03 Mar 2022 05:58:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=+kQW050ruEDLmDUkCe9N207BzU5GC2xKSjsYWKqfWbo=; b=VEz62fqSrpAgEbf2yjuMfT+DBoyQEQs5FKmZiZsTocm3YaW7zaXILdyQEr9GR+wNw0 TvKNzeqwsYC97y2zAeTnGf39YlceETXE8JlVsr+XrFBVnNMRSAjK7G4DmRVzbKA6D3WN p47a7UYD5II18+ATgZcXev9/fIVh/UWBAELREAio7x2tEXEVJYsnfFydWpfKEeb8nK8O DLJ8yLdf2b5ERYe6Is0BkX1KD1fyVorFrpJ796Uo7Rt86fjwVkhNJCr9LYp7DsJkRvsd PaL0XS8nygwx/1CUleajdMQWYc7ERFWOd9sY5A+jNI0RNZL1mz0MGJd1SxLDV5r/Ar3T WzqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=+kQW050ruEDLmDUkCe9N207BzU5GC2xKSjsYWKqfWbo=; b=m98DXyvyF6tmaLSNHBDMAaO3uLUtsiIxFd4Xp3CK1/jsDt2n/flOIExW0yS3li+8Oq SABLCQKqzYk9h+As8fJzD44aoZr9Vy1uiaSfUv9Hdps9hivSmyhJc5VOSfPjy1hRtP2K UekEfEkAbGrrWHTxe0qGFXpaSSUqz1Rdm+96j9vBZ9LKiHKC7F7iEBppfDmzImCY3ESE jx83NNROp5PJAZ7HvdYv2hxEx97OKwo2xeX86rm7jeK6zrvGC08hdPVIdSQm1t9CjK/x hgW29gBIxY/edhNUp81Kyslt8kAuS257Osj2IzLZwWNG8+S9S64xfbtlKfXjDRjArXbp AKEQ== X-Gm-Message-State: AOAM531piom7Tsl4gGeRZWm5aX/r3T751k0Ag+FkDoXP2V7jqaNv9NOy 5iN55K26rs+zmItwdGJalJ2NLwjmbw4= X-Google-Smtp-Source: ABdhPJyQhOVu0BzPTx59KPlXOVuhRuOpqLtgc6zPmdZDLOvwPjH1cKH3de9DX68dV/9vKdjmqAdsYg== X-Received: by 2002:a05:6870:2396:b0:d4:30d1:d5c with SMTP id e22-20020a056870239600b000d430d10d5cmr4093121oap.51.1646315934638; Thu, 03 Mar 2022 05:58:54 -0800 (PST) Received: from [192.168.0.10] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id j25-20020a4ad199000000b003171dfeb5bfsm942568oor.15.2022.03.03.05.58.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Mar 2022 05:58:54 -0800 (PST) Message-ID: <1ab7f4c6-ee52-385d-4f81-c28dbb007943@gmail.com> Date: Thu, 3 Mar 2022 10:58:51 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220301142310.16367-1-jamrial@gmail.com> <1e6e3de9-b08f-6613-ae14-77914b8b8e39@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avfilter/framepool: use av_image_fill_plane_sizes() to calculate pool sizes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/3/2022 10:56 AM, Paul B Mahol wrote: > On 3/3/22, James Almer wrote: >> >> >> On 3/1/2022 11:23 AM, James Almer wrote: >>> Signed-off-by: James Almer >>> --- >>> libavfilter/framepool.c | 20 ++++++++++++++------ >>> 1 file changed, 14 insertions(+), 6 deletions(-) >>> >>> diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c >>> index 5b510c9af9..cf6a1d0ea0 100644 >>> --- a/libavfilter/framepool.c >>> +++ b/libavfilter/framepool.c >>> @@ -57,6 +57,8 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef* >>> (*alloc)(size_t size), >>> int i, ret; >>> FFFramePool *pool; >>> const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(format); >>> + ptrdiff_t linesizes[4]; >>> + size_t sizes[4]; >>> >>> if (!desc) >>> return NULL; >>> @@ -89,13 +91,19 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef* >>> (*alloc)(size_t size), >>> } >>> } >>> >>> - for (i = 0; i < 4 && pool->linesize[i]; i++) { >>> - int h = pool->height; >>> - if (i == 1 || i == 2) >>> - h = AV_CEIL_RSHIFT(h, desc->log2_chroma_h); >>> + for (i = 0; i < 4; i++) >>> + linesizes[i] = pool->linesize[i]; >>> >>> - pool->pools[i] = av_buffer_pool_init(pool->linesize[i] * h + >>> align, >>> - alloc); >>> + if (av_image_fill_plane_sizes(sizes, pool->format, >>> + FFALIGN(pool->height, align), >>> + linesizes) < 0) { >>> + goto fail; >>> + } >>> + >>> + for (i = 0; i < 4 && sizes[i]; i++) { >>> + if (sizes[i] > SIZE_MAX - align) >>> + goto fail; >>> + pool->pools[i] = av_buffer_pool_init(sizes[i] + align, alloc); >>> if (!pool->pools[i]) >>> goto fail; >>> } >> >> Ping. I can also remove the height padding if preferred. > > It does not work. No? It doesn't fix the mpeg encoder issue with yuv422p streams and 64 stride alignment, no, but it's not strictly about that either. It's a simplification using existing helpers. > >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".