From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 79738430FE for ; Mon, 20 Jun 2022 09:09:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3381168B63D; Mon, 20 Jun 2022 12:09:51 +0300 (EEST) Received: from shout01.mail.de (shout01.mail.de [62.201.172.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B0D7C68B611 for ; Mon, 20 Jun 2022 12:09:44 +0300 (EEST) Received: from postfix01.mail.de (postfix01.bt.mail.de [10.0.121.125]) by shout01.mail.de (Postfix) with ESMTP id 59DC8A07F7 for ; Mon, 20 Jun 2022 11:09:44 +0200 (CEST) Received: from smtp04.mail.de (smtp04.bt.mail.de [10.0.121.214]) by postfix01.mail.de (Postfix) with ESMTP id 41E758015B for ; Mon, 20 Jun 2022 11:09:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mail.de; s=mailde202009; t=1655716184; bh=8nXKFkA9yTNME0CkaLfldbvGXXRJJ9ZBvSR0JckDtkA=; h=Message-ID:Date:Subject:To:From:From:To:CC:Subject:Reply-To; b=JIO7UlMDXzzy0x9pur2bH3XTOODu8GtXTAFfda42sTJcObq5Lzm6VLinaH24/7juI ukqPX8k8YGIxlhKXeUWT7uPLTayxwU0ja2dmL535tYO0Un1HhDHG/K8AroPD9GWYeT ivMacxJ/KraxFuaVBVGixnyriIQHs0kwR5pNdY4RIKr70l3zeGo19mdWefDF2Euxj/ Chv+4SRiABKJpHpmR7gsf2mqtdo6CH3tQc9Vf+4NSkTQzXz+fmRUoJ9Qjn1XxKjU/e VImjd5uNZZh2IRFqmYyarJ/WKe60SN568aBA+Scpv/JYI6QqmexcXgDFj76ei4WPWR Y6f4x1Ef2LMZw== Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtp04.mail.de (Postfix) with ESMTPSA id 09674C2344 for ; Mon, 20 Jun 2022 11:09:43 +0200 (CEST) Message-ID: <1a27e2c8-5f1f-5097-9b53-ccb23f868fbf@mail.de> Date: Mon, 20 Jun 2022 11:09:43 +0200 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <23aa6fad-bd13-6aeb-cc27-8b2bd3497b8d@mail.de> <20220616200110.GQ396728@pb2> From: Thilo Borgmann In-Reply-To: <20220616200110.GQ396728@pb2> X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate: clean X-purgate-size: 943 X-purgate-ID: 154282::1655716184-000016C9-0A440C6F/0/0 Subject: Re: [FFmpeg-devel] [PATCH] lavc/libx264.c: Fix possible UB by NULL pointer LHS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Am 16.06.22 um 22:01 schrieb Michael Niedermayer: > On Thu, Jun 16, 2022 at 05:58:09PM +0200, Thilo Borgmann wrote: >> Hi, >> >> the LHS pointer might be NULL so that += would be UB. >> >> Thanks, >> Thilo > >> libx264.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> 558de1ca7a30aa728193297a7d605c051b5bbfc0 0001-lavc-libx264.c-Fix-possible-UB-by-NULL-pointer-LHS.patch >> From cfb7ce8092c34436fae3120645aa96fe082af4ea Mon Sep 17 00:00:00 2001 >> From: Michael Goulet >> Date: Thu, 16 Jun 2022 17:52:56 +0200 >> Subject: [PATCH] lavc/libx264.c: Fix possible UB by NULL pointer LHS >> >> It is UB to attempt to do pointer arithmetic on NULL pointer LHS, even if that pointer arithmetic ends up being "+= 0" (i.e. !!p == 0 if p == NULL). >> --- >> libavcodec/libx264.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) > > should be ok Pushed, thanks! -Thilo _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".