From: Thilo Borgmann <thilo.borgmann@mail.de>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] lavc/libx264.c: Fix possible UB by NULL pointer LHS
Date: Mon, 20 Jun 2022 11:09:43 +0200
Message-ID: <1a27e2c8-5f1f-5097-9b53-ccb23f868fbf@mail.de> (raw)
In-Reply-To: <20220616200110.GQ396728@pb2>
Am 16.06.22 um 22:01 schrieb Michael Niedermayer:
> On Thu, Jun 16, 2022 at 05:58:09PM +0200, Thilo Borgmann wrote:
>> Hi,
>>
>> the LHS pointer might be NULL so that += would be UB.
>>
>> Thanks,
>> Thilo
>
>> libx264.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>> 558de1ca7a30aa728193297a7d605c051b5bbfc0 0001-lavc-libx264.c-Fix-possible-UB-by-NULL-pointer-LHS.patch
>> From cfb7ce8092c34436fae3120645aa96fe082af4ea Mon Sep 17 00:00:00 2001
>> From: Michael Goulet <mgoulet@fb.com>
>> Date: Thu, 16 Jun 2022 17:52:56 +0200
>> Subject: [PATCH] lavc/libx264.c: Fix possible UB by NULL pointer LHS
>>
>> It is UB to attempt to do pointer arithmetic on NULL pointer LHS, even if that pointer arithmetic ends up being "+= 0" (i.e. !!p == 0 if p == NULL).
>> ---
>> libavcodec/libx264.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> should be ok
Pushed, thanks!
-Thilo
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-06-20 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 15:58 Thilo Borgmann
2022-06-16 20:01 ` Michael Niedermayer
2022-06-20 9:09 ` Thilo Borgmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a27e2c8-5f1f-5097-9b53-ccb23f868fbf@mail.de \
--to=thilo.borgmann@mail.de \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git