From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id A6CDF4C7B6 for ; Fri, 9 May 2025 11:57:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 39C7168C41E; Fri, 9 May 2025 14:57:34 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2C21568BFAC for ; Fri, 9 May 2025 14:57:28 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id A90A3EBD81 for ; Fri, 9 May 2025 13:54:52 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cFIZlnUIilPv for ; Fri, 9 May 2025 13:54:22 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 5D212EBD52 for ; Fri, 9 May 2025 13:54:22 +0200 (CEST) Date: Fri, 9 May 2025 13:54:22 +0200 (CEST) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <20250509092108.GP29660@pb2> Message-ID: <1a1435b6-04d1-75de-47ae-f38fd23f0964@passwd.hu> References: <20250508222805.26361-1-cus@passwd.hu> <20250509092108.GP29660@pb2> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avformat/wavdec: increase requested probe score for codec probe X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 9 May 2025, Michael Niedermayer wrote: > On Fri, May 09, 2025 at 12:28:00AM +0200, Marton Balint wrote: >> Codec probing was primarily added to the wav demuxer to support DTS-in-wav >> files, but DTS probing functions return AVPROBE_SCORE_EXTENSION+1, so we can be >> a bit more strict with the required score. >> >> This fixes MP3 misdetections for some wav files. >> >> Fixes ticket #11581. >> >> Signed-off-by: Marton Balint >> --- >> libavformat/wavdec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c >> index dc7e49abc4..c65e0a2723 100644 >> --- a/libavformat/wavdec.c >> +++ b/libavformat/wavdec.c >> @@ -178,7 +178,7 @@ static void handle_stream_probing(AVStream *st) >> { >> if (st->codecpar->codec_id == AV_CODEC_ID_PCM_S16LE) { >> FFStream *const sti = ffstream(st); >> - sti->request_probe = AVPROBE_SCORE_EXTENSION; >> + sti->request_probe = AVPROBE_SCORE_EXTENSION + 1; >> sti->probe_packets = FFMIN(sti->probe_packets, 32); >> } >> } > > please add a testcase to fate, if possible. Such corner cases > are important to be in fate Sample is in the ticket, so it should be pretty trivial to do so. Can't we fund someone to do this and the other fixed trac tickets without fate tests? Thanks, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".