[FFmpeg-devel] Re: [PATCH] lavf/whip: improve RTP muxer error message

[Jack Lau via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

Hi,
> On Jan 23, 2026, at 14:31, Devraj Ajmera via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
> 
> Hi Timo,
> 
> Thanks for the insightful comment.
> 
> You are right that if WHIP hard-depends on RTP, this might be better
> handled at configure time rather than at runtime. The intent of this
> patch was limited to improving the clarity of the existing error path,
> without changing behavior.

configure already deps the rtp_muxer via whip_muxer_select, so it should never hit this error.

So maybe use av_unreachable() to replace current error handling?
> 
> I agree this deserves a closer look. Would you prefer addressing this
> by tightening the configure dependencies for the WHIP muxer, or by
> adjusting the error handling (e.g. AVERROR_BUG) in this code path?
> 
> Thanks,
> Devraj
> 
> On Fri, Jan 23, 2026 at 11:42 AM Devraj Ajmera <devrajajmera077@gmail.com>
> wrote:
> 
>> Hi Jack,
>> 
>> Thanks for the review.
>> 
>> You are right, the "WHIP:" prefix is unnecessary since av_log already has
>> context.
>> I have updated the patch accordingly and sent a revised version.
>> 
>> Regards,
>> Devraj Ajmera
>> 
>> On Tue, Jan 20, 2026 at 5:15 PM Devraj Ajmera <devrajajmera077@gmail.com>
>> wrote:
>> 
>>> Hello,
>>> 
>>> This patch improves the error message shown when the RTP muxer
>>> cannot be guessed in the WHIP muxer, making the failure reason
>>> clearer to users.
>>> 
>>> Regards,
>>> Devraj Ajmera
>>> 
>> 
> _______________________________________________
> ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
> To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

BTW, top-posting isn’t acceptable in this mail list.

Best,
Jack

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org