From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id ABB8A4DA3B for ; Thu, 27 Feb 2025 23:25:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B793C68DC71; Fri, 28 Feb 2025 01:25:53 +0200 (EET) Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7F07F68C216 for ; Fri, 28 Feb 2025 01:25:47 +0200 (EET) Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5e04861e7a6so2403014a12.1 for ; Thu, 27 Feb 2025 15:25:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740698747; x=1741303547; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=cG4sQaATv7NKw6p4g+/jwXU3XY7LGOZsQYIxz27mmkE=; b=lS3+FDA4rHKM3YKfw+i6GfQxqXEE9zSGJmXCKhJ0oNtr9MpBTciQuvwalKqKEjkzC1 iQqieegzl6+NC8J5l5YwKXWq4UafdkTp57MiTk4v1HQYQASQcARcGBWcWU+SVB3TxgK+ bUgHEg0JCWlo/3LX+BQuWJL4ck4ws20MY+JMQ7V40phj+MoGQJYfdNQ6k8TbjtFoQNSa OjvKoybtYKHIWi3wzxYBM8uc9qV8kWTYvXPYLIZPK1kUYSIHPnxUP/9XSdEI8MfGjkvc PkILuovBd5nihgBh21cQtgcJMbzBETTDiKKxHOLLpL7FifcUSa5/bSiLeUWqvpGmUYHl ILFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740698747; x=1741303547; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cG4sQaATv7NKw6p4g+/jwXU3XY7LGOZsQYIxz27mmkE=; b=qaQ53A553shznvJ4U8PTQvNa/ofBSYWofwsVCyJWFYLsPprJ6c2tNHW7ce6nBUcISP 29RkfPW78JkLWi6JLEXtgmiaU8cRaX6jIc1ga7lw5YlhS58si/pcguz17ewU7R30xy9j 32SoiYxQxDeri047djISD3+dGvn/hXOYnUJAUYMx5wi4nRko1cU29M7KEpiiA4MzThUO 5l87F2ljc4aPuTu6+Ncy59yFN1F6QHuRCSB40L3R7GlAasPPVCvfSYlgbGN4wTSgpdON rPxcRqbQBLuDRgVCrYLH7ZoqL5HZQZuuMd38Apst8ocBzDS9RbEKqJkCpcHTU6duCSW9 OEKw== X-Gm-Message-State: AOJu0YxNuKSCLQ8e+NCnakfft6w8m+bOjf96QnrxhBFlf2w9/ZXBbTpm F5SIgyJBK+5Cv7zW2TrqHw0WIhpoLqHGiQyR+7mkdfNhL/HBMCXWNf6avA== X-Gm-Gg: ASbGncuCJH+5LY8g6q96amaKRAIzRo2zs9Hq95CEWjUPI/fceLaLkoQ3NeTkz2KR+6F hG7ZzplY55HO5AUGoj+uvT+pZjdsRcprrX6aN6GHwdZtkow1btKWYojWRM4SSl0OPLRmK/R4czR dRm3dzQIJlE2nxcka5Xz7MtTpveBioAuUERxwfTvq/QqBIQmBdb+ZSFBp5Kb9t/mFSJN2CW6n6Q kd0OZ6FbPFBr7/XbLTWvX+Y/gaCziPT0OlQ7NQhucx5fHrEL+GAbmLfKXpaXRfRAn7NfBD4NvTP g4a/RHS2JK57I+Vut7pO+J3x5UVMatHN3YVwzqQJ9rdJzMOYhH60imxNXBhEDe1rqrs5SOFiqxV TwS5RnVJGmFSXwbvA4saZUZE0Cd2vbfnR/DqnuQ== X-Google-Smtp-Source: AGHT+IG0jJKYXqkRdFKSXW/EvQFFQWyOCnxoo9OOWP9lQWkWMBMdDbXYqI8/Ee+9O4C03Aq1fGUckg== X-Received: by 2002:a17:907:3fa4:b0:ab7:e451:4834 with SMTP id a640c23a62f3a-abf25fb8fcbmr121769366b.19.1740698746595; Thu, 27 Feb 2025 15:25:46 -0800 (PST) Received: from [192.168.178.30] (p200300cccf2325007c1a3f45643ab39a.dip0.t-ipconnect.de. [2003:cc:cf23:2500:7c1a:3f45:643a:b39a]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf0c0dd6ccsm196091266b.57.2025.02.27.15.25.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Feb 2025 15:25:44 -0800 (PST) From: epirat07@gmail.com To: FFmpeg development discussions and patches Date: Fri, 28 Feb 2025 00:25:43 +0100 X-Mailer: MailMate (1.14r6065) Message-ID: <1F96354D-B189-4A6D-82FD-81DD1C0016B1@gmail.com> In-Reply-To: <20250227231432.GL4991@pb2> References: <20250227011054.3028508-1-michael@niedermayer.cc> <6D690464-DE4D-44B1-B851-44C855005FE7@gmail.com> <20250227231432.GL4991@pb2> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] doc/developer: Better {} style rule X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 28 Feb 2025, at 0:14, Michael Niedermayer wrote: > Hi > > On Thu, Feb 27, 2025 at 11:46:54PM +0100, epirat07@gmail.com wrote: >> On 27 Feb 2025, at 2:10, Michael Niedermayer wrote: >> >>> Signed-off-by: Michael Niedermayer >>> --- >>> doc/developer.texi | 11 +++++------ >>> 1 file changed, 5 insertions(+), 6 deletions(-) >>> >>> diff --git a/doc/developer.texi b/doc/developer.texi >>> index a1bfe180c9b..6a753f99da6 100644 >>> --- a/doc/developer.texi >>> +++ b/doc/developer.texi >>> @@ -179,18 +179,17 @@ int fields = ilace ? 2 : 1; >>> @end example >>> >>> @item >>> -No braces around single-line blocks: >>> +No braces around single-line blocks, unless they are followed by an else (to keep future patches cleaner) >>> >> >> I agree with this, however people in the past pointed it out when new code did this, IIRC. > > yes, i know, ive seen it in both directions for this one. > > >> >> So if we merge this, people should stop flagging this in reviews, else its frustrating >> for new contributors following the documentation and then getting contradicting reviews. > > I think as long as its in a style guide, the author of a patch can easily > point the reviewer to the guide and that should resolve it immedeatly > > will apply > Sounds good. Can you maybe check the styling issue at some point? I had updated the CSS and locally I get the right classes assigned to the codeblocks and the CSS styling them to hint which of them are good and which bad examples. But on the website deployed version its not working. Thanks, Marvin Scholz > thx > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > He who knows, does not speak. He who speaks, does not know. -- Lao Tsu > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".