Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] x86/scale_avx2: Change asm indent from 2 to 4 spaces.
Date: Thu, 16 Dec 2021 13:43:03 -0300
Message-ID: <19e1f04c-f223-0cd6-75b9-ebf8fe8d4553@gmail.com> (raw)
In-Reply-To: <20211216162710.2181015-1-alankelly@google.com>



On 12/16/2021 1:27 PM, Alan Kelly wrote:
> ---
>   libswscale/x86/scale_avx2.asm | 96 +++++++++++++++++------------------
>   1 file changed, 48 insertions(+), 48 deletions(-)
> 
> diff --git a/libswscale/x86/scale_avx2.asm b/libswscale/x86/scale_avx2.asm
> index 2cd7e968d3..eb472db12f 100644
> --- a/libswscale/x86/scale_avx2.asm
> +++ b/libswscale/x86/scale_avx2.asm
> @@ -45,63 +45,63 @@ SECTION .text
>   
>   %macro SCALE_FUNC 1
>   cglobal hscale8to15_%1, 7, 9, 16, pos0, dst, w, srcmem, filter, fltpos, fltsize, count, inner
> -  pxor m0, m0
> -  mova m15, [swizzle]
> -  mov countq, $0
> -  movsxd wq, wd
> +    pxor m0, m0
> +    mova m15, [swizzle]
> +    mov countq, $0
> +    movsxd wq, wd
>   %ifidn %1, X4
> -  mova m14, [four]
> -  shr fltsized, 2
> +    mova m14, [four]
> +    shr fltsized, 2
>   %endif
>   .loop:
> -  movu m1, [fltposq]
> -  movu m2, [fltposq+32]
> +    movu m1, [fltposq]
> +    movu m2, [fltposq+32]
>   %ifidn %1, X4
> -  pxor m9, m9
> -  pxor m10, m10
> -  pxor m11, m11
> -  pxor m12, m12
> -  mov innerq, $0
> +    pxor m9, m9
> +    pxor m10, m10
> +    pxor m11, m11
> +    pxor m12, m12
> +    mov innerq, $0
>   .innerloop:
>   %endif
> -  vpcmpeqd  m13, m13
> -  vpgatherdd m3,[srcmemq + m1], m13
> -  vpcmpeqd  m13, m13
> -  vpgatherdd m4,[srcmemq + m2], m13
> -  vpunpcklbw m5, m3, m0
> -  vpunpckhbw m6, m3, m0
> -  vpunpcklbw m7, m4, m0
> -  vpunpckhbw m8, m4, m0
> -  vpmaddwd m5, m5, [filterq]
> -  vpmaddwd m6, m6, [filterq + 32]
> -  vpmaddwd m7, m7, [filterq + 64]
> -  vpmaddwd m8, m8, [filterq + 96]
> -  add filterq, $80
> +    vpcmpeqd  m13, m13
> +    vpgatherdd m3,[srcmemq + m1], m13
> +    vpcmpeqd  m13, m13
> +    vpgatherdd m4,[srcmemq + m2], m13
> +    vpunpcklbw m5, m3, m0
> +    vpunpckhbw m6, m3, m0
> +    vpunpcklbw m7, m4, m0
> +    vpunpckhbw m8, m4, m0
> +    vpmaddwd m5, m5, [filterq]
> +    vpmaddwd m6, m6, [filterq + 32]
> +    vpmaddwd m7, m7, [filterq + 64]
> +    vpmaddwd m8, m8, [filterq + 96]
> +    add filterq, $80
>   %ifidn %1, X4
> -  paddd m9, m5
> -  paddd m10, m6
> -  paddd m11, m7
> -  paddd m12, m8
> -  paddd m1, m14
> -  paddd m2, m14
> -  add innerq, $1
> -  cmp innerq, fltsizeq
> -  jl .innerloop
> -  vphaddd m5, m9, m10
> -  vphaddd m6, m11, m12
> +    paddd m9, m5
> +    paddd m10, m6
> +    paddd m11, m7
> +    paddd m12, m8
> +    paddd m1, m14
> +    paddd m2, m14
> +    add innerq, $1
> +    cmp innerq, fltsizeq
> +    jl .innerloop
> +    vphaddd m5, m9, m10
> +    vphaddd m6, m11, m12
>   %else
> -  vphaddd m5, m5, m6
> -  vphaddd m6, m7, m8
> +    vphaddd m5, m5, m6
> +    vphaddd m6, m7, m8
>   %endif
> -  vpsrad  m5, 7
> -  vpsrad  m6, 7
> -  vpackssdw m5, m5, m6
> -  vpermd m5, m15, m5
> -  vmovdqu [dstq + countq * 2], m5
> -  add fltposq, $40
> -  add countq, $10
> -  cmp countq, wq
> -  jl .loop
> +    vpsrad  m5, 7
> +    vpsrad  m6, 7
> +    vpackssdw m5, m5, m6
> +    vpermd m5, m15, m5
> +    vmovdqu [dstq + countq * 2], m5
> +    add fltposq, $40
> +    add countq, $10
> +    cmp countq, wq
> +    jl .loop
>   REP_RET
>   %endmacro

Applied, thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2021-12-16 16:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-16 16:27 Alan Kelly
2021-12-16 16:43 ` James Almer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19e1f04c-f223-0cd6-75b9-ebf8fe8d4553@gmail.com \
    --to=jamrial@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git