From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 917614A60D for ; Mon, 1 Apr 2024 21:25:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9DF7468CF59; Tue, 2 Apr 2024 00:25:41 +0300 (EEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A54F568C2D6 for ; Tue, 2 Apr 2024 00:25:35 +0300 (EEST) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6e6ee9e3cffso3015236b3a.1 for ; Mon, 01 Apr 2024 14:25:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712006733; x=1712611533; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=acBO/WAfc4xhxEX6TLSiEZp4Dvvk6TLOr7ZHbC/P2Dg=; b=CoE5+kQB3OWSbXNa23NJcadbsShGoMVVgaRvySQbD4DoC8yMrnCVERuSSN3iTlssMq ujMiFRn407AwXQ2o9beVwiOeDpfqF0/tyXE0aDt1H9Us+CobWN8lRe0S7LtqjEur5jCQ g/GIazO7XQcqFzSW24LP9UqgcgSSjArO51Zcy5xdB+IO2jDwT6OaIvnnJDJJ30swS5Yb RLaa25Xz6gqp+ZuslgaINpuTMOcInSKl1/KMtpButG2pFLmr/Rr3HjRK4hqE84AScZtZ UHfNikepMbTp6WWq1qjn5MfziJysTSsZ6FN3R+/O2nfldpWKHq8S0zGHISGK04o7FIMj LBmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712006733; x=1712611533; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=acBO/WAfc4xhxEX6TLSiEZp4Dvvk6TLOr7ZHbC/P2Dg=; b=v/aroOA7o82Pt3JrXmm4FAageu1bM/XeJDwpP/h1qbhXeGiEa9HgttJ1X+JjBY/Nm2 4SL71vBFcXLda0u9iinBYRjCieQXzLITTloKgqAb3qhsc4/SVmJW9OOAd8+cYYsCD+sv Gg1lWTfZ//Vsab820fUCwggOE6P2MOo3gqvT3Tnvw+HJ4/sTxbo2SBislZ3RhJoKjpKZ 3699XWOOPY5eDH7lXZDWHfHZRCrCefTSFvcDj7exVr8C9RNttNujiOlLO9I/UhvjigDp DqHFc23CyWC1glpbLChfMWwbtifkuubWZr4u3Ljr6j4/ZgXN3l9qDSIMqwtz0aa+ytCr UO9Q== X-Gm-Message-State: AOJu0YySXwc45bhUkzqJeg4NWElktp2OMRUJh0udNzy3abD8v5aeV5bP 19CJyu8+i0pLpnzfTHNEDCCsVEYUk6JWun9lySXVBjEalcU7KIUf5dpBTIg0 X-Google-Smtp-Source: AGHT+IE3OLLspueukb+YrNYp/gqIBX8up1bCUaWv5NqfRYh4R3CpEZ3GcA6LfuKIu/ueUTCbx0s9uA== X-Received: by 2002:a05:6a00:3992:b0:6e6:2dc9:dcbc with SMTP id fi18-20020a056a00399200b006e62dc9dcbcmr19018806pfb.10.1712006732513; Mon, 01 Apr 2024 14:25:32 -0700 (PDT) Received: from [192.168.0.15] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id o1-20020a056a001b4100b006e6233563cesm8314424pfv.218.2024.04.01.14.25.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Apr 2024 14:25:32 -0700 (PDT) Message-ID: <198d3ea0-04e5-4c66-84da-75a8165c409a@gmail.com> Date: Mon, 1 Apr 2024 18:25:43 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240401205607.9093-1-michael@niedermayer.cc> Content-Language: en-US From: James Almer In-Reply-To: <20240401205607.9093-1-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 1/6] avformat/isom: Uninit layout in ff_mp4_read_dec_config_descr() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/1/2024 5:56 PM, Michael Niedermayer wrote: > Fixes: memleak > Fixes: 67442/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-5068813261406208 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavformat/isom.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/isom.c b/libavformat/isom.c > index 9fbccd4437f..c5930bd4d87 100644 > --- a/libavformat/isom.c > +++ b/libavformat/isom.c > @@ -359,6 +359,7 @@ int ff_mp4_read_dec_config_descr(AVFormatContext *fc, AVStream *st, AVIOContext > st->codecpar->extradata_size, 1, fc); > if (ret < 0) > return ret; > + av_channel_layout_uninit(&st->codecpar->ch_layout); Why is there a custom layout here to begin with? The caf demuxer doesn't export one. > st->codecpar->ch_layout.order = AV_CHANNEL_ORDER_UNSPEC; > st->codecpar->ch_layout.nb_channels = cfg.channels; > if (cfg.object_type == 29 && cfg.sampling_index < 3) // old mp3on4 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".