Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 3/4] ffprobe: expose AVAmbientViewingEnvironment side data in AVFrames
Date: Tue, 10 Jan 2023 18:35:07 -0300
Message-ID: <194f8d6b-3804-e9cf-b16b-b0ecbeaece2e@gmail.com> (raw)
In-Reply-To: <20230110211949.8195-3-jeebjp@gmail.com>

On 1/10/2023 6:19 PM, Jan Ekström wrote:
> ---
>   fftools/ffprobe.c | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
> 
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index d2f126d9d6..15c61e1c7c 100644
> --- a/fftools/ffprobe.c
> +++ b/fftools/ffprobe.c
> @@ -33,6 +33,7 @@
>   #include "libavformat/version.h"
>   #include "libavcodec/avcodec.h"
>   #include "libavcodec/version.h"
> +#include "libavutil/ambient_viewing_environment.h"
>   #include "libavutil/avassert.h"
>   #include "libavutil/avstring.h"
>   #include "libavutil/bprint.h"
> @@ -2268,6 +2269,17 @@ static void print_dynamic_hdr_vivid(WriterContext *w, const AVDynamicHDRVivid *m
>       }
>   }
>   
> +static void print_ambient_viewing_environment(WriterContext *w,
> +                                              const AVAmbientViewingEnvironment *env)
> +{
> +    if (!env)
> +        return;
> +
> +    print_q("ambient_illuminance", env->ambient_illuminance, '/');
> +    print_q("ambient_light_x",     env->ambient_light_x,     '/');
> +    print_q("ambient_light_y",     env->ambient_light_y,     '/');
> +}
> +
>   static void print_pkt_side_data(WriterContext *w,
>                                   AVCodecParameters *par,
>                                   const AVPacketSideData *side_data,
> @@ -2704,6 +2716,9 @@ static void show_frame(WriterContext *w, AVFrame *frame, AVStream *stream,
>               } else if (sd->type == AV_FRAME_DATA_DYNAMIC_HDR_VIVID) {
>                   AVDynamicHDRVivid *metadata = (AVDynamicHDRVivid *)sd->data;
>                   print_dynamic_hdr_vivid(w, metadata);
> +            } else if (sd->type == AV_FRAME_DATA_AMBIENT_VIEWING_ENVIRONMENT) {
> +                print_ambient_viewing_environment(
> +                    w, (const AVAmbientViewingEnvironment *)sd->data);
>               }
>               writer_print_section_footer(w);
>           }

Should be ok.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-01-10 21:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-10 21:19 [FFmpeg-devel] [PATCH 1/4] avcodec/cbs_{h2645, sei}: add support for Ambient Viewing Environment SEI Jan Ekström
2023-01-10 21:19 ` [FFmpeg-devel] [PATCH 2/4] avutil: introduce AVAmbientViewingEnvironment side data Jan Ekström
2023-01-10 21:25   ` James Almer
2023-01-10 21:19 ` [FFmpeg-devel] [PATCH 3/4] ffprobe: expose AVAmbientViewingEnvironment side data in AVFrames Jan Ekström
2023-01-10 21:35   ` James Almer [this message]
2023-01-14 20:03   ` Stefano Sabatini
2023-01-14 20:59     ` Jan Ekström
2023-01-15  1:14       ` Stefano Sabatini
2023-01-10 21:19 ` [FFmpeg-devel] [PATCH 4/4] avcodec/h2645_sei: add support for Ambient Viewing Environment SEI Jan Ekström
2023-01-10 21:33   ` James Almer
2023-01-10 21:34 ` [FFmpeg-devel] [PATCH 1/4] avcodec/cbs_{h2645, sei}: " James Almer
2023-01-11 18:57 ` [FFmpeg-devel] [PATCH v2 " Jan Ekström
2023-01-11 18:57   ` [FFmpeg-devel] [PATCH v2 2/4] avutil: introduce AVAmbientViewingEnvironment side data Jan Ekström
2023-01-11 18:57   ` [FFmpeg-devel] [PATCH v2 3/4] ffprobe: expose AVAmbientViewingEnvironment side data in AVFrames Jan Ekström
2023-01-11 18:57   ` [FFmpeg-devel] [PATCH v2 4/4] avcodec/h2645_sei: add support for Ambient Viewing Environment SEI Jan Ekström
2023-01-13 19:39   ` [FFmpeg-devel] [PATCH v2 1/4] avcodec/cbs_{h2645, sei}: " Jan Ekström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=194f8d6b-3804-e9cf-b16b-b0ecbeaece2e@gmail.com \
    --to=jamrial@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git