From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5E5734803C for ; Sun, 7 Jul 2024 15:21:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9292668DAEC; Sun, 7 Jul 2024 18:21:28 +0300 (EEST) Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E26DB68D998 for ; Sun, 7 Jul 2024 18:21:21 +0300 (EEST) Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-3d91a2c95b2so1357405b6e.3 for ; Sun, 07 Jul 2024 08:21:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720365679; x=1720970479; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=LLUa6nsdrpkN2FCU+Z2h9MDqdWRerjNTIhK2TYkH21I=; b=HGQ136EtZj17yHklae0lFej3YBmUawsFDFP5HIYJ60Ei1KgRShGow5ikK5cOWE7D6r V234NvHtAEm9byMx4GNmrLAh6MOo4p56xCInlwSBEjLJrWjp1E/HBv6yOcRQ1/+HBbhH 9rE0yCt8gAadzKjglXVh6znzqUi+GVer/d4LUv1jSqppp+Rfj443GgD7Su4RWKl90ZBp XLAuYhong39NoKaE/hiC7ehA9HV0pjsj7TLWky01RxrYNv434D3H53wBY26UyrlRoOz+ Zi9BCOZoWD19CiR7DgcssijdhAqlx5rnnE223Aic2L2xS7HY5pRMMxg8Sgf7xDjIPcN4 Ct2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720365679; x=1720970479; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LLUa6nsdrpkN2FCU+Z2h9MDqdWRerjNTIhK2TYkH21I=; b=A6kD41KVrPNg2S6Jg5AYq7wcWs9wwNngWRo0Byo6a+lz/v2Q9wbTOQCjkwYlSpukAy pHod5w0/oxnyfFigwfvkQqwy3VqXRD9ldwGwTYgV2s6hjn0V+LYtnS/wkaa7XbDVLpaK Tp5MNYS3wN8+pD6OJRmYtRDL9Xzx/Szd1b7rXxkmbjsq4z5SI7r11s+/ZEHMRrDim+l5 B804higrLgMCNxpd7rx2WU1H0mhRz2Y9HMXSJ51OG19q8PWuluUsVHp+6PCrdxudLzT0 VCxAS7jjRS9eUoHmzYc3I2PuiF9S4CLIswndwoN4D4dR6GJgBWDxJhkcvCv4YMfCO1LW DopQ== X-Gm-Message-State: AOJu0YzOJk47vzX932nTXVUx/N3hutNEmtyCjZSGYCr4pDAMRu8Bykzi FRr54n65/nk1YV8P1C2eJnFiAqABAxltf/wXr/oVLWrDqNeWDxBKmkn4iQ== X-Google-Smtp-Source: AGHT+IHXn/+lQ9QAvHSqvOK2z0PwWPUF7rtg43SIQd4gyU31+4VJhvRgGUzR2G7vGFOv32pAyu9zZg== X-Received: by 2002:a05:6808:11cc:b0:3d5:2c1c:84c2 with SMTP id 5614622812f47-3d914ea9d93mr12688139b6e.53.1720365679089; Sun, 07 Jul 2024 08:21:19 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b28972857sm1264475b3a.129.2024.07.07.08.21.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Jul 2024 08:21:18 -0700 (PDT) Message-ID: <1946839d-c673-486d-a122-19703d88c636@gmail.com> Date: Sun, 7 Jul 2024 12:21:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: James Almer To: ffmpeg-devel@ffmpeg.org References: <20240703212648.48483-1-jamrial@gmail.com> Content-Language: en-US In-Reply-To: <20240703212648.48483-1-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 01/11] avformat/mov: add support for lhvC box parsing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/3/2024 6:26 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/mov.c | 48 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index a3951a6942..30e8086855 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -8157,6 +8157,53 @@ static int mov_read_dvcc_dvvc(MOVContext *c, AVIOContext *pb, MOVAtom atom) > return ff_isom_parse_dvcc_dvvc(c->fc, st, buf, read_size); > } > > +static int mov_read_lhvc(MOVContext *c, AVIOContext *pb, MOVAtom atom) > +{ > + AVStream *st; > + uint8_t *buf; > + int ret, old_size, num_arrays; > + > + if (c->fc->nb_streams < 1) > + return 0; > + st = c->fc->streams[c->fc->nb_streams-1]; > + > + if (!st->codecpar->extradata_size) > + // TODO: handle lhvC when present before hvcC > + return 0; > + > + if (atom.size < 6 || st->codecpar->extradata_size < 23) > + return AVERROR_INVALIDDATA; > + > + buf = av_malloc(atom.size + AV_INPUT_BUFFER_PADDING_SIZE); > + if (!buf) > + return AVERROR(ENOMEM); > + memset(buf + atom.size, 0, AV_INPUT_BUFFER_PADDING_SIZE); > + > + ret = ffio_read_size(pb, buf, atom.size); > + if (ret < 0) { > + av_free(buf); > + av_log(c->fc, AV_LOG_WARNING, "lhvC atom truncated\n"); > + return 0; > + } > + > + num_arrays = buf[5]; > + old_size = st->codecpar->extradata_size; > + atom.size -= 8 /* account for mov_realloc_extradata offseting */ > + + 6 /* lhvC bytes before the arrays*/; > + > + ret = mov_realloc_extradata(st->codecpar, atom); > + if (ret < 0) { > + av_free(buf); > + return ret; > + } > + > + st->codecpar->extradata[22] += num_arrays; > + memcpy(st->codecpar->extradata + old_size, buf + 6, atom.size + 8); > + > + av_free(buf); > + return 0; > +} > + > static int mov_read_kind(MOVContext *c, AVIOContext *pb, MOVAtom atom) > { > AVFormatContext *ctx = c->fc; > @@ -8943,6 +8990,7 @@ static const MOVParseTableEntry mov_default_parse_table[] = { > { MKTAG('i','p','r','p'), mov_read_iprp }, > { MKTAG('i','i','n','f'), mov_read_iinf }, > { MKTAG('a','m','v','e'), mov_read_amve }, /* ambient viewing environment box */ > +{ MKTAG('l','h','v','C'), mov_read_lhvc }, > #if CONFIG_IAMFDEC > { MKTAG('i','a','c','b'), mov_read_iacb }, > #endif Will apply set. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".