From: James Almer <jamrial-at-gmail.com@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] libavformat.v, libavutil.v: tighten export whitelist
Date: Thu, 3 Jul 2025 13:32:16 -0300
Message-ID: <18fc2b9c-a588-417f-a144-4b44f1520322@gmail.com> (raw)
In-Reply-To: <AS8P250MB07442012919749B2279CC27C8F43A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
[-- Attachment #1.1.1: Type: text/plain, Size: 1187 bytes --]
On 7/3/2025 1:28 PM, Andreas Rheinhardt wrote:
> Scott Theisen:
>> This matches how the other libraries define their exported symbols.
>> ---
>> libavformat/libavformat.v | 5 ++++-
>> libavutil/libavutil.v | 4 +++-
>> 2 files changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavformat/libavformat.v b/libavformat/libavformat.v
>> index 47d5ddcdb1..39aa185309 100644
>> --- a/libavformat/libavformat.v
>> +++ b/libavformat/libavformat.v
>> @@ -1,6 +1,9 @@
>> LIBAVFORMAT_MAJOR {
>> global:
>> - av*;
>> + av_*;
>> + avformat_*;
>> + avio_*;
>> + avpriv_*;
>> local:
>> *;
>> };
>> diff --git a/libavutil/libavutil.v b/libavutil/libavutil.v
>> index fb17058df5..e1aab84554 100644
>> --- a/libavutil/libavutil.v
>> +++ b/libavutil/libavutil.v
>> @@ -1,6 +1,8 @@
>> LIBAVUTIL_MAJOR {
>> global:
>> - av*;
>> + av_*;
>> + avutil_*;
>> + avpriv_*;
>> local:
>> *;
>> };
>
> Is there a problem with the current lists?
Don't think so, but this ensures no symbol is unintentionally exported,
so IMO it's fine.
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-07-03 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 2:56 Scott Theisen
2025-07-03 16:28 ` Andreas Rheinhardt
2025-07-03 16:32 ` James Almer [this message]
2025-07-03 21:05 ` Scott Theisen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18fc2b9c-a588-417f-a144-4b44f1520322@gmail.com \
--to=jamrial-at-gmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git