From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E69E640927 for ; Fri, 24 Dec 2021 08:34:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6B56D68B170; Fri, 24 Dec 2021 10:34:28 +0200 (EET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4E2C268B167 for ; Fri, 24 Dec 2021 10:34:21 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640334866; x=1671870866; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=774iriWQh9bzX9m8vXwl8eChpZc5xDMJniMqyrwbCvQ=; b=h6xl2izcarerZMeIUHwDA2JwO9vsT6KPt0Gzjp8vEvfjMMryCyVL8Wxd 2K0djj/+HrrfnVZtHHQfsOK89flg7PgI3IVaKVr/bt3xT4/onDv3z8y0m jV5PYZTNyhb/tfVSLMFo50LE7OdJkauQUl/YpDEIW0ggmmM3uYGWbrpyH KWnds16mQYRcf+NVIX97eI6q6DMqkwYqxYlPphpmx8RNIVe8vS/6Bcnw/ xNCpM2drI5fye5j5+5caY+NvENTnwYY5aOYh0FuLpaDzbtkNhr2K8mriL +zAylxsPr1Ku0o7BfVBwTPR6jA+dA7PyUnhFz7ny7pb7QS5qxyIiVRVH4 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10207"; a="228252293" X-IronPort-AV: E=Sophos;i="5.88,232,1635231600"; d="scan'208";a="228252293" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Dec 2021 00:34:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; d="scan'208";a="551588625" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 24 Dec 2021 00:34:19 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 24 Dec 2021 00:34:18 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 24 Dec 2021 00:34:18 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 24 Dec 2021 00:34:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iSyD2d+DcDJsawKpwjdSEE2AjJv1b/QIx/4Ir4ot6bZn6lKTADzfZZviLZbGVOlRfmrc2//VfCk2A5aQ30Fx8G1pXjjPApB17zobrPjfe6oJ6W8UtIJ8jM3JXx/h8g6qm6euApfpp9DgEZaGVs2rHtlzbOF1gFCsPNYS+bV0l7He98VKNXeQdvJ5wA3YT3bW7JUVhwF+DJV2wjOwVpR3UqS+IO7h4SOXRxAlorY9POVKKth6UEXcjeblLK5dycMglqQVSgD0h8kKuRtmltWOzTaEHUlKpU3racwpgRiQLjy7bTUSIz+ZA8Qng7atAaU6W9Pp3aapy/jyDFWTgUwbdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=774iriWQh9bzX9m8vXwl8eChpZc5xDMJniMqyrwbCvQ=; b=fqrlX1Dax5+x3PeuJwoedb2CA1F13tJmMvgu3W/xB/TAmrEsIEgL8AESd6zh5CSWWDkTqNQkhVPDVcBrhJgkBC03D/WsTxY1xQQjYUDLpBEsM8xhJnNv17AlHvk6cFijSBIvfoRQdSEgblb7CzBHUGGdPLVrU31OpFvKOOHTyKC/cy3+oS1gm2XBgxvsp4LvYiX1QNrjVYc+Y/stV45NVQfVZMytvqY5sxkbC4vXXZh75j69Tui26RNxxuIqamLK6bzB1+GbvhSpevgiliVUBldE+J9kxBHvgDPoq/iijQpaL8+YSI+R0iUlQwOysYV/wPpwiCbUyHyGd0ZUSYBGMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN6PR11MB4114.namprd11.prod.outlook.com (2603:10b6:405:84::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.16; Fri, 24 Dec 2021 08:34:16 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::bcfc:ceef:cd03:dd16]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::bcfc:ceef:cd03:dd16%3]) with mapi id 15.20.4801.023; Fri, 24 Dec 2021 08:34:16 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH] avcodec/vaapi_encode_vp9: fix > 4k encode fail issue Thread-Index: AQHX+JhnUl9JP5ORjkeWiKaTzcva4axBTKGAgAAEPYA= Date: Fri, 24 Dec 2021 08:34:16 +0000 Message-ID: <18f9cf05233a2fa6c7066417e73b4be15fdd5bc1.camel@intel.com> References: <20210412014724.18563-1-yuankunx.zhang@intel.com> <500807a72989ce22e8e1e2d9602f3c11787dbfb4.camel@intel.com> <20211224081903.GB29574@gmail.com> In-Reply-To: <20211224081903.GB29574@gmail.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 11ff9568-e973-415b-161a-08d9c6b82c3f x-ms-traffictypediagnostic: BN6PR11MB4114:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /rAPRikHmJlQ/OOEuEKKM/0SpPHbZjPsIT4dTaRnPEG48HzKInkjFb3iD9g8smECw0Jl5KSqwHq56uxGKDjB+Qz7VKurBGLH7jgRQO3f4mbwRRKSLiiwGnZFZs3ibKCb/35Uv9rsNXWybndcX1V+D2qO9Z6RpLyHQnIsXS80kE0QyQftw045DBau3EsXJ+sd5j3h7601JSa+ZBv2NxSd5NzULV0sb2sGGm+CwhMCDfyiqdv11y3H7MmWSJ/d2SVOKsMu+iMu938VG18Gw5rmEu8V/hpKHmprBXrr613cpfqCJbaZWrrOAjVaalzBhKRdWJh4GycIx4HqqH+omqzzw0arLseSHOyXWLdR9FnTpCvNYBOyfAM2DPhiBuwwFN5rNbZCRQBxco0TcQ29Zwebc/Xo5wQk0K/f6+LWZt7B0bS6QyLiDwqYJbBvhTZvJ6t/w/ASQgwtGW9VHGsQYR/L0LilMoG9FcxPO5WXm0LrM8FpGR6QuB0yZ4pDK4n7YPi73xYrNkPjNVXFc2zsQtm7UxEyvrGSCor+Z/A0Blun/dglLbWADNKbvMNiJSFKVfMaTgAWfvGzcBDiCsKuMH69ZH9x+3GOIDZHOhONIf2LWroVoJRGjoVZLek988uTx6oX2TKmjf6ESY4y0VTUy6QX55qc38K9MEkHmMj4OEQxGOcDkPvCXK2LtCmuFhNU97O9fXwwKDsdw8TsvTVvyCGBCe0mCbrbp7IWeY8R6j6QBhiX7ExukOYhvJVSydXZnPilXqKGhNrhr4odgVdZWWk9M6m714dtqzM8RR/zscb90j3pXbF7wHF4fs2KmIyIfwRx x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(122000001)(66446008)(91956017)(66476007)(76116006)(6486002)(66946007)(64756008)(83380400001)(36756003)(82960400001)(66556008)(6512007)(6916009)(86362001)(38100700002)(71200400001)(966005)(19627235002)(26005)(2906002)(316002)(508600001)(5660300002)(6506007)(2616005)(8936002)(186003)(38070700005)(4001150100001)(8676002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?M3JGMTcvb3owdmtSRWM0SnBIM0JhMlFrTHJGbFVOQU0vZ0ZkWUg5S0xYWkg4?= =?utf-8?B?U2Q5K1JsTStpUmJiUVV0eDR3MEJHbjlEdnV0L3FNTG1MazU4YlRjdVNwZzBh?= =?utf-8?B?MHQxS2JuKzhwMlZXYkFYclZiaFJ0bk1IUHl4azBwa1Q5YjRaRTlMR0U4amdX?= =?utf-8?B?bEZGWlpTdFo0UWU4RlV3Nm5DVHhyaTNjK1htM3lCZ3VtSTdvYjhKenRKcERQ?= =?utf-8?B?TUd2cHBlL3lpb3NVbjREY29LL0ZnbE9tSTFFQVlLdUs0RmlJNzV1dmNNdjYr?= =?utf-8?B?bVVDWGZPTWh0ZWNKNk1uSmI3Tnh0UnByMlNOeUp3REtsVllqWG9zNjBWNHdr?= =?utf-8?B?MGRGRENLNDNGc24rYXVRekV3UFNYS05oMEJVNTVsS2M4ZlBpbTMzc2gzZUEw?= =?utf-8?B?MUh3N1RkbFp5NHZYdml6anBxSWVuYWprV280aWFmaEk3ZW43ZVJ6L3R5cHQ2?= =?utf-8?B?NTUwTHlJVU8wU0J5ME5TRHFGYkF4a2R0bmhyOFR1ajArcGZPelNYUlZPejJk?= =?utf-8?B?WHU3Y08wd3FtdjFWQUllRXRMdlR6K0dNbkszVWFKYzJBOGxEZGdici9WU09R?= =?utf-8?B?aTBtTit5bXQzSE1NcVNta3RNbHExbG40ZzJTOXRNNUhha0dGT2FvOXB5K0Fm?= =?utf-8?B?czN6LzRGRFpYMjNuNEgvL3RUYkNZYmdGb0xCNG9DQTdWK2xrRHJzaTNBYVpY?= =?utf-8?B?L1FGdjNtVHFuYlFVRDdQTzd4MWs3Qk9VRCtxbXltSkE1bDFGelRKQUh1Vzc5?= =?utf-8?B?YzRUMDhTdkFSTG8zak9xNUNndTZEMEhuRTNCcnVyMkRXWnBZLzd6bEs5bGdS?= =?utf-8?B?TXFIUlhQdnQrMGRjTW5BWFFzQmVEZWloRGd3dUJOMU4zWUwrVVRGZ3BSNndP?= =?utf-8?B?MW5OWjM0UE9OS0F6Z2wxV09HVDJCa2oxaUwwOU84ZU1hZ3R4SUxidXFTUGlM?= =?utf-8?B?SEQ0ODY1RWlrRHV2eENITjlpMFFWR0YvdVpuVitaRkk3clZiOHVWaUEyNmdC?= =?utf-8?B?Mzg3Rjd4Ny93Y2xwL2FmMDluQXRZVjlLay9BYlVhSGRTUkNzcm0xa0dHWFI2?= =?utf-8?B?QU9YNFkvYmEzNGQ2QUFzY3lxdFBPeVh0dU1oVC9hNFRURm9JeGxtejZUWWg0?= =?utf-8?B?NWtpZEsvUVNTMHhwRnNYR1hwdDNYVGxTVW9CL0gxSHYySjlBdktEaDZreThv?= =?utf-8?B?dlJYRTIrT2RuOUtmdlpJemU1VDdPbjYyM2NRYzVURi9yM1VxbGRaMmJRYVc5?= =?utf-8?B?SFh3N01wQTl6VlFNMUVJZ2pSdkFxdGVac3BURmZEZk5YT1FsTnRIMlhVNW1V?= =?utf-8?B?ZWZWWndSS1o1aWNKdGJ2SFViTFhkV2hOV2tnc0JFRXp0dXFOY1MyWXNYYW9z?= =?utf-8?B?dTRMNUs0YTJwSUtOVENLNEV0amhzTFFXU3BRaGFkRFJOM3JiMmFmSmdTZ3hG?= =?utf-8?B?ellsOW5CK2YrNVpwTXF5b2NVNjdHR2JLKy9NaysyaVk4MUtLZWZ0WmZrR3V1?= =?utf-8?B?YnM3NVRDWnJodHRHUjVHQVdoYWF4ZGZ0QmZJaEplTWNlai80RmxkR25WTHZm?= =?utf-8?B?ckNCamtQQmwySk5oMnAyVTdxUGovN2xVcXExV0JucVEvMjAyRjFkcEVNMXla?= =?utf-8?B?U1dSQlpZV1NxemdjOW1aTUQzVjhPblN2MzBCbW4wWFE4eCt4YXM4U29vLzNw?= =?utf-8?B?czh5U1RwVmIxQTNRa3hHY0pwOUg0b0xzckNGc2R6bm85Nis5THdBK1BESXJr?= =?utf-8?B?Z2NGUkVCKzg1Y3hTTnhUNGMwNzZTZ2JqVjcrSzBEZ25SZU5XKzNZSkt3U216?= =?utf-8?B?c2g2N1NtMlIrVmxoSjl2SG56WW5VVEZ0T2ZvN2pZa1RFNUFnZStDdG51azMx?= =?utf-8?B?ZWtaQ0N6OTlENE14UElCOXh0NHlOVlVwYUt3UTNkaGNRWlVQbUZzdjBJRHhI?= =?utf-8?B?RnRyYWFJMXJQOHFwdHBvQUpXZ2tMUStNNkJuMHpYQmZnUWlhTnFTVXJkUnNa?= =?utf-8?B?aHMxUzY0QUIxZFZjclQ3bEovSkY1SjZjRGlod1YxVFF2TEFjVnFXem9ZK3Zs?= =?utf-8?B?NDNQYTZxYnhvSVZsVjVXME1WOHBoaG1aRHhEL082dGhFNVN1WVNCMXJHMnBN?= =?utf-8?B?NWxhOFEvWXg0MnFJN2UyZEgyalhSUHNyQWltYnVNL1FQVHpIdlJKTE56ZHN6?= =?utf-8?Q?wpyn81JmKY/3cj22g4Qdzrk=3D?= Content-ID: <74DB56B489A1D34D9B8BD9BBB6B404DE@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11ff9568-e973-415b-161a-08d9c6b82c3f X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2021 08:34:16.7457 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: K0YOokp79D4VtHY1wmRErn78JtpyD2fF5U05gWGJWhfBW5Vg+pRpZEVK7Ss8JWjvAEa3Dr0DbMLGwiwa1sldHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4114 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] avcodec/vaapi_encode_vp9: fix > 4k encode fail issue X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 2021-12-24 at 16:19 +0800, lance.lmwang@gmail.com wrote: > On Fri, Dec 24, 2021 at 07:32:28AM +0000, Xiang, Haihao wrote: > > On Mon, 2021-04-12 at 09:47 +0800, Zhang yuankun wrote: > > > This patch will fix following command: > > > ffmpeg -hwaccel vaapi -hwaccel_output_format vaapi -i input.264 \ > > > -vf 'scale_vaapi=w=7680:h=4096' -c:v vp9_vaapi output.ivf > > > > > > Max width of a vp9 tile is 4096. If the source frame > 4096, we need split > > > to > > > multiple tiles. > > > > > > Signed-off-by: Zhang yuankun > > > --- > > > libavcodec/vaapi_encode_vp9.c | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/libavcodec/vaapi_encode_vp9.c b/libavcodec/vaapi_encode_vp9.c > > > index 0e1c52c92a..ed45cd6d03 100644 > > > --- a/libavcodec/vaapi_encode_vp9.c > > > +++ b/libavcodec/vaapi_encode_vp9.c > > > @@ -31,6 +31,7 @@ > > > > > > #define VP9_MAX_QUANT 255 > > > > > > +#define VP9_MAX_TILE_WIDTH 4096 > > > > > > typedef struct VAAPIEncodeVP9Picture { > > > int slot; > > > @@ -82,10 +83,17 @@ static int > > > vaapi_encode_vp9_init_picture_params(AVCodecContext *avctx, > > > VAAPIEncodeVP9Picture *hpic = pic->priv_data; > > > VAEncPictureParameterBufferVP9 *vpic = pic->codec_picture_params; > > > int i; > > > + int num_tile_columns; > > > > > > vpic->reconstructed_frame = pic->recon_surface; > > > vpic->coded_buf = pic->output_buffer; > > > > > > + // Maximum width of a tile in units of superblocks is > > > MAX_TILE_WIDTH_B64(64) > > > + // So the number of tile columns is related to the width of the > > > picture. > > > + // We set the minimum possible number for num_tile_columns as defualt > > defualt -> default Thanks, will fix this typo when pushing the patch. > > > > value. > > > + num_tile_columns = (vpic->frame_width_src + VP9_MAX_TILE_WIDTH - 1) / > > > VP9_MAX_TILE_WIDTH; > > > + vpic->log2_tile_columns = num_tile_columns == 1 ? 0 : > > > av_log2(num_tile_columns - 1) + 1; > > > + > > > switch (pic->type) { > > > case PICTURE_TYPE_IDR: > > > av_assert0(pic->nb_refs == 0); > > > > LGTM, will apply > > > > -Haihao > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".