From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8F3234599E for ; Tue, 28 Feb 2023 14:37:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A0B5168A62B; Tue, 28 Feb 2023 16:37:12 +0200 (EET) Received: from btbn.de (btbn.de [136.243.74.85]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A9FC56899F1 for ; Tue, 28 Feb 2023 16:37:06 +0200 (EET) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id 03DCB3BF2A7 for ; Tue, 28 Feb 2023 15:37:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1677595026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=77Y6l0DoHegVRJsHBo26ZRsWNTlY/5nFwPZEuciqvrc=; b=LqN3B6DmM+5TeD06PogbWSETt37a9uoMyRiWc9rd6Kwmt02uWEJ3HNmE8nIWeLMSAsG0/q PpdGYzubMwEwb3jrBwmljxSd9XqJ/zlUa9HT+ig8S4dzdmoeN/iV7+MPysBH7PlEA5qE9q krOdY+llqklY7VD2RSexbwC3AuLFF98N5NzGtPECmlCzfNcLJQ0rev69B3vWwXQV+Yq7Te vJMRblIs4kKE8+T405qU8q0VFN9zBqFf0D9W8/i0aRvFFQed6aNNzPQ5KuCWfTde7SavrG 984tlcf+w5yE9oGiOgNfIv1O/shnN1huDkN6fbbb7KrJoYqHRmGQ+o8R6f4TOg== Message-ID: <18f49cd4-4af8-50f3-82b6-4f2bed2af362@rothenpieler.org> Date: Tue, 28 Feb 2023 15:37:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Timo Rothenpieler In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: fix NULL pointer dereference X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 28.02.2023 19:43, Zhao Zhili wrote: > From: Zhao Zhili > > This can happen if encoder init failed before setup the queue, then > reorder_queue_flush() is called by close(). > > Fix ticket #10221 > > Signed-off-by: Zhao Zhili > --- > libavcodec/nvenc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c > index 8a28454042..dda2dc3ba1 100644 > --- a/libavcodec/nvenc.c > +++ b/libavcodec/nvenc.c > @@ -178,6 +178,8 @@ static void reorder_queue_flush(AVFifo *queue) > { > FrameData fd; > > + if (!queue) > + return; > while (av_fifo_read(queue, &fd, 1) >= 0) > av_buffer_unref(&fd.frame_opaque_ref); > } This should probably be an assert0, and the function should not be called to begin with if the queue is NULL. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".