Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Lynne via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Lynne <dev@lynne.ee>
Subject: Re: [FFmpeg-devel] [PATCH v3 01/10] channel_layout: add new channel positions supported by xHE-AAC
Date: Sun, 26 May 2024 23:42:41 +0200
Message-ID: <18e1fbb8-3630-4c22-abbd-05f236107bc1@lynne.ee> (raw)
In-Reply-To: <467d6a51-fe08-f8df-7d03-7d842ea804d3@passwd.hu>


[-- Attachment #1.1.1.1: Type: text/plain, Size: 2467 bytes --]

On 26/05/2024 22:51, Marton Balint wrote:
> 
> 
> On Sun, 26 May 2024, Lynne via ffmpeg-devel wrote:
> 
>> On 25/05/2024 08:10, Marton Balint wrote:
>>>
>>>
>>>  On Sat, 25 May 2024, Lynne via ffmpeg-devel wrote:
>>>
>>>>  apichanges will be updated upon merging, as well as a version bump.
>>>>  ---
>>>>  libavutil/channel_layout.h | 4 ++++
>>>>  1 file changed, 4 insertions(+)
>>>>
>>>>  diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h
>>>>  index 8a078d1601..4e19bbbd9e 100644
>>>>  --- a/libavutil/channel_layout.h
>>>>  +++ b/libavutil/channel_layout.h
>>>>  @@ -79,6 +79,10 @@ enum AVChannel {
>>>>      AV_CHAN_BOTTOM_FRONT_CENTER,
>>>>      AV_CHAN_BOTTOM_FRONT_LEFT,
>>>>      AV_CHAN_BOTTOM_FRONT_RIGHT,
>>>>  +    AV_CHAN_SURROUND_LEFT,
>>>>  +    AV_CHAN_SURROUND_RIGHT,
>>>
>>>  You want to add a channel ID for Surround or Side Surround? Because 
>>> based
>>>  on the subsequent AAC patch you want to add it for side surround, 
>>> but then
>>>  the AV_CHAN_SURROUND name is confusing, since we are mapping 
>>> Surround to
>>>  AV_CHAN_SIDE. So I suggest using AV_CHAN_SIDE_SURROUND_LEFT/RIGHT 
>>> instead.
>>>
>>>>  +    AV_CHAN_TOP_SURROUND_LEFT,
>>>>  +    AV_CHAN_TOP_SURROUND_RIGHT,
>>>
>>>  You will need to extend the channel_names[] array in 
>>> channel_layout.c with
>>>  the newly added channel IDs.
>>
>>
>> Thanks, changed locally.
>> Planning on merging this in 2 days unless there are more comments.
> 
> Can you post the updated version of this patch? It is not entirely clear 
> what you added, or e.g. what abbriviation you planning to use for the 
> new channel IDs. Also I noticed one more thing, you also need to add the 
> AV_CH_* variants for the new IDs.

Sure, posted.
I went with exactly what you wrote.

> 3 days for new API such as this is a bit short, and if your AAC patches 
> depend on it, I suggest you wait a few more days.

...its an enum entry. Do you want a design document and a proposal?
You could talk to the person who did the research about it, JEEB.
Why wait at all? There's only you and JEEB that care about channel 
layouts, you can review it and give it an LGTM. There's no reason to 
wait for days, that is not how reviewing is supposed to work.

The decoder doesn't depend on it, I have fallback code. I've been 
waiting for the channel layout situation to be resolved.

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2024-05-26 21:42 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-25  2:27 [FFmpeg-devel] [PATCH v3 00/10] aacdec: add a native xHE-AAC decoder Lynne via ffmpeg-devel
2024-05-25  2:27 ` [FFmpeg-devel] [PATCH v3 01/10] channel_layout: add new channel positions supported by xHE-AAC Lynne via ffmpeg-devel
2024-05-25  6:10   ` Marton Balint
2024-05-26 18:16     ` Lynne via ffmpeg-devel
2024-05-26 20:51       ` Marton Balint
2024-05-26 21:35         ` [FFmpeg-devel] [PATCH v4] fate: add tests for xHE-AAC Lynne via ffmpeg-devel
2024-05-26 21:37         ` [FFmpeg-devel] [PATCH v4 01/10] channel_layout: add new channel positions supported by xHE-AAC Lynne via ffmpeg-devel
2024-05-27 14:11           ` Jan Ekström
2024-05-27 19:31             ` Marton Balint
2024-05-28 21:20               ` Jan Ekström
2024-05-28 21:38                 ` Marton Balint
2024-05-28 22:12                   ` Lynne via ffmpeg-devel
2024-05-29 19:41                     ` Marton Balint
2024-05-26 21:42         ` Lynne via ffmpeg-devel [this message]
2024-05-27  8:40           ` [FFmpeg-devel] [PATCH v3 " Anton Khirnov
2024-05-27  8:54             ` Lynne via ffmpeg-devel
2024-05-27  9:07               ` Anton Khirnov
2024-05-27 10:48                 ` Lynne via ffmpeg-devel
2024-05-25  2:27 ` [FFmpeg-devel] [PATCH v3 02/10] aacdec: move from scalefactor ranged arrays to flat arrays Lynne via ffmpeg-devel
2024-05-25  2:27 ` [FFmpeg-devel] [PATCH v3 03/10] aacdec: expose channel layout related functions Lynne via ffmpeg-devel
2024-05-25  2:27 ` [FFmpeg-devel] [PATCH v3 04/10] aacdec: expose decode_tns Lynne via ffmpeg-devel
2024-05-25  2:27 ` [FFmpeg-devel] [PATCH v3 05/10] aacdec_dsp: implement 768-point transform and windowing Lynne via ffmpeg-devel
2024-05-25  2:27 ` [FFmpeg-devel] [PATCH v3 06/10] aactab: add deemphasis tables for USAC Lynne via ffmpeg-devel
2024-05-25  2:28 ` [FFmpeg-devel] [PATCH v3 07/10] aactab: add tables for the new USAC arithmetic coder Lynne via ffmpeg-devel
2024-05-25  2:28 ` [FFmpeg-devel] [PATCH v3 08/10] aactab: add new scalefactor offset tables for 96/768pt windows Lynne via ffmpeg-devel
2024-05-25  2:28 ` [FFmpeg-devel] [PATCH v3 09/10] aacdec: add a decoder for AAC USAC (xHE-AAC) Lynne via ffmpeg-devel
2024-05-27 17:36   ` Andreas Rheinhardt
2024-05-25  2:31 ` [FFmpeg-devel] [PATCH v3 10/10] fate: add tests for xHE-AAC Lynne via ffmpeg-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18e1fbb8-3630-4c22-abbd-05f236107bc1@lynne.ee \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=dev@lynne.ee \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git