From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 2DF8449F98 for ; Thu, 17 Jul 2025 09:33:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id ACB0F68EC46; Thu, 17 Jul 2025 12:33:14 +0300 (EEST) Received: from PAUP264CU001.outbound.protection.outlook.com (mail-francecentralazon11021138.outbound.protection.outlook.com [40.107.160.138]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 7CA9D68EBE3 for ; Thu, 17 Jul 2025 12:33:08 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NIbY3bSHMuxQ5n2cIApovC4hP5wDgct8kIOiZOrazhFs6XrcU1RxLHUi3ItNTdZaXbluXFaSbrAKAV9CZBsa436LAIAug8T4EhkvcY4uPCMmuw9U9zmc08/Jp8bOavg9F/P+qSCVs1QSdGzSZBIlgFW/0UC5oCmzq3sINxboxMwxhKdJHlfHWaqs4AH0AtGh1DrRDqlLKp95LcqRiBZ3woxS5oVP1OrJl/eur/E9Ft0vnGQlugcPhJUVzTj8uPoj0bEEv1DtzXtKbYCPhjilhYSJgKxPRAU18fLAtQGdr1Xct/vaROX0zl5ok7pban+rT5VrWGz6lybkhrvHwG5j0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1DGlv1GAFgL2HmXuHjRtPtEoiHLOwBXU9XkJoP9l5Xc=; b=ptrNQ0Y4tEsLneUIQnKiWUazuXb0wLZ4N1Jx8T+w+ctpOHTHtWjN8j6z/fpU0KDYWZJKJ10el8RnaNPRFrtAuKZWkwDUWzH6Qz6K1U1MizhnQESbZqimtIaMSqHhQ5lcaqX0EYS6YI5TvnTiOc/qTS3DyT0zmBLo9tcQsZZvb1wOGTCLux+zjLcYd0KL4beuQTQduHCr6FJGjyLqQnxX4MXdmagHY+71jB18uaUAaAAOamvG28DeH/Dzn71XGgfFleejQNJtEHfqJFFUL1B1mBDNLS3g+F4ntYU+N3Iu5fSRpuVcdH7mhW4dR4lEtfCaPA8k8YcA3cUmMUJd6UPh6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cji.paris; dmarc=pass action=none header.from=cji.paris; dkim=pass header.d=cji.paris; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cjiparis.onmicrosoft.com; s=selector1-cjiparis-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1DGlv1GAFgL2HmXuHjRtPtEoiHLOwBXU9XkJoP9l5Xc=; b=hiQcKNwmUTlD25doj2fFOv4+Dk4DG1e0bFIRYfd4E52HvKm//BlKLHGGKvtrVfHURXrHIncpl0zjiV+UHXAWAvUyPVVA1luwc9bDn+xCgljPhJy1dNkoUVJmCygdzuCFyycImMDyPccVJo2thtMNttSV8d0tD0Sh5GOSOZwKN+KcpGiJH0To040RiHpMnglNlvk0PzIDuSwdZPguIyU++ywSaCzhlv8YczOmoxOxuidVbS6bquM0zBu67Q3EvIe5PHPyFDSLVSNnJmSIuPCMfT0rabp3cp8WE6AyZ6R3WeisefHUoVUCkJrVxUW7L+nTqaCLc2jEXZgxBug8aBnAuw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cji.paris; Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:34::23) by PR1P264MB1807.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:192::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8922.39; Thu, 17 Jul 2025 09:33:05 +0000 Received: from MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::a9db:c8aa:ffcb:e463]) by MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM ([fe80::a9db:c8aa:ffcb:e463%5]) with mapi id 15.20.8922.037; Thu, 17 Jul 2025 09:33:05 +0000 Message-ID: <18cd60a1-c6ec-4b6a-9959-a52f5f8dbe08@cji.paris> Date: Thu, 17 Jul 2025 11:33:04 +0200 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20250711095439.332634-1-nicolas.gaullier@cji.paris> <20250711095439.332634-2-nicolas.gaullier@cji.paris> Content-Language: en-US From: Nicolas Gaullier In-Reply-To: <20250711095439.332634-2-nicolas.gaullier@cji.paris> X-ClientProxiedBy: PR3PR09CA0028.eurprd09.prod.outlook.com (2603:10a6:102:b7::33) To MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:34::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MR1P264MB2483:EE_|PR1P264MB1807:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b8a209e-f285-481a-3dbd-08ddc514ee81 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?b3krV2t2RlZpYmlJbDBmSm8xRkN0Wk1RWldhRWFqczBDbFlFWXNlQ2R5blZt?= =?utf-8?B?NEF5anNRUTE4NmdnWkkxRkNnbGpKdG9VRVRab3F4Rzg2Unh0WFBlTUNNVlhw?= =?utf-8?B?WWt5RmR0Y3E2UjVqVEFBVUhlTXFqZ2ZtdEFiNVNUNmRQQWxmT2ZYOHhwdlJG?= =?utf-8?B?VU53QzA5a2FnRzJuNTAvMnVjU28ybFZ5dkg0QTdJMi9kb1V5RHQ5QTZVbjJa?= =?utf-8?B?K0xXN1dLcy9xQTltczZTd01DZWNxQ0YyZjFvbnlXR2hibVppUThnc1ozWDVU?= =?utf-8?B?aDRvUmJXS1hQN2dUdjE0ei9IMVhUdFdkbEpRZlRNeFU1dWg3aUlTRVgvUVl2?= =?utf-8?B?T1A0ZjIzZ2tOdDFUU01HSWlTMzUvVmxKOVFhbjYwQk5nUnZjNEMzcEhTTXJZ?= =?utf-8?B?TUo5Q3hUL1VndTFZdCtscllueDYvMHpYaTZ5UHNqUjNOZGVCTWd2R3BCMEdi?= =?utf-8?B?elZwMjFiNGNPSU1xRVRjMjVNVExGdlk5Z2ZlVzc5cWc2VitCcTJ6SWlML3RZ?= =?utf-8?B?MnlpOE5NbjJUc2E5RE1aVjIrVVZRdWhVQ1hPUlNiN3hGcWNibmozUDY1WTYy?= =?utf-8?B?cTNWS3dhMldmdjJSc3Nua3F2T2pBMWM2Y01FS2twU3IyQkY5UDFBTlNYL1pz?= =?utf-8?B?ZFFQR0tiSDlPSEV2QXpEL1AzYkhYSm9CaU5JUVZmYit5WWkwVVVNTGFGZmtj?= =?utf-8?B?ZmRsN05BdDNKamIwL1lrOWFYaHAzNEZnUDROTlo1RWwyS3lpQVNCbG1wZERr?= =?utf-8?B?Vm1JOW5Sb3YzY1FUWGQyYUkrWnIxeG5WNXRnVGtzaXp1UXZ3Qm80ei9zM1RM?= =?utf-8?B?RTVOa2FGTG5jei84NEU3b2pmL0V5Um12QnVXMXJVRWgrVEcvSVJBT0hXY3hZ?= =?utf-8?B?NFFNRkFLc1E2SVA2U3lPZkxmWS9RUlpXam5hNHAxeGJIRjVBS0VFT2JKU3pO?= =?utf-8?B?QW5NZHl3MWttSHhDdTltc3hsTVJGUnJzUXIxeXV6cHkrQVBDd2NyRGxVR3F3?= =?utf-8?B?ekRickpiM0lsNi9yL0tvK2ZOc2ZuTThDVVZxTGRqK2tzdkdVQmVENXN0T3FZ?= =?utf-8?B?V0JJYzEvRktoZHI5SnVCUERjRFRsc21CRUV1bkg0MWphWiswS0FSNjZlQUZp?= =?utf-8?B?dXdtM0Mrd2JScTF0ajRDVlZ0MkpJZDBxSEQrOU8rVlYyVXZFdHhFVE1HRjE0?= =?utf-8?B?NnVUVVZZRHArVkNnUFF1UTltTjJvSE9ON0FNcjdYTTBZZU9ON1ZHRnlqV3RV?= =?utf-8?B?dUxWRGRaaUhEc2VqSWN3NU11ZjB3MGw3dWJPUUVxclpqK3c3eWpaeDRkMHhs?= =?utf-8?B?eWlwdWJKeElRNlN4blZaMjZzWlhibUFocnJXOEhjRjNLNlVMUnR0SmNXUzA2?= =?utf-8?B?Q0drZWdVWFdWY2dEWVptQ1BBY0tPem4yVVlZTU05OVpHbXFvenl6eFFSSHR5?= =?utf-8?B?MUwzaG42K2xPZmljakdVZnRsM2gzTTI3UUZCbDU4UU1hM29MZGlENWNJYTVp?= =?utf-8?B?TEtwNmNMdWF1alJJeWlFYm82bUI1UmRSbTBNN0pWNVNpYlpnbkROOWU5S2xV?= =?utf-8?B?aXEra0JSRnlkREI4UmV3dHJjQXMweHNLMEE0cTNJUU9Gd3NyWHpwQUhJZ3N3?= =?utf-8?B?ajJDaGlzQ3ZiUWpBQ2tFTjlaYnVyRDNQN3ZzZUt1TGdlVnNraU5pNUlGK1JY?= =?utf-8?B?UzBUcGlFdGZNM1dlWFdSNVZFbjh2Zk84WEZGVUNBQ1pVQUIrTzlLd0ZaQ0Jl?= =?utf-8?B?TDJVRm9WQzA1YTE1MHFZWFFDYXNvdUE0VEd2VFIvVmVZejN1cTBGeTh6SG5B?= =?utf-8?B?bzhJMHZYU2QrNnFGNVd3djhHYXJSdUI3QWFONlJCUDNHTkdFMHZjVkVvWGFR?= =?utf-8?B?dnYrRkR2dmJ5MFNNS0Z2WEZsL1ZTd1FHbGlyUnJDb212NFV2Z0VjTnVWRk1q?= =?utf-8?Q?j2V5+LF95BE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmY4L0lxRWtlQ3UwbXNydDgvOVpUcXJLQmpPZlV6dTBWR20wMmRxVXpRV0pB?= =?utf-8?B?WEdSdjNuKzNWOEtzbVhZMGRSRkF0dTdMc2gvQUxrQWVYMDZ5c3p2QzM5aGZN?= =?utf-8?B?QmtKdllsdEVnd2w4NHlDYmx4aU5oQTRRZjdDZGtjQ0J6ZkVxQ3NBVVVoK2Ni?= =?utf-8?B?Wm1qYlNaWFJaS3RMMmNBSFFZa0ljaDhZMW13K0VZRHhmOENsTmtSdWlSdVVK?= =?utf-8?B?V21PQkZ3ODUrSU9kOEFXZVgyTlBZeEhVbFIxbitka0hWd3lCWWRQcmFyejhx?= =?utf-8?B?RFdQc0puOXRtQ0ovWVptVmc4ZTkycjlHVmc5MFV5SGVCMVAxa0ZqbnIwbDdP?= =?utf-8?B?RkhWVm10azFmWHRjQzg1RUE1UENoSXVFcW40Nkxma2w2ZXdlckFGOUxycjMy?= =?utf-8?B?NVU0WTg1SndZQUsyWTFMaWRsY3V1MWRma0RqdGpVSWhBemROeDVBWThMbWtP?= =?utf-8?B?Yk05WlBoV3hROHFLVE5vSlgwMUpRU29GN3JMdlk2Z1dwQXExK01lN2hQTWwv?= =?utf-8?B?MjIzMmxGOURYNCtUakwzNjE4UEFWMUo1UDNCNlhWWnJQOGF0TldJc3lkanZE?= =?utf-8?B?WTdxS0NWZFkvQVdtaDIzQUQ1LzNpVUc2Uk9pUkpXREpaZXBUdThRdnZDd1Jx?= =?utf-8?B?NWQxVHIrcmNqZFlFOFRQTTRtZnVDSUkySVczU09mUGwyekFXaDZGZ2JsV0Za?= =?utf-8?B?UktWeDNxVkJJajFpOE5LVjBYUVF3eW55bnFhV0Z0Ti90MS9xTEJBd05yc2xa?= =?utf-8?B?ckk1SFZBZ0doMUp5czlFTzlTUG9UYk9kQlNoT3lDMkU5QjFrR2hmb1ZlK2FU?= =?utf-8?B?RzF1aWZKM0k3eTV6U0tFYWs0WnRxL2JKOTFNbXRRdS9PZUdpc29ORkgyRFZ4?= =?utf-8?B?U0t3QkU0V29NWHRkZDhNU240QzR0SnhHblM0cDBJZWtleW5yRStBMm5mdXVs?= =?utf-8?B?eE1NTHkxZDB4OFlKcXpab2dvQU42bDIzMTR1Mmk4aFJpN0NOVG45V3JYNEd6?= =?utf-8?B?ZWRjcy84N0ZobGR0MmtoUldnUzdXZUw3UG5aT0dKVUR0VGttYzV4VVZuc1VD?= =?utf-8?B?Tmd2aytkbE5GWnlpUzM2SWd4YnFzdUVteWhDS0QzVk5wWXBSYmYyZEtOYmly?= =?utf-8?B?WkV6MERZcjNjMENUcC9VczRrR1p6ZkNpYXlScTdkcEdpK29BUFlhTVVLTzBT?= =?utf-8?B?YnRGdnN1cW96czJ3eStYWWJQRkl5NWREeUNZYU5sdTZUOXFCQjFOZ0h0Y3Ja?= =?utf-8?B?VGtzQ0s0RUhBYUdkTU9RTU85QW1qdlg5UG5DeTk4d0N2dExsWXREUDk2UkpR?= =?utf-8?B?Y2RIWnZGeWhEdmdlT0J0U3ZVWmUwOTJnZ0dTa2c5SmF2Z1pLK3BKdVB4YmRS?= =?utf-8?B?dyt5bS9kTnFDVFZFdDluMUdtOGFoWkQ3V0s2YXJvN0l3L0VLUDJwbHZMbkZN?= =?utf-8?B?WmMzbmxuczRWYUpNT3pFdHhWcEo1alpMRzNKa1ZKOW8wVnhETzl4RXBtQ2lF?= =?utf-8?B?VE9jVnNMWlR3SWpIQ0VGSDVtaE9uVFhrTURsL3IzZ1djTElHdUJxMk44ZzQ0?= =?utf-8?B?alpLL0Vpei8velcxNE8zbmpQM1c1OXNscmJncTlPRVlSOUxsY3prYTd0NW96?= =?utf-8?B?aWYzZkE4KzhNT3ZXWk5UYWdHYmxNV0hoNVkwWUVzWFVnUy85N0ZFZ0VrajBU?= =?utf-8?B?QkVocFZTMW81cGZTN05MSFg5c0tPazFNNUVBTk4vUXliT2h1c0dweVYzbC95?= =?utf-8?B?UlVaTXc1cHVTdVM2WCs1UUJFdzBEVkVWc3Q5bWpERHpvaWltb2Z1dkJUUEtq?= =?utf-8?B?S3JQUXlFNVViSDRQb3BaaFV4OExIVTJBbUJFNm1obEpHK2NFWFArUzZONEpz?= =?utf-8?B?WjBnRmRjNEZWTmdqY0tzUVBJRWk5cTBpT2prclFxMDFvQlNrZlBRb3ZPbVF5?= =?utf-8?B?MnZFaFk1QWRKQ1E4UlJST2FNWkZzSGVEbDlwTkh5Njdkb0dkdjVKdXo0Vk5x?= =?utf-8?B?MzZzbHdlMHkrNDg2SzFLTGpxMTc5TjlmMjB3bDB6VTMxalc4WmorNTJmcDlT?= =?utf-8?B?WVc1ejU3OWg1c1AvQ0lmQlorR1NXVHdEZ2c1OGFmM3p3aS9STEU4cXF4VDV6?= =?utf-8?B?UWhaNWNFVDNYUGU2OU1KNk1hL1ZGN2F6a2RQUTBSUEQxb09Ic1lQaG52Wmd0?= =?utf-8?B?c2c9PQ==?= X-OriginatorOrg: cji.paris X-MS-Exchange-CrossTenant-Network-Message-Id: 6b8a209e-f285-481a-3dbd-08ddc514ee81 X-MS-Exchange-CrossTenant-AuthSource: MR1P264MB2483.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2025 09:33:04.9707 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fc5390bc-7da7-4e42-b72b-a373be305b62 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +5O2r5q8oP4JeMBMl2vTxURf/IV5+jzd02MDRkey1zX8qALus5TXNM5nHFwqZ3H4e0QcxeWrFeBPr8jNYx78J2mczXTtJOZai7wgHzTM16Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR1P264MB1807 Subject: Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec/aac_ac3_parser: simplify X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/11/25 11:54, Nicolas Gaullier wrote: > Remove unused USAC/ADTS code: ff_adts_header_parse() parse the > object_type from a 2 bits field. > See also 696ea1c2236842572df88d573e24a39be3f19c98. > > Use ff_adts_header_parse_buf() wrapper to simplify as GetBitContext is > no longer needed (it was introduced for USAC). > > Partially reverts 64bb91fd3b5a00a8849531c7e8dd207f2a626096. > > Signed-off-by: Nicolas Gaullier > --- > libavcodec/aac_ac3_parser.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/aac_ac3_parser.c b/libavcodec/aac_ac3_parser.c > index e10ce13a3b..b49ce0277c 100644 > --- a/libavcodec/aac_ac3_parser.c > +++ b/libavcodec/aac_ac3_parser.c > @@ -147,15 +147,14 @@ get_next: > } else { > #if CONFIG_AAC_PARSER > AACADTSHeaderInfo hdr; > - GetBitContext gb; > > - init_get_bits8(&gb, buf, buf_size); > if (buf_size < AV_AAC_ADTS_HEADER_SIZE || > - ff_adts_header_parse(&gb, &hdr) < 0) > + ff_adts_header_parse_buf(buf, &hdr) < 0) > return i; > > avctx->profile = hdr.object_type - 1; > - s1->key_frame = (avctx->profile == AV_PROFILE_AAC_USAC) ? get_bits1(&gb) : 1; > + /* ADTS does not support USAC */ > + s1->key_frame = 1; > bit_rate = hdr.bit_rate; > #endif > } Ping ? If you don't like this patch for whatever reason, I can just drop it and send the second patch (which is more important - fix ticket) independently, no big deal. I still think at least the key_frame setting/USAC thing should be removed because it makes think USAC is possible which is not at all. Nicolas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".