From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AB7BE4339F for ; Thu, 9 Jun 2022 18:44:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3D69568B771; Thu, 9 Jun 2022 21:44:34 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D3BA868B6FA for ; Thu, 9 Jun 2022 21:44:27 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id DF743E72B5 for ; Thu, 9 Jun 2022 20:44:27 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AAz7kEuVTjCl for ; Thu, 9 Jun 2022 20:44:26 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 163F6E1389 for ; Thu, 9 Jun 2022 20:44:26 +0200 (CEST) Date: Thu, 9 Jun 2022 20:44:26 +0200 (CEST) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: Message-ID: <18b8e22c-1d10-879b-bee2-1b128f176f3d@passwd.hu> References: <137512e-90a-d163-d7a0-8d7e9309724@passwd.hu> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v6] libx264: Set min build version to 158 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 8 Jun 2022, Soft Works wrote: >>> - { require libx264 "stdint.h x264.h" >> x264_encoder_encode "-lx264 $pthreads_extralibs $libm_extralibs" && >>> - warn "using libx264 without pkg-config"; >> } } && >> >> x264 without pkg-config feature got removed. If this is intentonal, >> then maybe you should mention this in the commit message? > > I cannot honestly say that I would be sure about this part. Matt had > this removed in his original patch and objections were made about the version > requirement, but none about the removal of the "non-pkg-config" condition. > > Would there be any reasons to keep it? Probably not. Removing it is fine by me, but the removal should be stated in the commit message. > >> >>> - require_cpp_condition libx264 x264.h >> "X264_BUILD >= 118" && >>> - check_cpp_condition libx262 x264.h >> "X264_MPEG2" >> >> Why is the x262 check got silently removed? This does not seem to belong >> to this commit.` > > Matt had removed it and there was a comment about it saying that it > would by dysfunctional for a long time already. > > By a funny coincidence, Gyan has submitted a patch for complete removal > of this: > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220527082922.994-1-ffmpeg@gyani.pro/ > > Whether it belongs into this patch or not could be seen from two sides: > > On one side, you could say that THIS patch is about updating and adapting > the x264 conditions to the state of time, but you could also say that > it must rather be in Gyan's patch (which it is anyway). > > Just let me know when you think I should change it. I'd rather keep the X262 cpp check for now. Thanks, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".